From 4a98b48751984f0cb80c5bd6ad7924df41a219c5 Mon Sep 17 00:00:00 2001 From: Henning Baldersheim Date: Wed, 15 Mar 2023 19:22:30 +0000 Subject: - GC unused _activeBuffers member. - Just keep a very small ChangeVector, it might never be used. --- vespalib/src/tests/datastore/array_store/array_store_test.cpp | 8 ++++---- vespalib/src/tests/datastore/datastore/datastore_test.cpp | 2 +- vespalib/src/tests/datastore/unique_store/unique_store_test.cpp | 2 +- vespalib/src/vespa/vespalib/datastore/buffer_type.h | 5 ++--- 4 files changed, 8 insertions(+), 9 deletions(-) (limited to 'vespalib') diff --git a/vespalib/src/tests/datastore/array_store/array_store_test.cpp b/vespalib/src/tests/datastore/array_store/array_store_test.cpp index 8ee9eaeb4f7..ccc3ab88c31 100644 --- a/vespalib/src/tests/datastore/array_store/array_store_test.cpp +++ b/vespalib/src/tests/datastore/array_store/array_store_test.cpp @@ -210,12 +210,12 @@ INSTANTIATE_TEST_SUITE_P(NumberStoreFreeListsDisabledMultiTest, TEST_P(NumberStoreTest, control_static_sizes) { static constexpr size_t sizeof_deque = vespalib::datastore::DataStoreBase::sizeof_entry_ref_hold_list_deque; - EXPECT_EQ(416u + sizeof_deque, sizeof(store)); + EXPECT_EQ(408u + sizeof_deque, sizeof(store)); EXPECT_EQ(240u + sizeof_deque, sizeof(NumberStoreTest::ArrayStoreType::DataStoreType)); - EXPECT_EQ(112u, sizeof(NumberStoreTest::ArrayStoreType::SmallBufferType)); + EXPECT_EQ(104u, sizeof(NumberStoreTest::ArrayStoreType::SmallBufferType)); MemoryUsage usage = store.getMemoryUsage(); - EXPECT_EQ(202144u, usage.allocatedBytes()); - EXPECT_EQ(197776u, usage.usedBytes()); + EXPECT_EQ(202120u, usage.allocatedBytes()); + EXPECT_EQ(197752u, usage.usedBytes()); } TEST_P(NumberStoreTest, add_and_get_small_arrays_of_trivial_type) diff --git a/vespalib/src/tests/datastore/datastore/datastore_test.cpp b/vespalib/src/tests/datastore/datastore/datastore_test.cpp index 7121bf5ce11..df347267c7e 100644 --- a/vespalib/src/tests/datastore/datastore/datastore_test.cpp +++ b/vespalib/src/tests/datastore/datastore/datastore_test.cpp @@ -665,7 +665,7 @@ TEST(DataStoreTest, can_reuse_active_buffer_as_primary_buffer) } TEST(DataStoreTest, control_static_sizes) { - EXPECT_EQ(96, sizeof(BufferTypeBase)); + EXPECT_EQ(88, sizeof(BufferTypeBase)); EXPECT_EQ(24, sizeof(FreeList)); EXPECT_EQ(56, sizeof(BufferFreeList)); EXPECT_EQ(1, sizeof(BufferState::State)); diff --git a/vespalib/src/tests/datastore/unique_store/unique_store_test.cpp b/vespalib/src/tests/datastore/unique_store/unique_store_test.cpp index 0de44eb373e..5ccf9a8908c 100644 --- a/vespalib/src/tests/datastore/unique_store/unique_store_test.cpp +++ b/vespalib/src/tests/datastore/unique_store/unique_store_test.cpp @@ -471,7 +471,7 @@ TEST_F(DoubleTest, nan_is_handled) TEST_F(DoubleTest, control_memory_usage) { static constexpr size_t sizeof_deque = vespalib::datastore::DataStoreBase::sizeof_entry_ref_hold_list_deque; - EXPECT_EQ(376u + sizeof_deque, sizeof(store)); + EXPECT_EQ(368u + sizeof_deque, sizeof(store)); EXPECT_EQ(144u, sizeof(BufferState)); EXPECT_EQ(28740u, store.get_values_memory_usage().allocatedBytes()); EXPECT_EQ(24804u, store.get_values_memory_usage().usedBytes()); diff --git a/vespalib/src/vespa/vespalib/datastore/buffer_type.h b/vespalib/src/vespa/vespalib/datastore/buffer_type.h index 53436df432f..bedbb2c984e 100644 --- a/vespalib/src/vespa/vespalib/datastore/buffer_type.h +++ b/vespalib/src/vespa/vespalib/datastore/buffer_type.h @@ -85,7 +85,7 @@ protected: ElemCount dead_elems; BufferCounts() : used_elems(0), dead_elems(0) {} BufferCounts(ElemCount used_elems_in, ElemCount dead_elems_in) - : used_elems(used_elems_in), dead_elems(dead_elems_in) + : used_elems(used_elems_in), dead_elems(dead_elems_in) {} }; @@ -99,7 +99,7 @@ protected: const std::atomic* dead_ptr; Element() noexcept : used_ptr(nullptr), dead_ptr(nullptr) {} Element(const std::atomic* used_ptr_in, const std::atomic* dead_ptr_in) noexcept - : used_ptr(used_ptr_in), dead_ptr(dead_ptr_in) + : used_ptr(used_ptr_in), dead_ptr(dead_ptr_in) {} }; std::vector _counts; @@ -119,7 +119,6 @@ protected: // Number of arrays needed before allocating a new buffer instead of just resizing the first one uint32_t _numArraysForNewBuffer; float _allocGrowFactor; - uint32_t _activeBuffers; uint32_t _holdBuffers; size_t _holdUsedElems; // Number of used elements in all held buffers for this type. AggregatedBufferCounts _aggr_counts; -- cgit v1.2.3