1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
// deploy command tests
// Author: bratseth
package cmd
import (
"bytes"
"io"
"path/filepath"
"strconv"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/vespa-engine/vespa/client/go/internal/mock"
"github.com/vespa-engine/vespa/client/go/internal/vespa"
)
func TestDeployCloud(t *testing.T) {
pkgDir := filepath.Join(t.TempDir(), "app")
createApplication(t, pkgDir, false, false)
cli, stdout, stderr := newTestCLI(t, "CI=true", "NO_COLOR=true")
httpClient := &mock.HTTPClient{}
httpClient.NextResponseString(200, `ok`)
cli.httpClient = httpClient
app := vespa.ApplicationID{Tenant: "t1", Application: "a1", Instance: "i1"}
assert.Nil(t, cli.Run("config", "set", "application", app.String()))
assert.Nil(t, cli.Run("config", "set", "target", "cloud"))
assert.Nil(t, cli.Run("auth", "api-key"))
assert.Nil(t, cli.Run("auth", "cert", "--no-add"))
stderr.Reset()
require.NotNil(t, cli.Run("deploy", pkgDir))
certError := `Error: deployment to Vespa Cloud requires certificate in application package
Hint: See https://cloud.vespa.ai/en/security/guide
Hint: Pass --add-cert to use the certificate of the current application
`
assert.Equal(t, certError, stderr.String())
require.Nil(t, cli.Run("deploy", "--add-cert", "--wait=0", pkgDir))
assert.Contains(t, stdout.String(), "Success: Triggered deployment")
// Answer interactive certificate copy prompt
stdout.Reset()
stderr.Reset()
cli.isTerminal = func() bool { return true }
pkgDir2 := filepath.Join(t.TempDir(), "app")
createApplication(t, pkgDir2, false, false)
var buf bytes.Buffer
buf.WriteString("wat\nthe\nfck\nn\n")
cli.Stdin = &buf
require.NotNil(t, cli.Run("deploy", "--add-cert=false", "--wait=0", pkgDir2))
warning := "Warning: Application package does not contain security/clients.pem, which is required for deployments to Vespa Cloud\n"
assert.Equal(t, warning+strings.Repeat("Error: please answer 'y' or 'n'\n", 3)+certError, stderr.String())
buf.WriteString("y\n")
require.Nil(t, cli.Run("deploy", "--add-cert=false", "--wait=0", pkgDir2))
assert.Contains(t, stdout.String(), "Success: Triggered deployment")
}
func TestDeployWait(t *testing.T) {
cli, stdout, _ := newTestCLI(t)
client := &mock.HTTPClient{}
cli.httpClient = client
cli.retryInterval = 0
pkg := "testdata/applications/withSource/src/main/application"
// Deploy service is initially unavailable
client.NextResponseError(io.EOF)
client.NextStatus(500)
client.NextStatus(500)
// ... then becomes healthy
client.NextStatus(200)
// Deployment succeeds
client.NextResponse(mock.HTTPResponse{
URI: "/application/v2/tenant/default/prepareandactivate",
Status: 200,
Body: []byte(`{"session-id": "1"}`),
})
mockServiceStatus(client, "foo") // Wait for deployment
mockServiceStatus(client, "foo") // Look up services
assert.Nil(t, cli.Run("deploy", "--wait=3", pkg))
assert.Equal(t,
"\nSuccess: Deployed "+pkg+" with session ID 1\n",
stdout.String())
}
func TestPrepareZip(t *testing.T) {
assertPrepare("testdata/applications/withTarget/target/application.zip",
[]string{"prepare", "testdata/applications/withTarget/target/application.zip"}, t)
}
func TestActivateZip(t *testing.T) {
assertActivate("testdata/applications/withTarget/target/application.zip",
[]string{"activate", "--wait=0", "testdata/applications/withTarget/target/application.zip"}, t)
}
func TestDeployZip(t *testing.T) {
assertDeploy("testdata/applications/withTarget/target/application.zip",
[]string{"deploy", "--wait=0", "testdata/applications/withTarget/target/application.zip"}, t)
}
func TestDeployZipWithURLTargetArgument(t *testing.T) {
applicationPackage := "testdata/applications/withTarget/target/application.zip"
arguments := []string{"deploy", "--wait=0", "testdata/applications/withTarget/target/application.zip", "-t", "http://target:19071"}
client := &mock.HTTPClient{}
cli, stdout, _ := newTestCLI(t)
cli.httpClient = client
assert.Nil(t, cli.Run(arguments...))
assert.Equal(t,
"\nSuccess: Deployed "+applicationPackage+" with session ID 0\n",
stdout.String())
assertDeployRequestMade("http://target:19071", client, t)
}
func TestDeployZipWithLocalTargetArgument(t *testing.T) {
assertDeploy("testdata/applications/withTarget/target/application.zip",
[]string{"deploy", "--wait=0", "testdata/applications/withTarget/target/application.zip", "-t", "local"}, t)
}
func TestDeploySourceDirectory(t *testing.T) {
assertDeploy("testdata/applications/withSource/src/main/application",
[]string{"deploy", "--wait=0", "testdata/applications/withSource/src/main/application"}, t)
}
func TestDeployApplicationDirectoryWithSource(t *testing.T) {
assertDeploy("testdata/applications/withSource/src/main/application",
[]string{"deploy", "--wait=0", "testdata/applications/withSource"}, t)
}
func TestDeployApplicationDirectoryWithPomAndTarget(t *testing.T) {
assertDeploy("testdata/applications/withTarget/target/application",
[]string{"deploy", "--wait=0", "testdata/applications/withTarget"}, t)
}
func TestDeployApplicationDirectoryWithPomAndEmptyTarget(t *testing.T) {
cli, _, stderr := newTestCLI(t)
assert.NotNil(t, cli.Run("deploy", "--wait=0", "testdata/applications/withEmptyTarget"))
assert.Equal(t,
"Error: found pom.xml, but testdata/applications/withEmptyTarget/target/application does not exist: run 'mvn package' first\n",
stderr.String())
}
func TestDeployApplicationPackageErrorWithUnexpectedNonJson(t *testing.T) {
assertApplicationPackageError(t, "deploy", 401,
"Raw text error",
"Raw text error")
}
func TestDeployApplicationPackageErrorWithUnexpectedJson(t *testing.T) {
assertApplicationPackageError(t, "deploy", 401,
`{
"some-unexpected-json": "Invalid XML, error in services.xml: element \"nosuch\" not allowed here"
}`,
`{"some-unexpected-json": "Invalid XML, error in services.xml: element \"nosuch\" not allowed here"}`)
}
func TestDeployApplicationPackageErrorWithExpectedFormat(t *testing.T) {
assertApplicationPackageError(t, "deploy", 400,
"Invalid XML, error in services.xml:\nelement \"nosuch\" not allowed here",
`{
"error-code": "INVALID_APPLICATION_PACKAGE",
"message": "Invalid XML, error in services.xml: element \"nosuch\" not allowed here"
}`)
}
func TestPrepareApplicationPackageErrorWithExpectedFormat(t *testing.T) {
assertApplicationPackageError(t, "prepare", 400,
"Invalid XML, error in services.xml:\nelement \"nosuch\" not allowed here",
`{
"error-code": "INVALID_APPLICATION_PACKAGE",
"message": "Invalid XML, error in services.xml: element \"nosuch\" not allowed here"
}`)
}
func TestDeployError(t *testing.T) {
assertDeployServerError(t, 501, "Deploy service error")
}
func assertDeploy(applicationPackage string, arguments []string, t *testing.T) {
t.Helper()
cli, stdout, _ := newTestCLI(t)
client := &mock.HTTPClient{}
cli.httpClient = client
assert.Nil(t, cli.Run(arguments...))
assert.Equal(t,
"\nSuccess: Deployed "+applicationPackage+" with session ID 0\n",
stdout.String())
assertDeployRequestMade("http://127.0.0.1:19071", client, t)
}
func assertPrepare(applicationPackage string, arguments []string, t *testing.T) {
t.Helper()
client := &mock.HTTPClient{}
client.NextResponseString(200, `{"session-id":"42"}`)
client.NextResponseString(200, `{"session-id":"42","message":"Session 42 for tenant 'default' prepared.","log":[{"level":"WARNING","message":"Warning message 1","time": 1430134091319}]}`)
cli, stdout, _ := newTestCLI(t)
cli.httpClient = client
assert.Nil(t, cli.Run(arguments...))
assert.Equal(t,
"Success: Prepared "+applicationPackage+" with session 42\n",
stdout.String())
assertPackageUpload(0, "http://127.0.0.1:19071/application/v2/tenant/default/session", client, t)
sessionURL := "http://127.0.0.1:19071/application/v2/tenant/default/session/42/prepared"
assert.Equal(t, sessionURL, client.Requests[1].URL.String())
assert.Equal(t, "PUT", client.Requests[1].Method)
}
func assertActivate(applicationPackage string, arguments []string, t *testing.T) {
t.Helper()
client := &mock.HTTPClient{}
cli, stdout, _ := newTestCLI(t)
cli.httpClient = client
if err := cli.config.writeSessionID(vespa.DefaultApplication, 42); err != nil {
t.Fatal(err)
}
assert.Nil(t, cli.Run(arguments...))
assert.Equal(t,
"Success: Activated application with session 42\n",
stdout.String())
url := "http://127.0.0.1:19071/application/v2/tenant/default/session/42/active"
assert.Equal(t, url, client.LastRequest.URL.String())
assert.Equal(t, "PUT", client.LastRequest.Method)
}
func assertPackageUpload(requestNumber int, url string, client *mock.HTTPClient, t *testing.T) {
t.Helper()
req := client.LastRequest
if requestNumber >= 0 {
req = client.Requests[requestNumber]
}
assert.Equal(t, url, req.URL.String())
assert.Equal(t, "application/zip", req.Header.Get("Content-Type"))
assert.Equal(t, "POST", req.Method)
var body = req.Body
assert.NotNil(t, body)
buf := make([]byte, 7) // Just check the first few bytes
body.Read(buf)
assert.Equal(t, "PK\x03\x04\x14\x00\b", string(buf))
}
func assertDeployRequestMade(target string, client *mock.HTTPClient, t *testing.T) {
t.Helper()
assertPackageUpload(-1, target+"/application/v2/tenant/default/prepareandactivate", client, t)
}
func assertApplicationPackageError(t *testing.T, cmd string, status int, expectedMessage string, returnBody string) {
t.Helper()
client := &mock.HTTPClient{}
client.NextResponseString(status, returnBody)
cli, _, stderr := newTestCLI(t)
cli.httpClient = client
args := []string{}
args = append(args, cmd)
switch cmd {
case "activate", "deploy":
args = append(args, "--wait=0")
}
args = append(args, "testdata/applications/withTarget/target/application.zip")
assert.NotNil(t, cli.Run(args...))
assert.Equal(t,
"Error: invalid application package (Status "+strconv.Itoa(status)+")\n"+expectedMessage+"\n",
stderr.String())
}
func assertDeployServerError(t *testing.T, status int, errorMessage string) {
t.Helper()
client := &mock.HTTPClient{}
client.NextResponseString(status, errorMessage)
cli, _, stderr := newTestCLI(t)
cli.httpClient = client
assert.NotNil(t, cli.Run("deploy", "--wait=0", "testdata/applications/withTarget/target/application.zip"))
assert.Equal(t,
"Error: error from deploy api at 127.0.0.1:19071 (Status "+strconv.Itoa(status)+"):\n"+errorMessage+"\n",
stderr.String())
}
|
