1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
|
// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.clustercontroller.core;
import static com.yahoo.vespa.clustercontroller.core.matchers.EventForNode.eventForNode;
import static com.yahoo.vespa.clustercontroller.core.matchers.NodeEventForBucketSpace.nodeEventForBucketSpace;
import static com.yahoo.vespa.clustercontroller.core.matchers.NodeEventForBucketSpace.nodeEventForBaseline;
import static com.yahoo.vespa.clustercontroller.core.matchers.NodeEventWithDescription.nodeEventWithDescription;
import static com.yahoo.vespa.clustercontroller.core.matchers.ClusterEventWithDescription.clusterEventWithDescription;
import static com.yahoo.vespa.clustercontroller.core.matchers.EventTypeIs.eventTypeIs;
import static com.yahoo.vespa.clustercontroller.core.matchers.EventTimeIs.eventTimeIs;
import static org.hamcrest.CoreMatchers.allOf;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.junit.Assert.assertThat;
import static org.hamcrest.CoreMatchers.hasItem;
import static com.yahoo.vespa.clustercontroller.core.ClusterFixture.storageNode;
import static com.yahoo.vespa.clustercontroller.core.ClusterFixture.distributorNode;
import org.junit.Test;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
public class EventDiffCalculatorTest {
private static class EventFixture {
final ClusterFixture clusterFixture;
AnnotatedClusterState.Builder baselineBefore = new AnnotatedClusterState.Builder();
AnnotatedClusterState.Builder baselineAfter = new AnnotatedClusterState.Builder();
Map<String, AnnotatedClusterState.Builder> derivedBefore = new HashMap<>();
Map<String, AnnotatedClusterState.Builder> derivedAfter = new HashMap<>();
long currentTimeMs = 0;
EventFixture(int nodeCount) {
this.clusterFixture = ClusterFixture.forFlatCluster(nodeCount);
}
EventFixture clusterStateBefore(String stateStr) {
baselineBefore.clusterState(stateStr);
return this;
}
EventFixture clusterStateAfter(String stateStr) {
baselineAfter.clusterState(stateStr);
return this;
}
EventFixture storageNodeReasonBefore(int nodeIndex, NodeStateReason reason) {
baselineBefore.storageNodeReason(nodeIndex, reason);
return this;
}
EventFixture storageNodeReasonAfter(int nodeIndex, NodeStateReason reason) {
baselineAfter.storageNodeReason(nodeIndex, reason);
return this;
}
EventFixture clusterReasonBefore(ClusterStateReason reason) {
baselineBefore.clusterReason(reason);
return this;
}
EventFixture clusterReasonAfter(ClusterStateReason reason) {
baselineAfter.clusterReason(reason);
return this;
}
EventFixture currentTimeMs(long timeMs) {
this.currentTimeMs = timeMs;
return this;
}
EventFixture derivedClusterStateBefore(String bucketSpace, String stateStr) {
getBuilder(derivedBefore, bucketSpace).clusterState(stateStr);
return this;
}
EventFixture derivedClusterStateAfter(String bucketSpace, String stateStr) {
getBuilder(derivedAfter, bucketSpace).clusterState(stateStr);
return this;
}
EventFixture derivedStorageNodeReasonBefore(String bucketSpace, int nodeIndex, NodeStateReason reason) {
getBuilder(derivedBefore, bucketSpace).storageNodeReason(nodeIndex, reason);
return this;
}
EventFixture derivedStorageNodeReasonAfter(String bucketSpace, int nodeIndex, NodeStateReason reason) {
getBuilder(derivedAfter, bucketSpace).storageNodeReason(nodeIndex, reason);
return this;
}
private static AnnotatedClusterState.Builder getBuilder(Map<String, AnnotatedClusterState.Builder> derivedStates, String bucketSpace) {
return derivedStates.computeIfAbsent(bucketSpace, key -> new AnnotatedClusterState.Builder());
}
List<Event> computeEventDiff() {
return EventDiffCalculator.computeEventDiff(
EventDiffCalculator.params()
.cluster(clusterFixture.cluster())
.fromState(ClusterStateBundle.of(baselineBefore.build(), toDerivedStates(derivedBefore)))
.toState(ClusterStateBundle.of(baselineAfter.build(), toDerivedStates(derivedAfter)))
.currentTimeMs(currentTimeMs));
}
private static Map<String, AnnotatedClusterState> toDerivedStates(Map<String, AnnotatedClusterState.Builder> derivedBuilders) {
return derivedBuilders.entrySet().stream()
.collect(Collectors.toMap(entry -> entry.getKey(), entry -> entry.getValue().build()));
}
static EventFixture createForNodes(int nodeCount) {
return new EventFixture(nodeCount);
}
}
@Test
public void single_storage_node_state_transition_emits_altered_node_state_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("distributor:3 storage:3 .0.s:d");
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(0)),
eventTypeIs(NodeEvent.Type.CURRENT),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'D'"))));
}
@Test
public void single_distributor_node_state_transition_emits_altered_node_state_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("distributor:3 .1.s:d storage:3");
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(allOf(
eventForNode(distributorNode(1)),
eventTypeIs(NodeEvent.Type.CURRENT),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'D'"))));
}
@Test
public void node_state_change_event_is_tagged_with_given_time() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("distributor:3 storage:3 .0.s:d")
.currentTimeMs(123456);
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(eventTimeIs(123456)));
}
@Test
public void multiple_node_state_transitions_emit_multiple_node_state_events() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3 .1.s:d")
.clusterStateAfter("distributor:3 .2.s:d storage:3 .0.s:r");
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(3));
assertThat(events, hasItem(allOf(
eventForNode(distributorNode(2)),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'D'"))));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(0)),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'R'"))));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
nodeEventWithDescription("Altered node state in cluster state from 'D' to 'U'"))));
}
@Test
public void no_emitted_node_state_event_when_node_state_not_changed() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("distributor:3 storage:3");
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(0));
}
@Test
public void node_down_edge_with_group_down_reason_has_separate_event_emitted() {
// We sneakily use a flat cluster here but still use a 'group down' reason. Differ doesn't currently care.
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("distributor:3 storage:3 .1.s:d")
.storageNodeReasonAfter(1, NodeStateReason.GROUP_IS_DOWN);
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(2));
// Both the regular edge event and the group down event is emitted
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'D'"))));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
eventTypeIs(NodeEvent.Type.CURRENT),
nodeEventWithDescription("Group node availability is below configured threshold"))));
}
@Test
public void group_down_to_group_down_does_not_emit_new_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3 .1.s:d")
.clusterStateAfter("distributor:3 storage:3 .1.s:m")
.storageNodeReasonBefore(1, NodeStateReason.GROUP_IS_DOWN)
.storageNodeReasonAfter(1, NodeStateReason.GROUP_IS_DOWN);
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
// Should not get a group availability event since nothing has changed in this regard
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
nodeEventWithDescription("Altered node state in cluster state from 'D' to 'M'"))));
}
@Test
public void group_down_to_clear_reason_emits_group_up_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3 .2.s:d")
.clusterStateAfter("distributor:3 storage:3")
.storageNodeReasonBefore(2, NodeStateReason.GROUP_IS_DOWN); // But no after-reason.
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(2));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(2)),
nodeEventWithDescription("Altered node state in cluster state from 'D' to 'U'"))));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(2)),
eventTypeIs(NodeEvent.Type.CURRENT),
nodeEventWithDescription("Group node availability has been restored"))));
}
@Test
public void cluster_up_edge_emits_sufficient_node_availability_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("cluster:d distributor:3 storage:3")
.clusterStateAfter("distributor:3 storage:3");
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(
clusterEventWithDescription("Enough nodes available for system to become up")));
}
@Test
public void cluster_down_event_without_reason_annotation_emits_generic_down_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("cluster:d distributor:3 storage:3");
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(
clusterEventWithDescription("Cluster is down")));
}
@Test
public void cluster_event_is_tagged_with_given_time() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("cluster:d distributor:3 storage:3")
.currentTimeMs(56789);
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(eventTimeIs(56789)));
}
@Test
public void no_event_emitted_for_cluster_down_to_down_edge() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("cluster:d distributor:3 storage:3")
.clusterStateAfter("cluster:d distributor:3 storage:3");
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(0));
}
@Test
public void too_few_storage_nodes_cluster_down_reason_emits_corresponding_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("cluster:d distributor:3 storage:3")
.clusterReasonAfter(ClusterStateReason.TOO_FEW_STORAGE_NODES_AVAILABLE);
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
// TODO(?) these messages currently don't include the current configured limits
assertThat(events, hasItem(
clusterEventWithDescription("Too few storage nodes available in cluster. Setting cluster state down")));
}
@Test
public void too_few_distributor_nodes_cluster_down_reason_emits_corresponding_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("cluster:d distributor:3 storage:3")
.clusterReasonAfter(ClusterStateReason.TOO_FEW_DISTRIBUTOR_NODES_AVAILABLE);
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(
clusterEventWithDescription("Too few distributor nodes available in cluster. Setting cluster state down")));
}
@Test
public void too_low_storage_node_ratio_cluster_down_reason_emits_corresponding_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("cluster:d distributor:3 storage:3")
.clusterReasonAfter(ClusterStateReason.TOO_LOW_AVAILABLE_STORAGE_NODE_RATIO);
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(
clusterEventWithDescription("Too low ratio of available storage nodes. Setting cluster state down")));
}
@Test
public void too_low_distributor_node_ratio_cluster_down_reason_emits_corresponding_event() {
final EventFixture fixture = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.clusterStateAfter("cluster:d distributor:3 storage:3")
.clusterReasonAfter(ClusterStateReason.TOO_LOW_AVAILABLE_DISTRIBUTOR_NODE_RATIO);
final List<Event> events = fixture.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(
clusterEventWithDescription("Too low ratio of available distributor nodes. Setting cluster state down")));
}
@Test
public void may_have_merges_pending_up_edge_event_emitted_if_derived_bucket_space_state_differs_from_baseline() {
EventFixture f = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.derivedClusterStateBefore("default", "distributor:3 storage:3")
.clusterStateAfter("distributor:3 storage:3")
.derivedClusterStateAfter("default", "distributor:3 storage:3 .1.s:m")
.derivedStorageNodeReasonAfter("default", 1, NodeStateReason.MAY_HAVE_MERGES_PENDING);
List<Event> events = f.computeEventDiff();
assertThat(events.size(), equalTo(2));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
nodeEventForBucketSpace("default"),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'M'"))));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
nodeEventForBucketSpace("default"),
nodeEventWithDescription("Node may have merges pending"))));
}
@Test
public void may_have_merges_pending_down_edge_event_emitted_if_derived_bucket_space_state_differs_from_baseline() {
EventFixture f = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.derivedClusterStateBefore("default", "distributor:3 storage:3 .1.s:m")
.derivedStorageNodeReasonBefore("default", 1, NodeStateReason.MAY_HAVE_MERGES_PENDING)
.clusterStateAfter("distributor:3 storage:3")
.derivedClusterStateAfter("default", "distributor:3 storage:3");
List<Event> events = f.computeEventDiff();
assertThat(events.size(), equalTo(2));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
nodeEventForBucketSpace("default"),
nodeEventWithDescription("Altered node state in cluster state from 'M' to 'U'"))));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
nodeEventForBucketSpace("default"),
nodeEventWithDescription("Node no longer have merges pending"))));
}
@Test
public void both_baseline_and_derived_bucket_space_state_events_are_emitted() {
EventFixture f = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.derivedClusterStateBefore("default", "distributor:3 storage:3")
.clusterStateAfter("distributor:3 storage:3 .0.s:m")
.derivedClusterStateAfter("default", "distributor:3 storage:3 .1.s:m");
List<Event> events = f.computeEventDiff();
assertThat(events.size(), equalTo(2));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(0)),
nodeEventForBaseline(),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'M'"))));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(1)),
nodeEventForBucketSpace("default"),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'M'"))));
}
@Test
public void derived_bucket_space_state_events_are_not_emitted_if_similar_to_baseline() {
EventFixture f = EventFixture.createForNodes(3)
.clusterStateBefore("distributor:3 storage:3")
.derivedClusterStateBefore("default", "distributor:3 storage:3")
.derivedClusterStateBefore("global", "distributor:3 storage:3")
.clusterStateAfter("distributor:3 storage:3 .0.s:m")
.derivedClusterStateAfter("default", "distributor:3 storage:3 .0.s:m")
.derivedClusterStateAfter("global", "distributor:3 storage:3 .0.s:m");
List<Event> events = f.computeEventDiff();
assertThat(events.size(), equalTo(1));
assertThat(events, hasItem(allOf(
eventForNode(storageNode(0)),
nodeEventForBaseline(),
nodeEventWithDescription("Altered node state in cluster state from 'U' to 'M'"))));
}
}
|
