aboutsummaryrefslogtreecommitdiffstats
path: root/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/GroupAutoTakedownLiveConfigTest.java
blob: 477fed5e170a4f54ce3daefbc4e945088944341b (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.clustercontroller.core;

import com.yahoo.vdslib.state.NodeType;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;

import java.util.HashSet;

import static org.junit.jupiter.api.Assertions.assertFalse;

@ExtendWith(CleanupZookeeperLogsOnSuccess.class)
public class GroupAutoTakedownLiveConfigTest extends FleetControllerTest {

    private final Timer timer = new FakeTimer();

    private static FleetControllerOptions.Builder createOptions(DistributionBuilder.GroupBuilder groupBuilder, double minNodeRatio) {
        return defaultOptions()
                .setStorageDistribution(DistributionBuilder.forHierarchicCluster(groupBuilder))
                .setNodes(new HashSet<>(DistributionBuilder.buildConfiguredNodes(groupBuilder.totalNodeCount())))
                .setMinNodeRatioPerGroup(minNodeRatio)
                .setMaxTransitionTime(NodeType.DISTRIBUTOR, 0)
                .setMaxTransitionTime(NodeType.STORAGE, 0);
    }

    private void updateConfigLive(FleetControllerOptions newOptions) {
        fleetController().updateOptions(newOptions);
    }

    private void reconfigureWithMinNodeRatio(FleetControllerOptions options, double minNodeRatio) {
        FleetControllerOptions.Builder newOptions = FleetControllerOptions.Builder.copy(options);
        newOptions.setMinNodeRatioPerGroup(minNodeRatio);
        updateConfigLive(newOptions.build());
    }

    private void reconfigureWithDistribution(FleetControllerOptions options, DistributionBuilder.GroupBuilder groupBuilder) {
        FleetControllerOptions.Builder builder =
                FleetControllerOptions.Builder.copy(options)
                                              .setNodes(new HashSet<>(DistributionBuilder.buildConfiguredNodes(groupBuilder.totalNodeCount())))
                                              .setStorageDistribution(DistributionBuilder.forHierarchicCluster(groupBuilder));
        updateConfigLive(builder.build());
    }

    private FleetControllerOptions setUp3x3ClusterWithMinNodeRatio(double minNodeRatio) throws Exception {
        FleetControllerOptions.Builder options = createOptions(DistributionBuilder.withGroups(3).eachWithNodeCount(3), minNodeRatio);
        setUpFleetController(timer, options);
        setUpVdsNodes(timer, false, 9);
        waitForState("version:\\d+ distributor:9 storage:9");
        return options.build();
    }

    private void takeDownContentNode(int index) {
        // nodes list contains both distributors and storage nodes, with distributors
        // in even positions and storage nodes in odd positions.
        final int arrayIndex = index*2 + 1;
        assertFalse(nodes.get(arrayIndex).isDistributor());
        nodes.get(arrayIndex).disconnect();
    }

    @Test
    void bootstrap_min_ratio_option_is_propagated_to_group_availability_logic() throws Exception {
        setUp3x3ClusterWithMinNodeRatio(0.67);
        takeDownContentNode(0);
        waitForStateExcludingNodeSubset("version:\\d+ distributor:9 storage:9 .0.s:d .1.s:d .2.s:d", asIntSet(0), timer);
    }

    @Test
    void min_ratio_live_reconfig_immediately_takes_effect() throws Exception {
        // Initially, arbitrarily many nodes may be down in a group.
        var options = setUp3x3ClusterWithMinNodeRatio(0.0);
        takeDownContentNode(3);
        waitForStateExcludingNodeSubset("version:\\d+ distributor:9 storage:9 .3.s:d", asIntSet(3), timer);

        reconfigureWithMinNodeRatio(options, 0.67);
        waitForStateExcludingNodeSubset("version:\\d+ distributor:9 storage:9 .3.s:d .4.s:d .5.s:d", asIntSet(3), timer);

        reconfigureWithMinNodeRatio(options, 0.0);
        // Aaaand back up again!
        waitForStateExcludingNodeSubset("version:\\d+ distributor:9 storage:9 .3.s:d", asIntSet(3), timer);
    }

    @Test
    void live_distribution_config_changes_trigger_cluster_state_change() throws Exception {
        var options = setUp3x3ClusterWithMinNodeRatio(0.65);
        takeDownContentNode(6);

        // Not enough nodes down to trigger group take-down yet
        waitForStateExcludingNodeSubset("version:\\d+ distributor:9 storage:9 .6.s:d", asIntSet(6), timer);
        // Removing a node from the same group as node 6 will dip it under the configured threshold,
        // taking down the entire group. In this case we configure out node 8.
        reconfigureWithDistribution(options, DistributionBuilder.withGroupNodes(3, 3, 2));
        waitForStateExcludingNodeSubset("version:\\d+ distributor:8 storage:6", asIntSet(6, 8), timer);
    }
}