summaryrefslogtreecommitdiffstats
path: root/clustercontroller-core/src/test/java/com/yahoo/vespa/clustercontroller/core/StateChangeHandlerTest.java
blob: 2bea95ab8c5e20f59f4daf5303fdbd818b80ce96 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.clustercontroller.core;

import com.yahoo.vdslib.distribution.ConfiguredNode;
import com.yahoo.vdslib.distribution.Distribution;
import com.yahoo.vdslib.state.ClusterState;
import com.yahoo.vdslib.state.Node;
import com.yahoo.vdslib.state.NodeState;
import com.yahoo.vdslib.state.NodeType;
import com.yahoo.vdslib.state.State;
import com.yahoo.vespa.clustercontroller.core.hostinfo.HostInfo;
import com.yahoo.vespa.clustercontroller.core.listeners.NodeListener;
import com.yahoo.vespa.clustercontroller.core.mocks.TestEventLog;
import com.yahoo.vespa.clustercontroller.core.testutils.LogFormatter;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;


import java.util.LinkedList;
import java.util.Set;
import java.util.TreeSet;
import java.util.logging.Logger;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class StateChangeHandlerTest {

    private static final Logger log = Logger.getLogger(StateChangeHandlerTest.class.getName());
    private static class Config {
        int nodeCount = 3;
        int stableStateTime = 1000 * 60000;
        int maxSlobrokDisconnectPeriod = 60000;
        int maxPrematureCrashes = 3;
    }

    private static class TestNodeListener implements NodeListener {

        LinkedList<String> events = new LinkedList<>();

        @Override
        public void handleNewNodeState(NodeInfo node, NodeState newState) {
            events.add(node + " - " + newState);
        }

        @Override
        public void handleNewWantedNodeState(NodeInfo node, NodeState newState) {
            events.add(node + " - " + newState);
        }

        @Override
        public void handleRemovedNode(Node node) {
            events.add("removed: " + node);
        }

        @Override
        public void handleUpdatedHostInfo(NodeInfo node, HostInfo newHostInfo) {
            events.add(node + " - " + newHostInfo);
        }

        public String toString() {
            StringBuilder sb = new StringBuilder();
            sb.append("NodeChanges(");
            for (String change : events) sb.append('\n').append(change);
            sb.append(")");
            return sb.toString();
        }
    }

    private final FakeTimer clock = new FakeTimer();
    private final TestEventLog eventLog = new TestEventLog();
    private final Set<ConfiguredNode> configuredNodes = new TreeSet<>();
    private Config config;
    private ContentCluster cluster;
    private StateChangeHandler nodeStateChangeHandler;
    private TestNodeListener nodeStateUpdateListener;
    private final ClusterStateGenerator.Params params = new ClusterStateGenerator.Params();

    @BeforeEach
    public void setUp() {
        LogFormatter.initializeLogging();
    }

    private void initialize(Config config) {
        Distribution distribution = new Distribution(Distribution.getDefaultDistributionConfig(2, 100));
        this.config = config;
        for (int i=0; i<config.nodeCount; ++i) configuredNodes.add(new ConfiguredNode(i, false));
        cluster = new ContentCluster("testcluster", configuredNodes, distribution);
        var context = new FleetControllerContextImpl(new FleetControllerId(cluster.getName(), 0));
        nodeStateChangeHandler = new StateChangeHandler(context, clock, eventLog);
        params.minStorageNodesUp(1).minDistributorNodesUp(1)
                .minRatioOfStorageNodesUp(0.0).minRatioOfDistributorNodesUp(0.0)
                .maxPrematureCrashes(config.maxPrematureCrashes)
                .transitionTimes(5000)
                .cluster(cluster);
        nodeStateUpdateListener = new TestNodeListener();
    }

    private ClusterState currentClusterState() {
        params.currentTimeInMilllis(clock.getCurrentTimeInMillis());
        return ClusterStateGenerator.generatedStateFrom(params).getClusterState();
    }

    private void startWithStableStateClusterWithNodesUp() {
        for (NodeType type : NodeType.getTypes()) {
            for (ConfiguredNode i : configuredNodes) {
                NodeInfo nodeInfo = cluster.clusterInfo().setRpcAddress(new Node(type, i.index()), null);
                nodeInfo.markRpcAddressLive();
                nodeStateChangeHandler.handleNewReportedNodeState(
                        currentClusterState(), nodeInfo, new NodeState(type, State.UP), null);
                nodeInfo.setReportedState(new NodeState(type, State.UP), clock.getCurrentTimeInMillis());
            }
        }
        for (NodeType type : NodeType.getTypes()) {
            for (ConfiguredNode i : configuredNodes) {
                Node n = new Node(type, i.index());
                assertEquals(State.UP, currentClusterState().getNodeState(n).getState());
            }
        }
        clock.advanceTime(config.stableStateTime);
    }

    private void markNodeOutOfSlobrok(Node node) {
        final ClusterState stateBefore = currentClusterState();
        log.info("Marking " + node + " out of slobrok");
        cluster.getNodeInfo(node).markRpcAddressOutdated(clock);
        nodeStateChangeHandler.handleMissingNode(stateBefore, cluster.getNodeInfo(node), nodeStateUpdateListener);
        assertTrue(eventLog.toString().contains("Node is no longer in slobrok"), eventLog.toString());
        eventLog.clear();
    }

    private void markNodeBackIntoSlobrok(Node node, State state) {
        final ClusterState stateBefore = currentClusterState();
        log.info("Marking " + node + " back in slobrok");
        cluster.getNodeInfo(node).markRpcAddressLive();
        nodeStateChangeHandler.handleReturnedRpcAddress(cluster.getNodeInfo(node));
        nodeStateChangeHandler.handleNewReportedNodeState(
                stateBefore, cluster.getNodeInfo(node),
                new NodeState(node.getType(), state), nodeStateUpdateListener);
        cluster.getNodeInfo(node).setReportedState(new NodeState(node.getType(), state), clock.getCurrentTimeInMillis());
    }

    private void verifyClusterStateChanged(Node node, State state) {
        log.info("Verifying cluster state has been updated for " + node + " to " + state);
        assertTrue(nodeStateChangeHandler.stateMayHaveChanged());
        assertEquals(state, currentClusterState().getNodeState(node).getState());
    }

    private void verifyNodeStateAfterTimerWatch(Node node, State state) {
        log.info("Verifying state of node after timer watch.");
        nodeStateChangeHandler.watchTimers(cluster, currentClusterState(), nodeStateUpdateListener);
        assertEquals(0, nodeStateUpdateListener.events.size());
        verifyClusterStateChanged(node, state);
    }

    private void verifyPrematureCrashCountCleared(Node node) {
        assertTrue(nodeStateChangeHandler.watchTimers(cluster, currentClusterState(), nodeStateUpdateListener));
        assertEquals(0, cluster.getNodeInfo(node).getPrematureCrashCount());
    }

    @Test
    void testUnstableNodeInSlobrok() {
        initialize(new Config());
        startWithStableStateClusterWithNodesUp();
        Node node = new Node(NodeType.STORAGE, 0);
        for (int j = 0; j < 3; ++j) {
            log.info("Iteration " + j);
            assertEquals(0, cluster.getNodeInfo(node).getPrematureCrashCount());
            assertEquals(State.UP, cluster.getNodeInfo(node).getWantedState().getState());
            assertEquals(State.UP, currentClusterState().getNodeState(node).getState());
            for (int k = 0; k < config.maxPrematureCrashes; ++k) {
                log.info("Premature iteration " + k);
                markNodeOutOfSlobrok(node);

                log.info("Passing max disconnect time period. Watching timers");
                clock.advanceTime(config.maxSlobrokDisconnectPeriod);
                verifyNodeStateAfterTimerWatch(node, State.MAINTENANCE);

                cluster.getNodeInfo(node).setReportedState(new NodeState(node.getType(), State.DOWN), clock.getCurrentTimeInMillis());

                assertEquals(k, cluster.getNodeInfo(node).getPrematureCrashCount());
                markNodeBackIntoSlobrok(node, State.UP);
                verifyClusterStateChanged(node, State.UP);
            }
            log.info("Passing steady state to get premature crash count flag cleared");
            clock.advanceTime(config.stableStateTime);
            verifyPrematureCrashCountCleared(node);
        }
    }

}