1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.clustercontroller.core.rpc;
import com.yahoo.jrt.ErrorCode;
import com.yahoo.jrt.Request;
import com.yahoo.jrt.RequestWaiter;
import com.yahoo.jrt.Supervisor;
import com.yahoo.jrt.Target;
import com.yahoo.vdslib.distribution.ConfiguredNode;
import com.yahoo.vdslib.state.Node;
import com.yahoo.vdslib.state.NodeState;
import com.yahoo.vdslib.state.NodeType;
import com.yahoo.vdslib.state.State;
import com.yahoo.vespa.clustercontroller.core.ActivateClusterStateVersionRequest;
import com.yahoo.vespa.clustercontroller.core.ClusterFixture;
import com.yahoo.vespa.clustercontroller.core.ClusterStateBundle;
import com.yahoo.vespa.clustercontroller.core.ClusterStateBundleUtil;
import com.yahoo.vespa.clustercontroller.core.Communicator;
import com.yahoo.vespa.clustercontroller.core.FakeTimer;
import com.yahoo.vespa.clustercontroller.core.FleetControllerOptions;
import com.yahoo.vespa.clustercontroller.core.NodeInfo;
import com.yahoo.vespa.clustercontroller.core.SetClusterStateRequest;
import com.yahoo.vespa.clustercontroller.core.Timer;
import org.junit.Test;
import org.mockito.Mockito;
import java.util.HashSet;
import java.util.Set;
import java.util.concurrent.atomic.AtomicReference;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.notNullValue;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.core.Is.is;
import static org.hamcrest.core.IsNot.not;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyDouble;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
public class RPCCommunicatorTest {
private static final int NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS = 10000;
private static final int NODE_STATE_REQUEST_TIMEOUT_INTERVAL_START_PERCENTAGE = 80;
private static final int NODE_STATE_REQUEST_TIMEOUT_INTERVAL_STOP_PERCENTAGE = 95;
private static final int INDEX = 0;
private static final int TEST_ITERATIONS = 500;
private static final int ROUNDTRIP_LATENCY_SECONDS = 2000;
@Test
public void testGenerateNodeStateRequestTimeoutMs() {
final RPCCommunicator communicator = new RPCCommunicator(
RPCCommunicator.createRealSupervisor(),
null /* Timer */,
INDEX,
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS,
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_START_PERCENTAGE,
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_STOP_PERCENTAGE,
0);
int max = -1;
int min = 100000;
final Set<Integer> uniqueTimeoutValues = new HashSet<>();
for (int x = 0; x < TEST_ITERATIONS; x++) {
int timeOutMs = communicator.generateNodeStateRequestTimeoutMs();
min = Math.min(min, timeOutMs);
max = Math.max(max, timeOutMs);
uniqueTimeoutValues.add(timeOutMs);
}
assertTrue(max <= NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS *
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_STOP_PERCENTAGE / 100.);
assertThat(min, is(not(max)));
assertTrue(min >= NODE_STATE_REQUEST_TIMEOUT_INTERVAL_START_PERCENTAGE *
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS / 100);
assertTrue(uniqueTimeoutValues.size()> TEST_ITERATIONS/2);
}
@Test
public void testGenerateNodeStateRequestTimeoutMsWithUpdates() {
final RPCCommunicator communicator = new RPCCommunicator(RPCCommunicator.createRealSupervisor(), null /* Timer */, INDEX, 1, 1, 100, 0);
FleetControllerOptions fleetControllerOptions = new FleetControllerOptions(null /*clustername*/, Set.of(new ConfiguredNode(0, false)));
fleetControllerOptions.nodeStateRequestTimeoutEarliestPercentage = 100;
fleetControllerOptions.nodeStateRequestTimeoutLatestPercentage = 100;
fleetControllerOptions.nodeStateRequestTimeoutMS = NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS;
communicator.propagateOptions(fleetControllerOptions);
int timeOutMs = communicator.generateNodeStateRequestTimeoutMs();
assertThat(timeOutMs, is(NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS));
}
@Test
public void testRoundtripLatency() {
final Timer timer = new FakeTimer();
final RPCCommunicator communicator = new RPCCommunicator(
RPCCommunicator.createRealSupervisor(),
timer,
INDEX,
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS,
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_STOP_PERCENTAGE,
100,
ROUNDTRIP_LATENCY_SECONDS);
final NodeInfo nodeInfo = mock(NodeInfo.class);
final Target target = mock(Target.class);
when(target.isValid()).thenReturn(true);
when(nodeInfo.getConnection()).thenReturn(target);
when(nodeInfo.getVersion()).thenReturn(3);
when(nodeInfo.getReportedState()).thenReturn(new NodeState(NodeType.DISTRIBUTOR, State.UP));
communicator.getNodeState(nodeInfo, null);
Mockito.verify(target).invokeAsync(
any(),
eq(ROUNDTRIP_LATENCY_SECONDS + NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS/1000.0),
any());
}
private static class Fixture<RequestType> {
final Supervisor mockSupervisor = mock(Supervisor.class);
final Target mockTarget = mock(Target.class);
final Timer timer = new FakeTimer();
final RPCCommunicator communicator;
final AtomicReference<Request> receivedRequest = new AtomicReference<>();
final AtomicReference<RequestWaiter> receivedWaiter = new AtomicReference<>();
@SuppressWarnings("unchecked") // Cannot mock with "compiler-obvious" type safety for generics
final Communicator.Waiter<RequestType> mockWaiter = mock(Communicator.Waiter.class);
Fixture() {
communicator = new RPCCommunicator(
mockSupervisor,
timer,
INDEX,
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_MAX_MS,
NODE_STATE_REQUEST_TIMEOUT_INTERVAL_STOP_PERCENTAGE,
100,
ROUNDTRIP_LATENCY_SECONDS);
when(mockSupervisor.connect(any())).thenReturn(mockTarget);
when(mockTarget.isValid()).thenReturn(true);
doAnswer((invocation) -> {
receivedRequest.set((Request) invocation.getArguments()[0]);
receivedWaiter.set((RequestWaiter) invocation.getArguments()[2]);
return null;
}).when(mockTarget).invokeAsync(any(), anyDouble(), any());
}
}
@Test
public void setSystemState_v3_sends_distribution_states_rpc() {
var f = new Fixture<SetClusterStateRequest>();
var cf = ClusterFixture.forFlatCluster(3).bringEntireClusterUp().assignDummyRpcAddresses();
var sentBundle = ClusterStateBundleUtil.makeBundle("distributor:3 storage:3");
f.communicator.setSystemState(sentBundle, cf.cluster().getNodeInfo(Node.ofStorage(1)), f.mockWaiter);
Request req = f.receivedRequest.get();
assertThat(req, notNullValue());
assertThat(req.methodName(), equalTo(RPCCommunicator.SET_DISTRIBUTION_STATES_RPC_METHOD_NAME));
assertTrue(req.parameters().satisfies("bix")); // <compression type>, <uncompressed size>, <payload>
ClusterStateBundle receivedBundle = RPCUtil.decodeStateBundleFromSetDistributionStatesRequest(req);
assertThat(receivedBundle, equalTo(sentBundle));
}
@Test
public void set_distribution_states_v3_rpc_auto_downgrades_to_v2_on_unknown_method_error() {
var f = new Fixture<SetClusterStateRequest>();
var cf = ClusterFixture.forFlatCluster(3).bringEntireClusterUp().assignDummyRpcAddresses();
var sentBundle = ClusterStateBundleUtil.makeBundle("version:123 distributor:3 storage:3");
f.communicator.setSystemState(sentBundle, cf.cluster().getNodeInfo(Node.ofStorage(1)), f.mockWaiter);
RequestWaiter waiter = f.receivedWaiter.get();
assertThat(waiter, notNullValue());
Request req = f.receivedRequest.get();
assertThat(req, notNullValue());
req.setError(ErrorCode.NO_SUCH_METHOD, "que?");
waiter.handleRequestDone(req);
// This would normally be done in processResponses(), but that code path is not invoked in this test.
cf.cluster().getNodeInfo(Node.ofStorage(1)).setClusterStateBundleVersionAcknowledged(123, false);
f.receivedRequest.set(null);
// Now when we try again, we should have been downgraded to the legacy setsystemstate2 RPC
f.communicator.setSystemState(sentBundle, cf.cluster().getNodeInfo(Node.ofStorage(1)), f.mockWaiter);
req = f.receivedRequest.get();
assertThat(req, notNullValue());
assertThat(req.methodName(), equalTo(RPCCommunicator.LEGACY_SET_SYSTEM_STATE2_RPC_METHOD_NAME));
}
@Test
public void activateClusterStateVersion_sends_version_activation_rpc() {
var f = new Fixture<ActivateClusterStateVersionRequest>();
var cf = ClusterFixture.forFlatCluster(3).bringEntireClusterUp().assignDummyRpcAddresses();
f.communicator.activateClusterStateVersion(12345, cf.cluster().getNodeInfo(Node.ofDistributor(1)), f.mockWaiter);
Request req = f.receivedRequest.get();
assertThat(req, notNullValue());
assertThat(req.methodName(), equalTo(RPCCommunicator.ACTIVATE_CLUSTER_STATE_VERSION_RPC_METHOD_NAME));
assertTrue(req.parameters().satisfies("i")); // <cluster state version>
assertThat(req.parameters().get(0).asInt32(), equalTo(12345));
}
}
|
