config-application-package/src/test/java/com/yahoo/config/application/ConfigDefinitionDirTest.java


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70

// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.config.application;

import com.yahoo.config.model.application.provider.Bundle;
import com.yahoo.io.IOUtils;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;

import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.jar.JarFile;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

/**
 * @author Ulf Lilleengen
 * @since 5.1
 */
public class ConfigDefinitionDirTest {
    private static final String bundleFileName = "com.yahoo.searcher1.jar";
    private static final File bundleFile = new File("src/test/resources/defdircomponent/" + bundleFileName);

    @Rule
    public TemporaryFolder temporaryFolder = new TemporaryFolder();

    @Test
    public void require_that_defs_are_added() throws IOException {
        File defDir = temporaryFolder.newFolder();
        ConfigDefinitionDir dir = new ConfigDefinitionDir(defDir);
        Bundle bundle = new Bundle(new JarFile(bundleFile), bundleFile);
        assertEquals(0, defDir.listFiles().length);
        dir.addConfigDefinitionsFromBundle(bundle, new ArrayList<>());
        assertEquals(1, defDir.listFiles().length);
    }


    @Test
    public void require_that_conflicting_defs_are_not_added() throws IOException {
        File defDir = temporaryFolder.newFolder();
        IOUtils.writeFile(new File(defDir, "foo.def"), "alreadyexists", false);
        ConfigDefinitionDir dir = new ConfigDefinitionDir(defDir);
        Bundle bundle = new Bundle(new JarFile(bundleFile), bundleFile);
        ArrayList<Bundle> bundlesAdded = new ArrayList<>();

        // Conflict with built-in config definition
        try {
            dir.addConfigDefinitionsFromBundle(bundle, bundlesAdded);
        } catch (IllegalArgumentException e) {
            assertTrue(e.getMessage().contains
                    ("The config definition with name 'bar.foo' contained in the bundle '" +
                            bundleFileName +
                            "' conflicts with a built-in config definition"));
        }
        bundlesAdded.add(bundle);

        // Conflict with another bundle
        Bundle bundle2 = new Bundle(new JarFile(bundleFile), bundleFile);
        try {
            dir.addConfigDefinitionsFromBundle(bundle2, bundlesAdded);
        } catch (IllegalArgumentException e) {
            assertEquals("The config definition with name 'bar.foo' contained in the bundle '" +
                         bundleFileName +
                         "' conflicts with the same config definition in the bundle 'com.yahoo.searcher1.jar'. Please choose a different name.",
                         e.getMessage());
        }
    }
}