1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
|
package com.yahoo.config.application.api;
import com.yahoo.config.provision.RegionName;
import com.yahoo.yolean.Exceptions;
import org.junit.Test;
import java.io.StringReader;
import java.time.Duration;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
/**
* @author bratseth
*/
public class DeploymentSpecWithBcpTest {
@Test
public void minimalProductionSpecWithExplicitBcp() {
StringReader r = new StringReader("""
<deployment version='1.0'>
<instance id='default'>
<prod>
<region>us-east1</region>
<region>us-west1</region>
</prod>
</instance>
<bcp>
<group>
<region>us-east1</region>
<region>us-west1</region>
</group>
</bcp>
</deployment>
""");
assertTwoRegions(DeploymentSpec.fromXml(r));
}
@Test
public void specWithoutInstanceWithBcp() {
StringReader r = new StringReader("""
<deployment version='1.0'>
<prod>
<region>us-east1</region>
<region>us-west1</region>
</prod>
<bcp>
<group>
<region>us-east1</region>
<region>us-west1</region>
</group>
</bcp>
</deployment>
""");
assertTwoRegions(DeploymentSpec.fromXml(r));
}
@Test
public void complexBcpSetup() {
StringReader r = new StringReader("""
<deployment version='1.0'>
<instance id='beta'>
<prod>
<region>us-east1</region>
<region>us-east2</region>
</prod>
<bcp>
<group deadline="60m">
<region>us-east1</region>
<region>us-east2</region>
</group>
</bcp>
</instance>
<instance id='main'>
<prod>
<region>us-east1</region>
<region>us-east2</region>
<region>us-central1</region>
<region>us-west1</region>
<region>us-west2</region>
<region>eu-east1</region>
<region>eu-west1</region>
</prod>
</instance>
<bcp>
<group>
<region>us-east1</region>
<region>us-east2</region>
<region fraction="0.3">us-central1</region>
</group>
<group>
<region>us-west1</region>
<region>us-west2</region>
<region fraction="0.7">us-central1</region>
</group>
<group deadline="30m">
<region>eu-east1</region>
<region>eu-west1</region>
</group>
</bcp>
</deployment>
""");
var spec = DeploymentSpec.fromXml(r);
var betaBcp = spec.requireInstance("beta").bcp().orElse(spec.bcp());
assertEquals(1, betaBcp.groups().size());
var betaGroup = betaBcp.groups().get(0);
assertEquals(2, betaGroup.members().size());
assertEquals(Duration.ofMinutes(60), betaGroup.deadline());
assertEquals(new Bcp.RegionMember(RegionName.from("us-east1"), 1.0), betaGroup.members().get(0));
assertEquals(new Bcp.RegionMember(RegionName.from("us-east2"), 1.0), betaGroup.members().get(1));
var mainBcp = spec.requireInstance("main").bcp().orElse(spec.bcp());
assertEquals(7, mainBcp.regions().size());
assertEquals(3, mainBcp.groups().size());
var usEast = mainBcp.groups().get(0);
assertEquals(3, usEast.members().size());
assertEquals(Duration.ofMinutes(0), usEast.deadline());
assertEquals(new Bcp.RegionMember(RegionName.from("us-east1"), 1.0), usEast.members().get(0));
assertEquals(new Bcp.RegionMember(RegionName.from("us-east2"), 1.0), usEast.members().get(1));
assertEquals(new Bcp.RegionMember(RegionName.from("us-central1"), 0.3), usEast.members().get(2));
var usWest = mainBcp.groups().get(1);
assertEquals(3, usWest.members().size());
assertEquals(Duration.ofMinutes(0), usWest.deadline());
assertEquals(new Bcp.RegionMember(RegionName.from("us-west1"), 1.0), usWest.members().get(0));
assertEquals(new Bcp.RegionMember(RegionName.from("us-west2"), 1.0), usWest.members().get(1));
assertEquals(new Bcp.RegionMember(RegionName.from("us-central1"), 0.7), usWest.members().get(2));
var eu = mainBcp.groups().get(2);
assertEquals(2, eu.members().size());
assertEquals(Duration.ofMinutes(30), eu.deadline());
assertEquals(new Bcp.RegionMember(RegionName.from("eu-east1"), 1.0), eu.members().get(0));
assertEquals(new Bcp.RegionMember(RegionName.from("eu-west1"), 1.0), eu.members().get(1));
}
@Test
public void regionMembershipMatchValidation1() {
try {
StringReader r = new StringReader("""
<deployment version='1.0'>
<prod>
<region>us-east1</region>
<region>us-west1</region>
</prod>
<bcp>
<group>
<region>us-west1</region>
</group>
</bcp>
</deployment>
""");
DeploymentSpec.fromXml(r);
fail();
}
catch (IllegalArgumentException e) {
assertEquals("BCP and deployment mismatch in instance 'default': " +
"A <bcp> element must place all deployed production regions in at least one group, " +
"and declare no extra regions. " +
"Deployed regions: [us-east1, us-west1]. BCP regions: [us-west1]",
Exceptions.toMessageString(e));
}
}
@Test
public void regionMembershipMatchValidation2() {
try {
StringReader r = new StringReader("""
<deployment version='1.0'>
<prod>
<region>us-west1</region>
</prod>
<bcp>
<group>
<region>us-east1</region>
<region>us-west1</region>
</group>
</bcp>
</deployment>
""");
DeploymentSpec.fromXml(r);
fail();
}
catch (IllegalArgumentException e) {
assertEquals("BCP and deployment mismatch in instance 'default': " +
"A <bcp> element must place all deployed production regions in at least one group, " +
"and declare no extra regions. " +
"Deployed regions: [us-west1]. BCP regions: [us-east1, us-west1]",
Exceptions.toMessageString(e));
}
}
@Test
public void deadlineValidation() {
try {
StringReader r = new StringReader("""
<deployment version='1.0'>
<prod>
<region>us-east1</region>
<region>us-west1</region>
</prod>
<bcp>
<group deadline="fast">
<region>us-east1</region>
<region>us-west1</region>
</group>
</bcp>
</deployment>
""");
DeploymentSpec.fromXml(r);
fail();
}
catch (IllegalArgumentException e) {
assertEquals("Illegal deadline 'fast': Must end by 'm'", Exceptions.toMessageString(e));
}
}
@Test
public void fractionalMembershipValidation() {
try {
StringReader r = new StringReader("""
<deployment version='1.0'>
<prod>
<region>us-east1</region>
<region>us-west1</region>
</prod>
<bcp>
<group>
<region fraction="0.9">us-east1</region>
<region>us-west1</region>
</group>
</bcp>
</deployment>
""");
DeploymentSpec.fromXml(r);
fail();
}
catch (IllegalArgumentException e) {
assertEquals("Illegal BCP spec: All regions must have total membership fractions summing to 1.0, but us-east1 sums to 0.9",
Exceptions.toMessageString(e));
}
}
private void assertTwoRegions(DeploymentSpec spec) {
var bcp = spec.requireInstance("default").bcp().orElse(spec.bcp());
assertEquals(1, bcp.groups().size());
var group = bcp.groups().get(0);
assertEquals(2, group.members().size());
assertEquals(Duration.ZERO, group.deadline());
assertEquals(new Bcp.RegionMember(RegionName.from("us-east1"), 1.0), group.members().get(0));
assertEquals(new Bcp.RegionMember(RegionName.from("us-west1"), 1.0), group.members().get(1));
}
}
|
