1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.config.application.api;
import com.yahoo.test.ManualClock;
import org.junit.Assert;
import org.junit.Test;
import java.io.StringReader;
import java.time.Instant;
import static org.junit.Assert.assertEquals;
/**
* @author bratseth
*/
public class ValidationOverrideTest {
@Test
public void testValidationOverridesInIsolation() {
String validationOverrides =
"<validation-overrides>" +
" <allow until='2000-01-01'>indexing-change</allow>" +
" <allow until='2000-01-03' comment='any text'>indexing-mode-change</allow>" +
"</validation-overrides>";
{
ValidationOverrides overrides = ValidationOverrides.fromXml(new StringReader(validationOverrides));
Instant now = ManualClock.at("2000-01-01T23:59:00");
assertOverridden("indexing-change", overrides, now);
assertOverridden("indexing-mode-change", overrides, now);
assertNotOverridden("field-type-change", overrides, now);
assertEquals(validationOverrides, overrides.xmlForm());
}
{
ValidationOverrides overrides = ValidationOverrides.fromXml(new StringReader(validationOverrides));
Instant now = ManualClock.at("2000-01-02T00:00:00");
assertNotOverridden("indexing-change", overrides, now);
assertOverridden("indexing-mode-change", overrides, now);
assertNotOverridden("field-type-change", overrides, now);
}
{
ValidationOverrides overrides = ValidationOverrides.fromXml(new StringReader(validationOverrides));
Instant now = ManualClock.at("2000-01-04T00:00:00");
assertNotOverridden("indexing-change", overrides, now);
assertNotOverridden("indexing-mode-change", overrides, now);
assertNotOverridden("field-type-change", overrides, now);
}
}
@Test
public void testInvalidOverridePeriod() {
String validationOverrides =
"<validation-overrides>" +
" <allow until='2000-02-02'>indexing-change</allow>" +
"</validation-overrides>";
try {
ValidationOverrides overrides = ValidationOverrides.fromXml(new StringReader(validationOverrides));
Instant now = ManualClock.at("2000-01-01T23:59:00");
overrides.allows("indexing-change", now);
overrides.validate(now);
Assert.fail("Expected validation interval override validation validation failure");
}
catch (IllegalArgumentException e) {
Assert.assertEquals("validation-overrides is invalid: allow 'indexing-change' until 2000-02-03T00:00:00Z is too far in the future: Max 30 days is allowed",
e.getMessage());
}
}
@Test
public void testInvalidDate() {
String validationOverrides =
"<validation-overrides>" +
" <allow until='2000-02-31'>indexing-change</allow>" +
"</validation-overrides>";
try {
ValidationOverrides overrides = ValidationOverrides.fromXml(new StringReader(validationOverrides));
Instant now = ManualClock.at("2000-01-01T23:59:00");
overrides.allows("indexing-change", now);
overrides.validate(now);
Assert.fail("Expected validation interval override validation validation failure");
}
catch (IllegalArgumentException e) {
Assert.assertEquals("java.time.format.DateTimeParseException: Text '2000-02-31' could not be parsed: Invalid date 'FEBRUARY 31'",
e.getMessage());
}
}
@Test
public void testEmpty() {
ValidationOverrides empty = ValidationOverrides.empty;
ValidationOverrides emptyReserialized = ValidationOverrides.fromXml(empty.xmlForm());
assertEquals(empty.xmlForm(), emptyReserialized.xmlForm());
}
private void assertOverridden(String validationId, ValidationOverrides overrides, Instant now) {
overrides.invalid(ValidationId.from(validationId).get(), "message", now); // should not throw exception
}
private void assertNotOverridden(String validationId, ValidationOverrides overrides, Instant now) {
try {
overrides.invalid(ValidationId.from(validationId).get(), "message", now);
Assert.fail("Expected '" + validationId + "' to not be overridden");
}
catch (ValidationOverrides.ValidationException expected) {
}
}
@Test
public void testSchemaRemovalAliasForContentTypeRemoval() {
String validationOverridesContentType =
"<validation-overrides>" +
" <allow until='2000-02-02'>content-type-removal</allow>" +
"</validation-overrides>";
ValidationOverrides overrideContentTypeRemoval = ValidationOverrides
.fromXml(new StringReader(validationOverridesContentType));
String validationOverridesSchema =
"<validation-overrides>" +
" <allow until='2000-02-02'>schema-removal</allow>" +
"</validation-overrides>";
ValidationOverrides overrideSchemaRemoval = ValidationOverrides
.fromXml(new StringReader(validationOverridesSchema));
Instant now = ManualClock.at("2000-01-01T23:59:00");
assertOverridden("content-type-removal", overrideContentTypeRemoval, now);
assertOverridden("schema-removal", overrideSchemaRemoval, now);
}
}
|
