config-model/src/main/java/com/yahoo/vespa/model/application/validation/CloudDataPlaneFilterValidator.java


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70

package com.yahoo.vespa.model.application.validation;

import com.yahoo.config.application.api.ApplicationPackage;
import com.yahoo.config.model.deploy.DeployState;
import com.yahoo.io.IOUtils;
import com.yahoo.io.reader.NamedReader;
import com.yahoo.path.Path;
import com.yahoo.security.X509CertificateUtils;
import com.yahoo.vespa.model.VespaModel;

import java.io.IOException;
import java.security.cert.X509Certificate;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.logging.Logger;
import java.util.stream.Collectors;

public class CloudDataPlaneFilterValidator extends Validator {

    private static final Logger log = Logger.getLogger(CloudDataPlaneFilterValidator.class.getName());

    @Override
    public void validate(VespaModel model, DeployState deployState) {
        if (!deployState.isHosted()) return;
        if (!deployState.zone().system().isPublic()) return;

        validateUniqueCertificates(deployState);
    }

    private void validateUniqueCertificates(DeployState deployState) {
        List<NamedReader> certFiles = deployState.getApplicationPackage().getFiles(ApplicationPackage.SECURITY_DIR, ".pem");

        Map<String, List<X509Certificate>> configuredCertificates = certFiles.stream()
                .collect(Collectors.toMap(NamedReader::getName, CloudDataPlaneFilterValidator::readCertificates));

        Set<X509Certificate> duplicates = new HashSet<>();
        Set<X509Certificate> globalUniqueCerts = new HashSet<>();
        for (Map.Entry<String, List<X509Certificate>> certificateFile : configuredCertificates.entrySet()) {
            List<X509Certificate> duplicatesInFile = certificateFile.getValue().stream()
                    .filter(i -> !globalUniqueCerts.add(i))
                    .toList();
            duplicates.addAll(duplicatesInFile);
        }
        if (!duplicates.isEmpty()) {
            List<String> filesWithDuplicates = configuredCertificates.entrySet().stream()
                    .filter(entry -> entry.getValue().stream().anyMatch(duplicates::contains))
                    .map(Map.Entry::getKey)
                    .map(Path::fromString)
                    .map(Path::getName)
                    .map(p -> ApplicationPackage.SECURITY_DIR.append(p).getRelative())
                    .sorted()
                    .toList();
            throw new IllegalArgumentException("Duplicate certificate(s) detected in files: %s. Certificate subject of duplicates: %s"
                    .formatted(filesWithDuplicates.toString(),
                               duplicates.stream().map(cert -> cert.getSubjectX500Principal().getName()).toList().toString()));
        }
    }

    private static List<X509Certificate> readCertificates(NamedReader reader) {
        try {
            return X509CertificateUtils.certificateListFromPem(IOUtils.readAll(reader));
        } catch (IOException e) {
            log.warning("Exception reading certificate list from application package. File: %s, exception message: %s"
                                .formatted(reader.getName(), e.getMessage()));
            throw new RuntimeException("Error reading certificates from application package", e);
        }
    }
}