1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
|
// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.application.validation;
import com.yahoo.config.application.api.ValidationId;
import com.yahoo.config.application.api.ValidationOverrides;
import com.yahoo.config.application.api.ValidationOverrides.ValidationException;
import com.yahoo.config.model.api.ConfigChangeAction;
import com.yahoo.config.model.api.Model;
import com.yahoo.config.model.api.ValidationParameters;
import com.yahoo.config.model.deploy.DeployState;
import com.yahoo.config.provision.ClusterSpec;
import com.yahoo.vespa.model.VespaModel;
import com.yahoo.vespa.model.application.validation.change.CertificateRemovalChangeValidator;
import com.yahoo.vespa.model.application.validation.change.ChangeValidator;
import com.yahoo.vespa.model.application.validation.change.ConfigValueChangeValidator;
import com.yahoo.vespa.model.application.validation.change.ContainerRestartValidator;
import com.yahoo.vespa.model.application.validation.change.ContentClusterRemovalValidator;
import com.yahoo.vespa.model.application.validation.change.ContentTypeRemovalValidator;
import com.yahoo.vespa.model.application.validation.change.GlobalDocumentChangeValidator;
import com.yahoo.vespa.model.application.validation.change.IndexedSearchClusterChangeValidator;
import com.yahoo.vespa.model.application.validation.change.IndexingModeChangeValidator;
import com.yahoo.vespa.model.application.validation.change.NodeResourceChangeValidator;
import com.yahoo.vespa.model.application.validation.change.RedundancyIncreaseValidator;
import com.yahoo.vespa.model.application.validation.change.ResourcesReductionValidator;
import com.yahoo.vespa.model.application.validation.change.RestartOnDeployForOnnxModelChangesValidator;
import com.yahoo.vespa.model.application.validation.change.StartupCommandChangeValidator;
import com.yahoo.vespa.model.application.validation.change.StreamingSearchClusterChangeValidator;
import com.yahoo.vespa.model.application.validation.first.RedundancyValidator;
import com.yahoo.yolean.Exceptions;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
import java.util.logging.Level;
import java.util.stream.Collectors;
import static java.util.stream.Collectors.groupingBy;
import static java.util.stream.Collectors.mapping;
import static java.util.stream.Collectors.toCollection;
/**
* Executor of validators. This defines the right order of validator execution.
*
* @author hmusum
*/
public class Validation {
private final List<Validator> additionalValidators;
public Validation() { this(List.of()); }
/** Create instance taking additional validators (e.g., for cloud applications) */
public Validation(List<Validator> additionalValidators) { this.additionalValidators = additionalValidators; }
/**
* Validates the model supplied, and if there already exists a model for the application validates changes
* between the previous and current model
*
* @return a list of required changes needed to make this configuration live
* @throws ValidationOverrides.ValidationException if the change fails validation
*/
public List<ConfigChangeAction> validate(VespaModel model, ValidationParameters validationParameters, DeployState deployState) {
Execution execution = new Execution(model, deployState);
if (validationParameters.checkRouting()) {
execution.run(new RoutingValidator());
execution.run(new RoutingSelectorValidator());
}
execution.run(new SchemasDirValidator());
execution.run(new BundleValidator());
execution.run(new PublicApiBundleValidator());
execution.run(new SearchDataTypeValidator());
execution.run(new ComplexFieldsWithStructFieldAttributesValidator());
execution.run(new ComplexFieldsWithStructFieldIndexesValidator());
execution.run(new StreamingValidator());
execution.run(new RankSetupValidator(validationParameters.ignoreValidationErrors()));
execution.run(new NoPrefixForIndexes());
execution.run(new ContainerInCloudValidator());
execution.run(new DeploymentSpecValidator());
execution.run(new ValidationOverridesValidator());
execution.run(new ConstantValidator());
execution.run(new SecretStoreValidator());
execution.run(new EndpointCertificateSecretsValidator());
execution.run(new AccessControlFilterValidator());
execution.run(new QuotaValidator());
execution.run(new UriBindingsValidator());
execution.run(new CloudDataPlaneFilterValidator());
execution.run(new AccessControlFilterExcludeValidator());
execution.run(new CloudUserFilterValidator());
execution.run(new CloudHttpConnectorValidator());
execution.run(new UrlConfigValidator());
execution.run(new JvmHeapSizeValidator());
additionalValidators.forEach(execution::run);
List<ConfigChangeAction> result = Collections.emptyList();
if (deployState.getProperties().isFirstTimeDeployment()) {
validateFirstTimeDeployment(execution);
} else {
Optional<Model> currentActiveModel = deployState.getPreviousModel();
if (currentActiveModel.isPresent() && (currentActiveModel.get() instanceof VespaModel)) {
result = validateChanges((VespaModel) currentActiveModel.get(), execution);
deferConfigChangesForClustersToBeRestarted(result, model);
}
}
execution.throwIfFailed();
return result;
}
private static List<ConfigChangeAction> validateChanges(VespaModel currentModel, Execution execution) {
ChangeValidator[] validators = new ChangeValidator[] {
new IndexingModeChangeValidator(),
new GlobalDocumentChangeValidator(),
new IndexedSearchClusterChangeValidator(),
new StreamingSearchClusterChangeValidator(),
new ConfigValueChangeValidator(),
new StartupCommandChangeValidator(),
new ContentTypeRemovalValidator(),
new ContentClusterRemovalValidator(),
new ResourcesReductionValidator(),
new ResourcesReductionValidator(),
new ContainerRestartValidator(),
new NodeResourceChangeValidator(),
new RedundancyIncreaseValidator(),
new CertificateRemovalChangeValidator(),
new RedundancyValidator(),
new RestartOnDeployForOnnxModelChangesValidator(),
};
List<ConfigChangeAction> actions = Arrays.stream(validators)
.flatMap(v -> v.validate(currentModel, execution.model, execution.deployState).stream())
.toList();
execution.runChanges(actions);
return actions;
}
private static void validateFirstTimeDeployment(Execution execution) {
execution.run(new RedundancyValidator());
}
private static void deferConfigChangesForClustersToBeRestarted(List<ConfigChangeAction> actions, VespaModel model) {
Set<ClusterSpec.Id> clustersToBeRestarted = actions.stream()
.filter(action -> action.getType() == ConfigChangeAction.Type.RESTART)
.map(action -> action.clusterId())
.collect(Collectors.toCollection(() -> new LinkedHashSet<>()));
for (var clusterToRestart : clustersToBeRestarted) {
var containerCluster = model.getContainerClusters().get(clusterToRestart.value());
if (containerCluster != null)
containerCluster.setDeferChangesUntilRestart(true);
var contentCluster = model.getContentClusters().get(clusterToRestart.value());
if (contentCluster != null)
contentCluster.setDeferChangesUntilRestart(true);
}
}
private static class Execution {
private final Map<ValidationId, List<String>> failures = new LinkedHashMap<>();
private final VespaModel model;
private final DeployState deployState;
private Execution(VespaModel model, DeployState deployState) {
this.model = model;
this.deployState = deployState;
}
private void run(Validator validator) {
try {
validator.validate(model, deployState);
}
catch (ValidationException e) {
e.messagesById().forEach((id, messages) -> failures.computeIfAbsent(id, __ -> new ArrayList<>()).addAll(messages));
}
}
private void runChanges(List<ConfigChangeAction> actions) {
for (ConfigChangeAction action : actions) {
if (action.validationId().isPresent()) run(new Validator() { // Changes without a validation ID are always allowed.
@Override public void validate(VespaModel model, DeployState deployState) {
deployState.validationOverrides().invalid(action.validationId().get(), action.getMessage(), deployState.now());
}
});
}
}
private void throwIfFailed() {
try {
if (failures.size() == 1 && failures.values().iterator().next().size() == 1) // Retain single-form exception message when possible.
deployState.validationOverrides().invalid(failures.keySet().iterator().next(), failures.values().iterator().next().get(0), deployState.now());
else
deployState.validationOverrides().invalid(failures, deployState.now());
}
catch (ValidationException e) {
if (deployState.isHosted() && deployState.zone().environment().isManuallyDeployed())
deployState.getDeployLogger().logApplicationPackage(Level.WARNING,
"Auto-overriding validation which would be disallowed in production: " +
Exceptions.toMessageString(e));
else throw e;
}
}
}
}
|
