1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.schema;
import com.yahoo.schema.parser.ParseException;
import com.yahoo.vespa.documentmodel.DocumentSummary;
import com.yahoo.vespa.model.test.utils.DeployLoggerStub;
import com.yahoo.vespa.objects.FieldBase;
import org.junit.jupiter.api.Test;
import static com.yahoo.config.model.test.TestUtil.joinLines;
import java.util.Collection;
import java.util.List;
import java.util.Optional;
import java.util.logging.Level;
import java.util.stream.Collectors;
import static org.junit.jupiter.api.Assertions.*;
/**
* Tests summary validation
*
* @author bratseth
*/
public class SummaryTestCase {
@Test
void testMemorySummary() throws ParseException {
String sd = joinLines(
"schema memorysummary {",
" document memorysummary {",
" field inmemory type string {",
" indexing: attribute | summary",
" }",
" field ondisk type string {",
" indexing: index # no summary, so ignored",
" }",
" }",
"}");
DeployLoggerStub logger = new DeployLoggerStub();
ApplicationBuilder.createFromString(sd, logger);
assertTrue(logger.entries.isEmpty());
}
@Test
void testDiskSummary() throws ParseException {
String sd = joinLines(
"schema disksummary {",
" document-summary foobar {",
" summary foo1 type string { source: inmemory }",
" summary foo2 type string { source: ondisk }",
" }",
" document disksummary {",
" field inmemory type string {",
" indexing: attribute | summary",
" }",
" field ondisk type string {",
" indexing: index | summary",
" }",
" }",
"}");
DeployLoggerStub logger = new DeployLoggerStub();
ApplicationBuilder.createFromString(sd, logger);
assertEquals(1, logger.entries.size());
assertEquals(Level.WARNING, logger.entries.get(0).level);
assertEquals("In schema 'disksummary', document summary 'foobar': " +
"Fields [foo2] references non-attribute fields: " +
"Using this summary will cause disk accesses. " +
"Set 'from-disk' on this summary class to silence this warning.",
logger.entries.get(0).message);
}
@Test
void testDiskSummaryExplicit() throws ParseException {
String sd = joinLines(
"schema disksummary {",
" document disksummary {",
" field inmemory type string {",
" indexing: attribute | summary",
" }",
" field ondisk type string {",
" indexing: index | summary",
" }",
" }",
" document-summary foobar {",
" summary foo1 type string { source: inmemory }",
" summary foo2 type string { source: ondisk }",
" from-disk",
" }",
"}");
DeployLoggerStub logger = new DeployLoggerStub();
ApplicationBuilder.createFromString(sd, logger);
assertTrue(logger.entries.isEmpty());
}
@Test
void testStructMemorySummary() throws ParseException {
String sd = joinLines(
"schema structmemorysummary {",
" document structmemorysummary {",
" struct elem {",
" field name type string {}",
" field weight type int {}",
" }",
" field elem_array type array<elem> {",
" indexing: summary",
" struct-field name {",
" indexing: attribute",
" }",
" struct-field weight {",
" indexing: attribute",
" }",
" }",
" }",
" document-summary filtered {",
" summary elem_array_filtered type array<elem> {",
" source: elem_array",
" matched-elements-only",
" }",
" }",
"}");
DeployLoggerStub logger = new DeployLoggerStub();
ApplicationBuilder.createFromString(sd, logger);
assertTrue(logger.entries.isEmpty());
}
@Test
void testInheritance() throws Exception {
String sd = joinLines(
"schema music {",
" document music {",
" field title type string {",
" indexing: summary | attribute | index",
" }",
" field artist type string {",
" indexing: summary | attribute | index",
" }",
" field album type string {",
" indexing: summary | attribute | index",
" }",
" }",
" document-summary title {",
" summary title type string {",
" source: title",
" }",
" }",
" document-summary title_artist inherits title {",
" summary artist type string {",
" source: artist",
" }",
" }",
" document-summary everything inherits title_artist {",
" summary album type string {",
" source: album",
" }",
" }",
"}");
var logger = new DeployLoggerStub();
var search = ApplicationBuilder.createFromString(sd, logger).getSchema();
assertEquals(List.of(), logger.entries);
var titleField = "title";
var artistField = "artist";
var albumField = "album";
var titleSummary = search.getSummary(titleField);
var titleArtistSummary = search.getSummary(titleField + "_" + artistField);
var everythingSummary = search.getSummary("everything");
var implicitFields = List.of("rankfeatures", "summaryfeatures");
var tests = List.of(
new TestValue(titleSummary, null, List.of(List.of(titleField), implicitFields)),
new TestValue(titleArtistSummary, titleSummary, List.of(List.of(titleField), implicitFields, List.of(artistField))),
new TestValue(everythingSummary, titleArtistSummary, List.of(List.of(titleField), implicitFields, List.of(artistField, albumField)))
);
tests.forEach(testValue -> {
var actualFields = testValue.summary.getSummaryFields().values().stream()
.map(FieldBase::getName)
.toList();
assertEquals(Optional.ofNullable(testValue.parent),
testValue.summary.inherited(),
testValue.summary.getName() + (testValue.parent == null ? " does not inherit anything" : " inherits " + testValue.parent.getName()));
assertEquals(testValue.fields, actualFields, "Summary " + testValue.summary.getName() + " has expected fields");
});
}
@Test
void testRedeclaringInheritedFieldFails() throws Exception {
String sd = joinLines(
"schema music {",
" document music {",
" field title type string {",
" indexing: summary | attribute | index",
" }",
" field title_short type string {",
" indexing: summary | attribute | index",
" }",
" }",
" document-summary title {",
" summary title type string {",
" source: title",
" }",
" }",
" document-summary title2 inherits title {",
" summary title type string {",
" source: title_short",
" }",
" }",
"}");
var logger = new DeployLoggerStub();
try {
ApplicationBuilder.createFromString(sd, logger);
fail("Expected exception");
} catch (IllegalArgumentException e) {
assertEquals("For schema 'music', summary class 'title2', summary field 'title': Can not use " +
"source 'title_short' for this summary field, an equally named field in summary class 'title' " +
"uses a different source: 'title'.", e.getMessage());
}
}
@Test
void testValidationOfInheritedSummary() throws ParseException {
try {
String schema = joinLines(
"schema test {" +
" document test {" +
" }" +
" document-summary test_summary inherits nonesuch {" +
" }" +
"}");
DeployLoggerStub logger = new DeployLoggerStub();
ApplicationBuilder.createFromStrings(logger, schema);
assertEquals("document summary 'test_summary' inherits nonesuch but this is not present in schema 'test'",
logger.entries.get(0).message);
// fail("Expected failure");
}
catch (IllegalArgumentException e) {
// assertEquals("document summary 'test_summary' inherits nonesuch but this is not present in schema 'test'",
// e.getMessage());
}
}
@Test
void testInheritingParentSummary() throws ParseException {
String parent = joinLines(
"schema parent {" +
" document parent {" +
" field pf1 type string {" +
" indexing: summary" +
" }" +
" }" +
" document-summary parent_summary {" +
" summary pf1 type string {}" +
" }" +
"}");
String child = joinLines(
"schema child inherits parent {" +
" document child inherits parent {" +
" field cf1 type string {" +
" indexing: summary" +
" }" +
" }" +
" document-summary child_summary inherits parent_summary {" +
" summary cf1 type string {}" +
" }" +
"}");
DeployLoggerStub logger = new DeployLoggerStub();
ApplicationBuilder.createFromStrings(logger, parent, child);
logger.entries.forEach(e -> System.out.println(e));
//assertTrue(logger.entries.isEmpty());
}
private static class TestValue {
private final DocumentSummary summary;
private final DocumentSummary parent;
private final List<String> fields;
public TestValue(DocumentSummary summary, DocumentSummary parent, List<List<String>> fields) {
this.summary = summary;
this.parent = parent;
this.fields = fields.stream().flatMap(Collection::stream).toList();;
}
}
}
|
