1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.application.validation;
import com.yahoo.config.application.api.DeployLogger;
import com.yahoo.config.model.application.provider.BaseDeployLogger;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.jar.JarEntry;
import java.util.jar.JarFile;
import java.util.jar.JarOutputStream;
import static com.yahoo.yolean.Exceptions.uncheck;
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
public class BundleValidatorTest {
@Rule
public TemporaryFolder tempDir = new TemporaryFolder();
@Test
public void basicBundleValidation() throws Exception {
// Valid jar file
JarFile ok = createTemporaryJarFile("ok");
BundleValidator bundleValidator = new BundleValidator();
bundleValidator.validateJarFile(new BaseDeployLogger(), false, ok);
// No manifest
validateWithException("nomanifest", "Non-existing or invalid manifest in nomanifest.jar");
}
private void validateWithException(String jarName, String exceptionMessage) throws IOException {
try {
JarFile jarFile = createTemporaryJarFile(jarName);
BundleValidator bundleValidator = new BundleValidator();
bundleValidator.validateJarFile(new BaseDeployLogger(), false, jarFile);
assert (false);
} catch (IllegalArgumentException e) {
assertEquals(e.getMessage(), exceptionMessage);
}
}
@Test
public void require_that_deploying_snapshot_bundle_gives_warning() throws IOException {
final StringBuffer buffer = new StringBuffer();
DeployLogger logger = createDeployLogger(buffer);
JarFile jarFile = createTemporaryJarFile("snapshot_bundle");
new BundleValidator().validateJarFile(logger, false, jarFile);
assertTrue(buffer.toString().contains("Deploying snapshot bundle"));
}
@Test
public void outputs_deploy_warning_on_import_of_packages_from_deprecated_artifact() throws IOException {
final StringBuffer buffer = new StringBuffer();
DeployLogger logger = createDeployLogger(buffer);
BundleValidator validator = new BundleValidator();
JarFile jarFile = createTemporaryJarFile("import-warnings");
validator.validateJarFile(logger, true, jarFile);
assertThat(buffer.toString())
.contains("For JAR file 'import-warnings.jar': \n" +
"Manifest imports the following Java packages from 'org.json:json': [org.json]. \n" +
"The org.json library will no longer provided by jdisc runtime on Vespa 8. See https://docs.vespa.ai/en/vespa8-release-notes.html#container-runtime.");
}
@Test
public void outputs_deploy_warnings_for_pom_xml() throws IOException {
StringBuffer buffer = new StringBuffer();
DeployLogger logger = createDeployLogger(buffer);
BundleValidator validator = new BundleValidator();
JarFile jarFile = createTemporaryJarFile("pom-xml-warnings");
validator.validateJarFile(logger, true, jarFile);
String output = buffer.toString();
assertThat(output)
.contains("The pom.xml of bundle 'pom-xml-warnings.jar' includes a dependency to the artifact " +
"'com.yahoo.vespa:vespa-http-client-extensions'. \n" +
"This artifact will be removed in Vespa 8. " +
"Programmatic use can be safely removed from system/staging tests. " +
"See internal Vespa 8 release notes for details.\n");
assertThat(output)
.contains("\n" +
"<pluginRepositories> in pom.xml of 'pom-xml-warnings.jar' uses deprecated Maven repository " +
"'http://myartifactory:8000/artifactory/vespa-maven-libs-release-local'.\n See announcement.");
assertThat(output)
.contains("\n" +
"<repositories> in pom.xml of 'pom-xml-warnings.jar' uses deprecated Maven repository " +
"'http://myartifactory:8000/artifactory/vespa-maven-libs-release-local'.\n See announcement.");
}
private JarFile createTemporaryJarFile(String testArtifact) throws IOException {
Path jarFile = tempDir.newFile(testArtifact + ".jar").toPath();
Path artifactDirectory = Paths.get("src/test/cfg/application/validation/testjars/" + testArtifact);
try (JarOutputStream out = new JarOutputStream(Files.newOutputStream(jarFile))) {
Files.walk(artifactDirectory).forEach(path -> {
Path relativePath = artifactDirectory.relativize(path);
String zipName = relativePath.toString();
uncheck(() -> {
if (Files.isDirectory(path)) {
out.putNextEntry(new JarEntry(zipName + "/"));
} else {
out.putNextEntry(new JarEntry(zipName));
out.write(Files.readAllBytes(path));
}
out.closeEntry();
});
});
}
return new JarFile(jarFile.toFile());
}
private DeployLogger createDeployLogger(StringBuffer buffer) {
return (__, message) -> buffer.append(message).append('\n');
}
}
|
