1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.application.validation;
import com.yahoo.tensor.TensorType;
import org.junit.jupiter.api.Test;
import java.io.Reader;
import java.io.StringReader;
import static com.yahoo.test.json.JsonTestHelper.inputJson;
import static com.yahoo.vespa.model.application.validation.ConstantTensorJsonValidator.InvalidConstantTensorException;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
public class ConstantTensorJsonValidatorTest {
private static Reader inputJsonToReader(String... lines) {
return new StringReader(inputJson(lines));
}
private static void validateTensorJson(TensorType tensorType, Reader jsonTensorReader) {
new ConstantTensorJsonValidator(tensorType).validate("dummy.json", jsonTensorReader);
}
@Test
void ensure_that_unbounded_tensor_works() {
validateTensorJson(
TensorType.fromSpec("tensor(x[], y[])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': '99999', 'y': '47' },",
" 'value': 9932.0",
" }",
" ]",
"}"));
}
@Test
void ensure_that_bounded_tensor_within_limits_works() {
validateTensorJson(
TensorType.fromSpec("tensor(x[5], y[10])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': '3', 'y': '2' },",
" 'value': 2.0",
" }",
" ]",
"}"));
}
@Test
void ensure_that_multiple_cells_work() {
validateTensorJson(
TensorType.fromSpec("tensor(x[], y[])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': '3', 'y': '2' },",
" 'value': 2.0",
" },",
" {",
" 'address': { 'x': '2', 'y': '0' },",
" 'value': 45",
" }",
" ]",
"}"));
}
@Test
void ensure_that_no_cells_work() {
validateTensorJson(
TensorType.fromSpec("tensor(x[], y[])"),
inputJsonToReader(
"{",
" 'cells': []",
"}"));
}
@Test
void ensure_that_bound_tensor_outside_limits_is_disallowed() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[5], y[10])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': '5', 'y': '2' },",
" 'value': 1e47",
" }",
" ]",
"}"));
});
assertTrue(exception.getMessage().contains("Index 5 not within limits of bound dimension 'x'"));
}
@Test
void ensure_that_mapped_tensor_works() {
validateTensorJson(
TensorType.fromSpec("tensor(x{}, y{})"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': 'andrei', 'y': 'bjarne' },",
" 'value': 2.0",
" }",
" ]",
"}"));
}
@Test
void ensure_that_non_integer_strings_in_address_points_are_disallowed_unbound() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': 'a' },",
" 'value': 47.0",
" }",
" ]",
"}"));
});
assertTrue(exception.getMessage().contains("Index 'a' for dimension 'x' is not an integer"));
}
@Test
void ensure_that_tensor_coordinates_are_strings() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': 47 },",
" 'value': 33.0",
" }",
" ]",
"}"));
});
assertTrue(exception.getMessage().contains("Tensor label is not a string (VALUE_NUMBER_INT)"));
}
@Test
void ensure_that_non_integer_strings_in_address_points_are_disallowed_bounded() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[5])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': 'a' },",
" 'value': 41.0",
" }",
" ]",
"}"));
});
assertTrue(exception.getMessage().contains("Index 'a' for dimension 'x' is not an integer"));
}
@Test
void ensure_that_missing_coordinates_fail() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[], y[], z[])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': '3' },",
" 'value': 99.3",
" }",
" ]",
"}"));
});
assertTrue(exception.getMessage().contains("Tensor address missing dimension(s) y, z"));
}
@Test
void ensure_that_non_number_values_are_disallowed() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': '3' },",
" 'value': 'fruit'",
" }",
" ]",
"}"));
});
assertTrue(exception.getMessage().contains("Inside 'value': cell value is not a number (VALUE_STRING)"));
}
@Test
void ensure_that_extra_dimensions_are_disallowed() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[], y[])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': '3', 'y': '2', 'z': '4' },",
" 'value': 99.3",
" }",
" ]",
"}"));
});
assertTrue(exception.getMessage().contains("Tensor dimension 'z' does not exist"));
}
@Test
void ensure_that_duplicate_dimensions_are_disallowed() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[], y[])"),
inputJsonToReader(
"{",
" 'cells': [",
" {",
" 'address': { 'x': '1', 'y': '2', 'y': '4' },",
" 'value': 88.1",
" }",
" ]",
"}"));
});
assertTrue(exception.getMessage().contains("Duplicate tensor dimension 'y'"));
}
@Test
void ensure_that_invalid_json_fails() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x[], y[])"),
inputJsonToReader(
"{",
" cells': [",
" {",
" 'address': { 'x': '3' 'y': '2' }",
" 'value': 2.0",
" }",
" ",
"}"));
});
assertTrue(exception.getMessage().contains("Failed to parse JSON stream"));
}
@Test
void ensure_that_invalid_json_not_in_tensor_format_fails() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(TensorType.fromSpec("tensor(x[], y[])"),
inputJsonToReader(
"{",
" 'stats': {",
" '\u30d1\u30fc\u30d7\u30eb\u30b4\u30e0\u88fd\u306e\u30a2\u30d2\u30eb\u306f\u79c1\u3092\u6bba\u3059\u305f\u3081\u306b\u671b\u3093\u3067\u3044\u307e\u3059': true,",
" 'points': 47",
" }",
"}"));
});
assertTrue(exception.getMessage().contains("Unexpected content '{' for field 'stats'"));
}
@Test
void ensure_that_values_array_for_vector_works() {
validateTensorJson(
TensorType.fromSpec("tensor(x[5])"),
inputJsonToReader("[5,4.0,3.1,-2,-1.0]"));
validateTensorJson(
TensorType.fromSpec("tensor(x[5])"),
inputJsonToReader("{'values':[5,4.0,3.1,-2,-1.0]}"));
}
@Test
void ensure_that_simple_object_for_map_works() {
validateTensorJson(
TensorType.fromSpec("tensor(x{})"),
inputJsonToReader("{'cells':{'a':5,'b':4.0,'c':3.1,'d':-2,'e':-1.0}}"));
}
@Test
void ensure_that_matrices_work() {
validateTensorJson(
TensorType.fromSpec("tensor(x[2], y[3])"),
inputJsonToReader(
"[",
" [ 1, 2, 3],",
" [ 4, 5, 6]",
"]"));
validateTensorJson(
TensorType.fromSpec("tensor(x[2], y[3])"),
inputJsonToReader(
"{'values':[",
" [ 1, 2, 3],",
" [ 4, 5, 6]",
"]}"));
}
@Test
void ensure_that_simple_maps_work() {
validateTensorJson(
TensorType.fromSpec("tensor(category{})"),
inputJsonToReader(
"{",
" 'foo': 1,",
" 'bar': 2,",
" 'type': 3,",
" 'cells': 4,",
" 'value': 5,",
" 'values': 6,",
" 'blocks': 7,",
" 'anything': 8",
"}"));
validateTensorJson(
TensorType.fromSpec("tensor(category{})"),
inputJsonToReader(
"{'cells':{",
" 'foo': 1,",
" 'bar': 2,",
" 'type': 3,",
" 'cells': 4,",
" 'value': 5,",
" 'values': 6,",
" 'blocks': 7,",
" 'anything': 8",
"}}"));
}
@Test
void ensure_that_mixing_formats_disallowed() {
Throwable exception = assertThrows(InvalidConstantTensorException.class, () -> {
validateTensorJson(
TensorType.fromSpec("tensor(x{})"),
inputJsonToReader("{ 'a': 1.0, 'cells': { 'b': 2.0 } }"));
});
assertTrue(exception.getMessage().contains("Cannot use {label: value} format together with 'cells'"));
}
@Test
void ensure_that_simple_blocks_work() {
validateTensorJson(
TensorType.fromSpec("tensor(a{},b[3])"),
inputJsonToReader(
"{'blocks':{'foo':[1,2,3], 'bar':[4,5,6]}}"));
}
@Test
void ensure_that_complex_blocks_work() {
validateTensorJson(
TensorType.fromSpec("tensor(a{},b[3],c{},d[2])"),
inputJsonToReader(
"{'blocks':[",
"{'address':{'a':'foo','c':'bar'},'values':[[1,2],[3,4],[5,6]]},",
"{'address':{'a':'qux','c':'zip'},'values':[[9,8],[7,6],[5,4]]}]}"));
}
}
|
