1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.application.validation;// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
import com.yahoo.config.application.api.ApplicationPackage;
import com.yahoo.config.model.NullConfigModelRegistry;
import com.yahoo.config.model.deploy.DeployState;
import com.yahoo.config.model.deploy.TestProperties;
import com.yahoo.config.model.test.MockApplicationPackage;
import com.yahoo.vespa.model.VespaModel;
import org.junit.jupiter.api.Test;
import org.xml.sax.SAXException;
import java.io.IOException;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
/**
* @author bjorncs
*/
public class UriBindingsValidatorTest {
@Test
void fails_on_user_handler_binding_with_port() throws IOException, SAXException {
Throwable exception = assertThrows(IllegalArgumentException.class, () -> {
runUriBindingValidator(true, createServicesXmlWithHandler("http://*:4443/my-handler"));
});
assertTrue(exception.getMessage().contains("For binding 'http://*:4443/my-handler': binding with port is not allowed"));
}
@Test
void fails_on_user_handler_binding_with_hostname() throws IOException, SAXException {
Throwable exception = assertThrows(IllegalArgumentException.class, () -> {
runUriBindingValidator(true, createServicesXmlWithHandler("http://myhostname/my-handler"));
});
assertTrue(exception.getMessage().contains("For binding 'http://myhostname/my-handler': only binding with wildcard ('*') for hostname is allowed"));
}
@Test
void fails_on_user_handler_binding_with_non_http_scheme() throws IOException, SAXException {
Throwable exception = assertThrows(IllegalArgumentException.class, () -> {
runUriBindingValidator(true, createServicesXmlWithHandler("ftp://*/my-handler"));
});
assertTrue(exception.getMessage().contains("For binding 'ftp://*/my-handler': only 'http' is allowed as scheme"));
}
@Test
void fails_on_invalid_filter_binding() throws IOException, SAXException {
Throwable exception = assertThrows(IllegalArgumentException.class, () -> {
runUriBindingValidator(true, createServicesXmlWithRequestFilterChain("https://*:4443/my-request-filer-chain"));
});
assertTrue(exception.getMessage().contains("For binding 'https://*:4443/my-request-filer-chain': binding with port is not allowed"));
}
@Test
void allows_valid_user_binding() throws IOException, SAXException {
runUriBindingValidator(true, createServicesXmlWithHandler("http://*/my-handler"));
}
void allows_user_binding_with_wildcard_port() throws IOException, SAXException {
runUriBindingValidator(true, createServicesXmlWithHandler("http://*:*/my-handler"));
}
@Test
void only_restricts_user_bindings_on_hosted() throws IOException, SAXException {
runUriBindingValidator(false, createServicesXmlWithRequestFilterChain("https://*:4443/my-request-filer-chain"));
}
private void runUriBindingValidator(boolean isHosted, String servicesXml) throws IOException, SAXException {
runUriBindingValidator(new TestProperties().setHostedVespa(isHosted), servicesXml);
}
private void runUriBindingValidator(TestProperties testProperties, String servicesXml) throws IOException, SAXException {
ApplicationPackage app = new MockApplicationPackage.Builder()
.withServices(servicesXml)
.build();
DeployState deployState = new DeployState.Builder()
.applicationPackage(app)
.properties(testProperties)
.build();
VespaModel model = new VespaModel(new NullConfigModelRegistry(), deployState);
new UriBindingsValidator().validate(model, deployState);
}
private static String createServicesXmlWithHandler(String handlerBinding) {
return String.join(
"\n",
"<services version='1.0'>",
" <container id='default' version='1.0'>",
" <handler id='custom.Handler'>",
" <binding>" + handlerBinding + "</binding>",
" </handler>",
" </container>",
"</services>");
}
private static String createServicesXmlWithRequestFilterChain(String filterBinding) {
return String.join(
"\n",
"<services version='1.0'>",
" <container version='1.0'>",
" <http>",
" <server port='8080' id='main' />",
" <filtering>",
" <request-chain id='myChain'>",
" <filter id='myFilter'/>",
" <binding>" + filterBinding + "</binding>",
" </request-chain>",
" </filtering>",
" </http>",
" </container>",
"</services>");
}
}
|
