1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.application.validation.change;
import com.yahoo.config.application.api.ValidationId;
import com.yahoo.config.application.api.ValidationOverrides;
import com.yahoo.config.model.provision.InMemoryProvisioner;
import com.yahoo.config.provision.Environment;
import com.yahoo.config.provision.NodeResources;
import com.yahoo.vespa.model.VespaModel;
import com.yahoo.vespa.model.application.validation.ValidationTester;
import com.yahoo.yolean.Exceptions;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.fail;
/**
* @author freva
* @author bratseth
*/
public class ResourcesReductionValidatorTest {
private final NodeResources hostResources = new NodeResources(64, 128, 1000, 10);
private final InMemoryProvisioner provisioner = new InMemoryProvisioner(30, hostResources, true, InMemoryProvisioner.defaultHostResources);
private final InMemoryProvisioner provisionerSelfHosted = new InMemoryProvisioner(30, hostResources, true, NodeResources.unspecified());
private final NodeResources defaultResources = InMemoryProvisioner.defaultHostResources;
private final ValidationTester tester = new ValidationTester(provisioner);
@Test
void fail_when_reduction_by_over_50_percent() {
var fromResources = new NodeResources(8, 64, 800, 1);
var toResources = new NodeResources(8, 16, 800, 1);
VespaModel previous = tester.deploy(null, contentServices(6, fromResources), Environment.prod, null).getFirst();
try {
tester.deploy(previous, contentServices(6, toResources), Environment.prod, null);
fail("Expected exception due to resources reduction");
} catch (IllegalArgumentException expected) {
assertResourceReductionException(expected,
fromResources.multipliedBy(6),
toResources.multipliedBy(6));
}
}
@Test
void fail_when_reducing_multiple_resources_by_over_50_percent() {
var fromResources = new NodeResources(8, 64, 800, 1);
var toResources = new NodeResources(3, 16, 200, 1);
VespaModel previous = tester.deploy(null, contentServices(6, fromResources), Environment.prod, null).getFirst();
try {
tester.deploy(previous, contentServices(6, toResources), Environment.prod, null);
fail("Expected exception due to resources reduction");
} catch (IllegalArgumentException expected) {
assertResourceReductionException(expected,
fromResources.multipliedBy(6),
toResources.multipliedBy(6));
}
}
@Test
void small_resource_decrease_is_allowed() {
VespaModel previous = tester.deploy(null, contentServices(6, new NodeResources(1.5, 64, 800, 1)), Environment.prod, null).getFirst();
tester.deploy(previous, contentServices(6, new NodeResources(.5, 48, 600, 1)), Environment.prod, null);
}
@Test
void reorganizing_resources_is_allowed() {
VespaModel previous = tester.deploy(null, contentServices(12, new NodeResources(2, 10, 100, 1)), Environment.prod, null).getFirst();
tester.deploy(previous, contentServices(4, new NodeResources(6, 30, 300, 1)), Environment.prod, null);
}
@Test
void overriding_resource_decrease() {
VespaModel previous = tester.deploy(null, contentServices(6, new NodeResources(8, 64, 800, 1)), Environment.prod, null).getFirst();
tester.deploy(previous, contentServices(6, new NodeResources(8, 16, 800, 1)), Environment.prod, resourcesReductionOverride); // Allowed due to override
}
@Test
void reduction_is_detected_when_going_from_unspecified_resources_container() {
NodeResources toResources = defaultResources.withDiskGb(defaultResources.diskGb() / 5);
try {
VespaModel previous = tester.deploy(null, containerServices(6, null), Environment.prod, null).getFirst();
tester.deploy(previous, containerServices(6, toResources), Environment.prod, null);
fail("Expected exception due to resources reduction");
}
catch (IllegalArgumentException expected) {
assertResourceReductionException(expected,
defaultResources.multipliedBy(6),
toResources.multipliedBy(6));
}
}
@Test
void reduction_is_detected_when_going_to_unspecified_resources_container() {
NodeResources fromResources = defaultResources.withVcpu(defaultResources.vcpu() * 3);
try {
VespaModel previous = tester.deploy(null, containerServices(6, fromResources), Environment.prod, null).getFirst();
tester.deploy(previous, containerServices(6, null), Environment.prod, null);
fail("Expected exception due to resources reduction");
}
catch (IllegalArgumentException expected) {
assertResourceReductionException(expected,
fromResources.multipliedBy(6),
defaultResources.multipliedBy(6));
}
}
@Test
void reduction_is_detected_when_going_from_unspecified_resources_content() {
NodeResources toResources = defaultResources.withDiskGb(defaultResources.diskGb() / 5);
try {
VespaModel previous = tester.deploy(null, contentServices(6, null), Environment.prod, null).getFirst();
tester.deploy(previous, contentServices(6, toResources), Environment.prod, null);
fail("Expected exception due to resources reduction");
}
catch (IllegalArgumentException expected) {
assertResourceReductionException(expected,
defaultResources.multipliedBy(6),
toResources.multipliedBy(6));
}
}
@Test
void reduction_is_detected_when_going_to_unspecified_resources_content() {
NodeResources fromResources = defaultResources.withVcpu(defaultResources.vcpu() * 3);
try {
VespaModel previous = tester.deploy(null, contentServices(6, fromResources), Environment.prod, null).getFirst();
tester.deploy(previous, contentServices(6, null), Environment.prod, null);
fail("Expected exception due to resources reduction");
}
catch (IllegalArgumentException expected) {
assertResourceReductionException(expected,
fromResources.multipliedBy(6),
defaultResources.multipliedBy(6));
}
}
@Test
void testSizeReductionValidationWithUnspecifiedResourcesHosted() {
int fromNodes = 30;
int toNodes = 14;
try {
ValidationTester tester = new ValidationTester(33);
VespaModel previous = tester.deploy(null, contentServices(fromNodes, null), Environment.prod, null).getFirst();
tester.deploy(previous, contentServices(toNodes, null), Environment.prod, null);
fail("Expected exception due to resources reduction");
}
catch (IllegalArgumentException expected) {
assertResourceReductionException(expected,
defaultResources.multipliedBy(fromNodes),
defaultResources.multipliedBy(toNodes));
}
}
/** Emulate a self-hosted setup in only the sense that it does not set node resources on the provisioned hosts. */
@Test
void testSizeReductionValidationSelfhosted() {
var tester = new ValidationTester(provisionerSelfHosted);
VespaModel previous = tester.deploy(null, contentServices(10, null), Environment.prod, null).getFirst();
try {
tester.deploy(previous, contentServices(4, null), Environment.prod, null);
fail("Expected exception due to resources reduction");
}
catch (IllegalArgumentException expected) {
assertEquals("resources-reduction: Size reduction in 'default' is too large: " +
"To guard against mistakes, the new max nodes must be at least 50% of the current nodes. " +
"Current nodes: 10, new nodes: 4. " +
ValidationOverrides.toAllowMessage(ValidationId.resourcesReduction),
Exceptions.toMessageString(expected));
}
}
@Test
void testSizeReductionValidationMinimalDecreaseIsAllowed() {
ValidationTester tester = new ValidationTester(30);
VespaModel previous = tester.deploy(null, contentServices(3, null), Environment.prod, null).getFirst();
tester.deploy(previous, contentServices(2, null), Environment.prod, null);
}
@Test
void testOverridingSizeReductionValidation() {
ValidationTester tester = new ValidationTester(33);
VespaModel previous = tester.deploy(null, contentServices(30, null), Environment.prod, null).getFirst();
tester.deploy(previous, contentServices(14, null), Environment.prod, resourcesReductionOverride); // Allowed due to override
}
private void assertResourceReductionException(Exception e, NodeResources currentResources, NodeResources newResources) {
assertEquals("resources-reduction: Resource reduction in 'default' is too large: " +
"To guard against mistakes, the new max resources must be at least 50% of the current max " +
"resources in all dimensions. " +
"Current: " + currentResources.withBandwidthGbps(0) +
", new: " + newResources.withBandwidthGbps(0) + ". " +
ValidationOverrides.toAllowMessage(ValidationId.resourcesReduction),
Exceptions.toMessageString(e));
}
private static String containerServices(int nodes, NodeResources resources) {
String resourcesStr = resources == null ?
"" :
String.format(" <resources vcpu='%.0f' memory='%.0fG' disk='%.0fG'/>",
resources.vcpu(), resources.memoryGb(), resources.diskGb());
return "<services version='1.0'>" +
" <container id='default' version='1.0'>" +
" <nodes count='" + nodes + "'>" +
resourcesStr +
" </nodes>" +
" </container>" +
"</services>";
}
private static String contentServices(int nodes, NodeResources resources) {
String resourcesStr = resources == null ?
"" :
String.format(" <resources vcpu='%.0f' memory='%.0fG' disk='%.0fG'/>",
resources.vcpu(), resources.memoryGb(), resources.diskGb());
return "<services version='1.0'>" +
" <content id='default' version='1.0'>" +
" <redundancy>1</redundancy>" +
" <engine>" +
" <proton/>" +
" </engine>" +
" <documents>" +
" <document type='music' mode='index'/>" +
" </documents>" +
" <nodes count='" + nodes + "'>" +
resourcesStr +
" </nodes>" +
" </content>" +
"</services>";
}
private static final String resourcesReductionOverride =
"<validation-overrides>\n" +
" <allow until='2000-01-03'>resources-reduction</allow>\n" +
"</validation-overrides>\n";
}
|
