1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.model.application.validation.change.search;
import com.yahoo.config.application.api.ValidationId;
import com.yahoo.config.provision.ClusterSpec;
import com.yahoo.vespa.indexinglanguage.expressions.ScriptExpression;
import com.yahoo.vespa.model.application.validation.change.VespaConfigChangeAction;
import com.yahoo.vespa.model.application.validation.change.VespaReindexAction;
import static com.yahoo.config.model.test.TestUtil.joinLines;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test;
import java.util.Arrays;
import java.util.List;
public class IndexingScriptChangeValidatorTest {
private static class Fixture extends ContentClusterFixture {
IndexingScriptChangeValidator validator;
public Fixture(String currentSd, String nextSd) throws Exception {
super(currentSd, nextSd);
validator = new IndexingScriptChangeValidator(ClusterSpec.Id.from("test"),
currentDb().getDerivedConfiguration().getSchema(),
nextDb().getDerivedConfiguration().getSchema());
}
public Fixture(String entireSd) throws Exception {
super(entireSd);
validator = new IndexingScriptChangeValidator(ClusterSpec.Id.from("test"),
currentDb().getDerivedConfiguration().getSchema(),
nextDb().getDerivedConfiguration().getSchema());
}
@Override
public List<VespaConfigChangeAction> validate() {
return validator.validate();
}
}
private static class ScriptFixture {
private final ScriptExpression currentScript;
private final ScriptExpression nextScript;
public ScriptFixture(String currentScript, String nextScript) throws Exception {
this.currentScript = ScriptExpression.fromString(currentScript);
this.nextScript = ScriptExpression.fromString(nextScript);
}
public boolean validate() {
return IndexingScriptChangeValidator.equalScripts(currentScript, nextScript);
}
}
private static final String FIELD = "field f1 type string";
private static final String FIELD_F2 = "field f2 type string";
private static VespaConfigChangeAction expectedReindexingAction(String changedMsg, String fromScript, String toScript) {
return expectedReindexingAction("f1", changedMsg, fromScript, toScript);
}
private static VespaConfigChangeAction expectedReindexingAction(String field, String changedMsg, String fromScript, String toScript) {
return VespaReindexAction.of(ClusterSpec.Id.from("test"),
ValidationId.indexingChange,
"Field '" + field + "' changed: " +
(changedMsg.isEmpty() ? "" : changedMsg + ", ") +
"indexing script: '" + fromScript + "' -> '" + toScript + "'");
}
@Test
void requireThatAddingIndexAspectRequireReindexing() throws Exception {
new Fixture(FIELD + " { indexing: summary }",
FIELD + " { indexing: index | summary }").
assertValidation(expectedReindexingAction("add index aspect",
"{ input f1 | summary f1; }",
"{ input f1 | tokenize normalize stem:\"BEST\" | index f1 | summary f1; }"));
}
@Test
void requireThatRemovingIndexAspectRequireReindexing() throws Exception {
new Fixture(FIELD + " { indexing: index | summary }",
FIELD + " { indexing: summary }").
assertValidation(expectedReindexingAction("remove index aspect",
"{ input f1 | tokenize normalize stem:\"BEST\" | index f1 | summary f1; }",
"{ input f1 | summary f1; }"));
}
@Test
void requireThatChangingStemmingRequireReindexing() throws Exception {
new Fixture(FIELD + " { indexing: index }",
FIELD + " { indexing: index \n stemming: none }").
assertValidation(expectedReindexingAction("stemming: 'best' -> 'none'",
"{ input f1 | tokenize normalize stem:\"BEST\" | index f1; }",
"{ input f1 | tokenize normalize | index f1; }"));
}
@Test
void requireThatChangingNormalizingRequireReindexing() throws Exception {
new Fixture(FIELD + " { indexing: index }",
FIELD + " { indexing: index \n normalizing: none }").
assertValidation(expectedReindexingAction("normalizing: 'ACCENT' -> 'NONE'",
"{ input f1 | tokenize normalize stem:\"BEST\" | index f1; }",
"{ input f1 | tokenize stem:\"BEST\" | index f1; }"));
}
@Test
void requireThatChangingMatchingRequireReindexing() throws Exception {
new Fixture(FIELD + " { indexing: index \n match: exact }",
FIELD + " { indexing: index \n match { gram \n gram-size: 3 } }").
assertValidation(expectedReindexingAction("matching: 'exact' -> 'gram (size 3)', normalizing: 'LOWERCASE' -> 'CODEPOINT'",
"{ input f1 | exact | index f1; }",
"{ input f1 | ngram 3 | index f1; }"));
}
@Test
void requireThatSettingDynamicSummaryRequireReindexing() throws Exception {
new Fixture(FIELD + " { indexing: summary }",
FIELD + " { indexing: summary \n summary: dynamic }").
assertValidation(expectedReindexingAction("summary field 'f1' transform: 'none' -> 'dynamicteaser'",
"{ input f1 | summary f1; }",
"{ input f1 | tokenize normalize stem:\"BEST\" | summary f1; }"));
}
@Test
void requireThatMultipleChangesRequireReindexing() throws Exception {
new Fixture(FIELD + " { indexing: index } " + FIELD_F2 + " { indexing: index }",
FIELD + " { indexing: index \n stemming: none } " + FIELD_F2 + " { indexing: index \n normalizing: none }").
assertValidation(Arrays.asList(expectedReindexingAction("f1", "stemming: 'best' -> 'none'",
"{ input f1 | tokenize normalize stem:\"BEST\" | index f1; }",
"{ input f1 | tokenize normalize | index f1; }"),
expectedReindexingAction("f2", "normalizing: 'ACCENT' -> 'NONE'",
"{ input f2 | tokenize normalize stem:\"BEST\" | index f2; }",
"{ input f2 | tokenize stem:\"BEST\" | index f2; }")));
}
@Test
void requireThatAddingDocumentIndexFieldIsOk() throws Exception {
new Fixture("", "field f1 type string { indexing: index | summary }").
assertValidation();
}
@Test
void requireThatRemovingIndexFieldIsOk() throws Exception {
new Fixture("field f1 type string { indexing: index | summary }", "").
assertValidation();
}
@Test
void requireThatAddingDocumentFieldIsOk() throws Exception {
new Fixture("", FIELD + " { indexing: attribute | summary }").
assertValidation();
}
@Test
void requireThatAddingExtraFieldRequiresReindexing() throws Exception {
new Fixture(" field f1 type string { indexing: index }",
" field f1 type string { indexing: index } } " +
" field f2 type string { indexing: input f1 | summary ")
.assertValidation(VespaReindexAction.of(ClusterSpec.Id.from("test"),
null,
"Non-document field 'f2' added; this may be populated by reindexing"));
}
@Test
void requireThatAddingSummaryAspectIsOk() throws Exception {
new Fixture(FIELD + " { indexing: attribute }",
FIELD + " { indexing: attribute | summary }").
assertValidation();
}
@Test
void requireThatSettingDynamicSummaryOnIndexFieldIsOk() throws Exception {
new Fixture(FIELD + " { indexing: index | summary }",
FIELD + " { indexing: index | summary \n summary: dynamic }").
assertValidation();
}
@Test
void requireThatOutputExpressionsAreIgnoredInAdvancedScript() throws Exception {
assertTrue(new ScriptFixture("{ input foo | switch { case \"audio\": input bar | index; case \"video\": input baz | index; default: 0 | index; }; }",
"{ input foo | switch { case \"audio\": input bar | attribute; case \"video\": input baz | attribute; default: 0 | attribute; }; }").
validate());
}
@Test
void requireThatNormalizeIsOk() throws Exception {
String entireSd = joinLines(
"search test {",
" document test {",
" field inside type array<string> {",
" indexing: summary",
" }",
" }",
" field outside type array<string> {",
" indexing: input inside | for_each { normalize } | index outside",
" }",
"}");
new Fixture(entireSd).assertValidation();
}
@Test
void requireThatNgramIsOk() throws Exception {
String entireSd = joinLines(
"search test {",
" document test {",
" field inside type string {",
" indexing: index",
" match {",
" gram",
" gram-size: 3",
" }",
" }",
" }",
" field outside type string {",
" indexing: input inside | ngram 2 | index outside",
" }",
"}");
new Fixture(entireSd).assertValidation();
}
}
|
