1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.config.server.http.v2;
import com.yahoo.cloud.config.ConfigserverConfig;
import com.yahoo.config.provision.ApplicationId;
import com.yahoo.config.provision.ApplicationName;
import com.yahoo.config.provision.InstanceName;
import com.yahoo.config.provision.TenantName;
import com.yahoo.container.jdisc.HttpRequest;
import com.yahoo.container.jdisc.HttpResponse;
import com.yahoo.vespa.config.server.ApplicationRepository;
import com.yahoo.vespa.config.server.application.OrchestratorMock;
import com.yahoo.vespa.config.server.http.HandlerTest;
import com.yahoo.vespa.config.server.http.HttpConfigRequest;
import com.yahoo.vespa.config.server.http.HttpErrorResponse;
import com.yahoo.vespa.config.server.http.SessionHandlerTest;
import com.yahoo.vespa.config.server.provision.HostProvisionerProvider;
import com.yahoo.vespa.config.server.session.PrepareParams;
import com.yahoo.vespa.config.server.tenant.TenantRepository;
import com.yahoo.vespa.config.server.tenant.TestTenantRepository;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import java.io.File;
import java.io.IOException;
import java.util.Collections;
import java.util.Map;
import static com.yahoo.jdisc.Response.Status.BAD_REQUEST;
import static com.yahoo.jdisc.Response.Status.NOT_FOUND;
import static com.yahoo.jdisc.http.HttpRequest.Method.GET;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
/**
* @author hmusum
*/
public class HttpGetConfigHandlerTest {
private static final TenantName tenant = TenantName.from("mytenant");
private static final ApplicationName applicationName = ApplicationName.from("myapplication");
private static final String expected =
"{\"port\":{\"telnet\":19098,\"rpc\":19097},\"application\":{\"tenant\":\"mytenant\",\"name\":\"myapplication\"";
private static final String baseUri = "http://yahoo.com:8080/config/v2/tenant/mytenant/application/myapplication/";
private static final String configUri = baseUri + "cloud.config.sentinel/hosts/localhost/sentinel";
private final static File testApp = new File("src/test/resources/deploy/validapp");
private static final ApplicationId applicationId = ApplicationId.from(tenant, applicationName, InstanceName.defaultName());
private HttpGetConfigHandler handler;
@Rule
public TemporaryFolder temporaryFolder = new TemporaryFolder();
@Before
public void setUp() throws IOException {
ConfigserverConfig configserverConfig = new ConfigserverConfig.Builder()
.configServerDBDir(temporaryFolder.newFolder().getAbsolutePath())
.configDefinitionsDir(temporaryFolder.newFolder().getAbsolutePath())
.fileReferencesDir(temporaryFolder.newFolder().getAbsolutePath())
.build();
TenantRepository tenantRepository = new TestTenantRepository.Builder()
.withConfigserverConfig(configserverConfig)
.withHostProvisionerProvider(HostProvisionerProvider.empty())
.build();
tenantRepository.addTenant(tenant);
ApplicationRepository applicationRepository = new ApplicationRepository.Builder()
.withTenantRepository(tenantRepository)
.withOrchestrator(new OrchestratorMock())
.withConfigserverConfig(configserverConfig)
.build();
handler = new HttpGetConfigHandler(HttpGetConfigHandler.testContext(), tenantRepository);
applicationRepository.deploy(testApp, prepareParams());
}
@Test
public void require_that_handler_can_be_created() throws IOException {
HttpResponse response = handler.handle(HttpRequest.createTestRequest(configUri, GET));
assertTrue(SessionHandlerTest.getRenderedString(response).startsWith(expected));
}
@Test
public void require_that_handler_can_handle_long_appid_request_with_configid() throws IOException {
String configUri = baseUri + "/environment/staging/region/myregion/instance/default/cloud.config.sentinel/hosts/localhost/sentinel";
HttpResponse response = handler.handle(HttpRequest.createTestRequest(configUri, GET));
String renderedString = SessionHandlerTest.getRenderedString(response);
assertTrue(renderedString, renderedString.startsWith(expected));
}
@Test
public void require_that_request_gets_correct_fields_with_full_appid() {
String uriLongAppId = "http://foo.com:8080/config/v2/tenant/bill/application/sookie/environment/dev/region/bellefleur/instance/sam/foo.bar/myid";
HttpRequest r = HttpRequest.createTestRequest(uriLongAppId, GET);
HttpConfigRequest req = HttpConfigRequest.createFromRequestV2(r);
assertEquals("bill", req.getApplicationId().tenant().value());
assertEquals("sookie", req.getApplicationId().application().value());
assertEquals("sam", req.getApplicationId().instance().value());
}
@Test
public void require_that_request_gets_correct_fields_with_short_appid() {
String uriShortAppId = "http://foo.com:8080/config/v2/tenant/jason/application/alcide/foo.bar/myid";
HttpRequest r = HttpRequest.createTestRequest(uriShortAppId, GET);
HttpConfigRequest req = HttpConfigRequest.createFromRequestV2(r);
assertEquals("jason", req.getApplicationId().tenant().value());
assertEquals("alcide", req.getApplicationId().application().value());
assertEquals("default", req.getApplicationId().instance().value());
}
@Test
public void require_correct_error_response() throws IOException {
String nonExistingConfigNameUri = baseUri + "nonexisting.config/myid";
String nonExistingConfigUri = baseUri + "cloud.config.sentinel/myid/nonexisting/id";
String illegalConfigNameUri = baseUri + "/foobar/myid";
HttpResponse response = handler.handle(HttpRequest.createTestRequest(nonExistingConfigNameUri, GET));
HandlerTest.assertHttpStatusCodeErrorCodeAndMessage(response, NOT_FOUND, HttpErrorResponse.ErrorCode.NOT_FOUND, "No such config: nonexisting.config");
assertTrue(SessionHandlerTest.getRenderedString(response).contains("No such config:"));
response = handler.handle(HttpRequest.createTestRequest(nonExistingConfigUri, GET));
HandlerTest.assertHttpStatusCodeErrorCodeAndMessage(response, NOT_FOUND, HttpErrorResponse.ErrorCode.NOT_FOUND, "No such config id: myid/nonexisting/id");
assertEquals(response.getContentType(), "application/json");
assertTrue(SessionHandlerTest.getRenderedString(response).contains("No such config id:"));
response = handler.handle(HttpRequest.createTestRequest(illegalConfigNameUri, GET));
HandlerTest.assertHttpStatusCodeErrorCodeAndMessage(response, BAD_REQUEST, HttpErrorResponse.ErrorCode.BAD_REQUEST, "Illegal config, must be of form namespace.name.");
}
@Test
public void require_that_nocache_property_works() throws IOException {
HttpRequest request = HttpRequest.createTestRequest(configUri, GET, null, Collections.singletonMap("nocache", "true"));
HttpResponse response = handler.handle(request);
String renderedString = SessionHandlerTest.getRenderedString(response);
assertTrue(renderedString, renderedString.startsWith(expected));
}
@Test
public void require_that_required_generation_property_works() throws IOException {
HttpRequest request = HttpRequest.createTestRequest(configUri, GET, null, Map.of("requiredGeneration", "2"));
HttpResponse response = handler.handle(request);
String renderedString = SessionHandlerTest.getRenderedString(response);
assertTrue(renderedString, renderedString.startsWith(expected));
request = HttpRequest.createTestRequest(configUri, GET, null, Map.of("requiredGeneration", "3"));
response = handler.handle(request);
assertEquals(412, response.getStatus());
renderedString = SessionHandlerTest.getRenderedString(response);
assertEquals("{\"error-code\":\"PRECONDITION_FAILED\",\"message\":\"Config for required generation 3 could not be found.\"}", renderedString);
}
private PrepareParams prepareParams() {
return new PrepareParams.Builder().applicationId(applicationId).build();
}
}
|
