aboutsummaryrefslogtreecommitdiffstats
path: root/container-core/src/test/java/com/yahoo/jdisc/http/server/jetty/FilterTestCase.java
blob: 59e9578372ddfb214f708d304fc081522a211e51 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.jdisc.http.server.jetty;

import com.google.inject.AbstractModule;
import com.google.inject.util.Modules;
import com.yahoo.container.jdisc.HttpRequestHandler;
import com.yahoo.container.jdisc.RequestHandlerSpec;
import com.yahoo.container.logging.ConnectionLog;
import com.yahoo.container.logging.RequestLog;
import com.yahoo.jdisc.AbstractResource;
import com.yahoo.jdisc.Request;
import com.yahoo.jdisc.ResourceReference;
import com.yahoo.jdisc.Response;
import com.yahoo.jdisc.handler.AbstractRequestHandler;
import com.yahoo.jdisc.handler.CompletionHandler;
import com.yahoo.jdisc.handler.ContentChannel;
import com.yahoo.jdisc.handler.DelegatedRequestHandler;
import com.yahoo.jdisc.handler.RequestHandler;
import com.yahoo.jdisc.handler.ResponseDispatch;
import com.yahoo.jdisc.handler.ResponseHandler;
import com.yahoo.jdisc.http.ConnectorConfig;
import com.yahoo.jdisc.http.HttpRequest;
import com.yahoo.jdisc.http.HttpResponse;
import com.yahoo.jdisc.http.ServerConfig;
import com.yahoo.jdisc.http.filter.RequestFilter;
import com.yahoo.jdisc.http.filter.ResponseFilter;
import com.yahoo.jdisc.http.filter.ResponseHeaderFilter;
import com.yahoo.jdisc.http.filter.chain.RequestFilterChain;
import com.yahoo.jdisc.http.filter.chain.ResponseFilterChain;
import com.yahoo.jdisc.http.server.jetty.testutils.ConnectorFactoryRegistryModule;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;

import java.io.IOException;
import java.nio.ByteBuffer;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicReference;

import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.isNull;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

/**
 * @author Oyvind Bakksjo
 * @author bjorncs
 */
public class FilterTestCase {
    @Test
    void requireThatRequestFilterIsNotRunOnUnboundPath() throws Exception {
        RequestFilterMockBase filter = mock(RequestFilterMockBase.class);
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", filter)
                .addRequestFilterBinding("my-request-filter", "http://*/filtered/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(filter, never()).filter(any(HttpRequest.class), any(ResponseHandler.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatRequestFilterIsRunOnBoundPath() throws Exception {
        final RequestFilter filter = mock(RequestFilterMockBase.class);
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", filter)
                .addRequestFilterBinding("my-request-filter", "http://*/filtered/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/filtered/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(filter, times(1)).filter(any(HttpRequest.class), any(ResponseHandler.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatRequestFilterChangesAreSeenByRequestHandler() throws Exception {
        final RequestFilter filter = new HeaderRequestFilter("foo", "bar");
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", filter)
                .addRequestFilterBinding("my-request-filter", "http://*/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        assertThat(requestHandler.getHeaderMap().get("foo").get(0), is("bar"));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatRequestFilterCanRespond() throws Exception {
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", new RespondForbiddenFilter())
                .addRequestFilterBinding("my-request-filter", "http://*/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html").expectStatusCode(is(Response.Status.FORBIDDEN));

        assertThat(requestHandler.hasBeenInvokedYet(), is(false));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatFilterCanHaveNullCompletionHandler() throws Exception {
        final int responseStatus = Response.Status.OK;
        final String responseMessage = "Excellent";
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", new NullCompletionHandlerFilter(responseStatus, responseMessage))
                .addRequestFilterBinding("my-request-filter", "http://*/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html")
                .expectStatusCode(is(responseStatus))
                .expectContent(is(responseMessage));

        assertThat(requestHandler.hasBeenInvokedYet(), is(false));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatRequestFilterExecutionIsExceptionSafe() throws Exception {
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", new ThrowingRequestFilter())
                .addRequestFilterBinding("my-request-filter", "http://*/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html").expectStatusCode(is(Response.Status.INTERNAL_SERVER_ERROR));

        assertThat(requestHandler.hasBeenInvokedYet(), is(false));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatResponseFilterIsNotRunOnUnboundPath() throws Exception {
        final ResponseFilter filter = mock(ResponseFilterMockBase.class);
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addResponseFilter("my-response-filter", filter)
                .addResponseFilterBinding("my-response-filter", "http://*/filtered/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(filter, never()).filter(any(Response.class), any(Request.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatResponseFilterIsRunOnBoundPath() throws Exception {
        final ResponseFilter filter = mock(ResponseFilterMockBase.class);
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addResponseFilter("my-response-filter", filter)
                .addResponseFilterBinding("my-response-filter", "http://*/filtered/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/filtered/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(filter, times(1)).filter(any(Response.class), any(Request.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatResponseFilterChangesAreWrittenToResponse() throws Exception {
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addResponseFilter("my-response-filter", new HeaderResponseFilter("foo", "bar"))
                .addResponseFilterBinding("my-response-filter", "http://*/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html")
                .expectHeader("foo", is("bar"));

        assertThat(requestHandler.awaitInvocation(), is(true));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatResponseFilterExecutionIsExceptionSafe() throws Exception {
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addResponseFilter("my-response-filter", new ThrowingResponseFilter())
                .addResponseFilterBinding("my-response-filter", "http://*/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html").expectStatusCode(is(Response.Status.INTERNAL_SERVER_ERROR));

        assertThat(requestHandler.awaitInvocation(), is(true));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatRequestFilterAndResponseFilterCanBindToSamePath() throws Exception {
        final RequestFilter requestFilter = mock(RequestFilterMockBase.class);
        final ResponseFilter responseFilter = mock(ResponseFilterMockBase.class);
        final String uriPattern = "http://*/*";
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", requestFilter)
                .addRequestFilterBinding("my-request-filter", uriPattern)
                .addResponseFilter("my-response-filter", responseFilter)
                .addResponseFilterBinding("my-response-filter", uriPattern)
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(requestFilter, times(1)).filter(any(HttpRequest.class), any(ResponseHandler.class));
        verify(responseFilter, times(1)).filter(any(Response.class), any(Request.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatResponseFromRequestFilterGoesThroughResponseFilter() throws Exception {
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", new RespondForbiddenFilter())
                .addRequestFilterBinding("my-request-filter", "http://*/*")
                .addResponseFilter("my-response-filter", new HeaderResponseFilter("foo", "bar"))
                .addResponseFilterBinding("my-response-filter", "http://*/*")
                .build();
        final MyRequestHandler requestHandler = new MyRequestHandler();
        final JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html")
                .expectStatusCode(is(Response.Status.FORBIDDEN))
                .expectHeader("foo", is("bar"));

        assertThat(requestHandler.hasBeenInvokedYet(), is(false));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatRequestFilterChainRetainsFilters() {
        final RequestFilter requestFilter1 = mock(RequestFilter.class);
        final RequestFilter requestFilter2 = mock(RequestFilter.class);

        final ResourceReference reference1 = mock(ResourceReference.class);
        final ResourceReference reference2 = mock(ResourceReference.class);
        when(requestFilter1.refer(any())).thenReturn(reference1);
        when(requestFilter2.refer(any())).thenReturn(reference2);
        final RequestFilter chain = RequestFilterChain.newInstance(requestFilter1, requestFilter2);
        verify(requestFilter1, times(1)).refer(any());
        verify(requestFilter2, times(1)).refer(any());

        verify(reference1, never()).close();
        verify(reference2, never()).close();
        chain.release();
        verify(reference1, times(1)).close();
        verify(reference2, times(1)).close();
    }

    @Test
    void requireThatRequestFilterChainIsRun() throws Exception {
        final RequestFilter requestFilter1 = mock(RequestFilter.class);
        final RequestFilter requestFilter2 = mock(RequestFilter.class);
        final RequestFilter requestFilterChain = RequestFilterChain.newInstance(requestFilter1, requestFilter2);
        final HttpRequest request = null;
        final ResponseHandler responseHandler = null;
        requestFilterChain.filter(request, responseHandler);
        verify(requestFilter1).filter(isNull(), any(ResponseHandler.class));
        verify(requestFilter2).filter(isNull(), any(ResponseHandler.class));
    }

    @Test
    void requireThatRequestFilterChainCallsFilterWithOriginalRequest() throws Exception {
        final RequestFilter requestFilter = mock(RequestFilter.class);
        final RequestFilter requestFilterChain = RequestFilterChain.newInstance(requestFilter);
        final HttpRequest request = mock(HttpRequest.class);
        final ResponseHandler responseHandler = null;
        requestFilterChain.filter(request, responseHandler);

        // Check that the filter is called with the same request argument as the chain was,
        // in a manner that allows the request object to be wrapped.
        final ArgumentCaptor<HttpRequest> requestCaptor = ArgumentCaptor.forClass(HttpRequest.class);
        verify(requestFilter).filter(requestCaptor.capture(), isNull());
        verify(request, never()).getUri();
        requestCaptor.getValue().getUri();
        verify(request, times(1)).getUri();
    }

    @Test
    void requireThatRequestFilterChainCallsFilterWithOriginalResponseHandler() throws Exception {
        final RequestFilter requestFilter = mock(RequestFilter.class);
        final RequestFilter requestFilterChain = RequestFilterChain.newInstance(requestFilter);
        final HttpRequest request = null;
        final ResponseHandler responseHandler = mock(ResponseHandler.class);
        requestFilterChain.filter(request, responseHandler);

        // Check that the filter is called with the same response handler argument as the chain was,
        // in a manner that allows the handler object to be wrapped.
        final ArgumentCaptor<ResponseHandler> responseHandlerCaptor = ArgumentCaptor.forClass(ResponseHandler.class);
        verify(requestFilter).filter(isNull(), responseHandlerCaptor.capture());
        verify(responseHandler, never()).handleResponse(any(Response.class));
        responseHandlerCaptor.getValue().handleResponse(mock(Response.class));
        verify(responseHandler, times(1)).handleResponse(any(Response.class));
    }

    @Test
    void requireThatRequestFilterCanTerminateChain() throws Exception {
        final RequestFilter requestFilter1 = new RespondForbiddenFilter();
        final RequestFilter requestFilter2 = mock(RequestFilter.class);
        final RequestFilter requestFilterChain = RequestFilterChain.newInstance(requestFilter1, requestFilter2);
        final HttpRequest request = null;
        final ResponseHandler responseHandler = mock(ResponseHandler.class);
        when(responseHandler.handleResponse(any(Response.class))).thenReturn(mock(ContentChannel.class));

        requestFilterChain.filter(request, responseHandler);

        verify(requestFilter2, never()).filter(any(HttpRequest.class), any(ResponseHandler.class));

        final ArgumentCaptor<Response> responseCaptor = ArgumentCaptor.forClass(Response.class);
        verify(responseHandler).handleResponse(responseCaptor.capture());
        assertThat(responseCaptor.getValue().getStatus(), is(Response.Status.FORBIDDEN));
    }

    @Test
    void requireThatResponseFilterChainRetainsFilters() {
        final ResponseFilter responseFilter1 = mock(ResponseFilter.class);
        final ResponseFilter responseFilter2 = mock(ResponseFilter.class);

        final ResourceReference reference1 = mock(ResourceReference.class);
        final ResourceReference reference2 = mock(ResourceReference.class);
        when(responseFilter1.refer(any())).thenReturn(reference1);
        when(responseFilter2.refer(any())).thenReturn(reference2);
        final ResponseFilter chain = ResponseFilterChain.newInstance(responseFilter1, responseFilter2);
        verify(responseFilter1, times(1)).refer(any());
        verify(responseFilter2, times(1)).refer(any());

        verify(reference1, never()).close();
        verify(reference2, never()).close();
        chain.release();
        verify(reference1, times(1)).close();
        verify(reference2, times(1)).close();
    }

    @Test
    void requireThatResponseFilterChainIsRun() {
        final ResponseFilter responseFilter1 = new ResponseHeaderFilter("foo", "bar");
        final ResponseFilter responseFilter2 = mock(ResponseFilter.class);
        final int statusCode = Response.Status.BAD_GATEWAY;
        final Response response = new Response(statusCode);
        final Request request = null;

        ResponseFilterChain.newInstance(responseFilter1, responseFilter2).filter(response, request);

        final ArgumentCaptor<Response> responseCaptor = ArgumentCaptor.forClass(Response.class);
        verify(responseFilter2).filter(responseCaptor.capture(), isNull());
        assertThat(responseCaptor.getValue().getStatus(), is(statusCode));
        assertThat(responseCaptor.getValue().headers().getFirst("foo"), is("bar"));

        assertThat(response.getStatus(), is(statusCode));
        assertThat(response.headers().getFirst("foo"), is("bar"));
    }

    @Test
    void requireThatDefaultRequestFilterChainIsRunIfNoOtherFilterChainMatches() throws IOException, InterruptedException {
        RequestFilter filterWithBinding = mock(RequestFilter.class);
        RequestFilter defaultFilter = mock(RequestFilter.class);
        String defaultFilterId = "default-request-filter";
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", filterWithBinding)
                .addRequestFilterBinding("my-request-filter", "http://*/filtered/*")
                .addRequestFilter(defaultFilterId, defaultFilter)
                .setRequestFilterDefaultForPort(defaultFilterId, 0)
                .build();
        MyRequestHandler requestHandler = new MyRequestHandler();
        JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(defaultFilter, times(1)).filter(any(HttpRequest.class), any(ResponseHandler.class));
        verify(filterWithBinding, never()).filter(any(HttpRequest.class), any(ResponseHandler.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatDefaultResponseFilterChainIsRunIfNoOtherFilterChainMatches() throws IOException, InterruptedException {
        ResponseFilter filterWithBinding = mock(ResponseFilter.class);
        ResponseFilter defaultFilter = mock(ResponseFilter.class);
        String defaultFilterId = "default-response-filter";
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addResponseFilter("my-response-filter", filterWithBinding)
                .addResponseFilterBinding("my-response-filter", "http://*/filtered/*")
                .addResponseFilter(defaultFilterId, defaultFilter)
                .setResponseFilterDefaultForPort(defaultFilterId, 0)
                .build();
        MyRequestHandler requestHandler = new MyRequestHandler();
        JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(defaultFilter, times(1)).filter(any(Response.class), any(Request.class));
        verify(filterWithBinding, never()).filter(any(Response.class), any(Request.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatRequestFilterWithBindingMatchHasPrecedenceOverDefaultFilter() throws IOException, InterruptedException {
        RequestFilterMockBase filterWithBinding = mock(RequestFilterMockBase.class);
        RequestFilterMockBase defaultFilter = mock(RequestFilterMockBase.class);
        String defaultFilterId = "default-request-filter";
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", filterWithBinding)
                .addRequestFilterBinding("my-request-filter", "http://*/filtered/*")
                .addRequestFilter(defaultFilterId, defaultFilter)
                .setRequestFilterDefaultForPort(defaultFilterId, 0)
                .build();
        MyRequestHandler requestHandler = new MyRequestHandler();
        JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/filtered/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(defaultFilter, never()).filter(any(HttpRequest.class), any(ResponseHandler.class));
        verify(filterWithBinding).filter(any(HttpRequest.class), any(ResponseHandler.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatResponseFilterWithBindingMatchHasPrecedenceOverDefaultFilter() throws IOException, InterruptedException {
        ResponseFilter filterWithBinding = mock(ResponseFilter.class);
        ResponseFilter defaultFilter = mock(ResponseFilter.class);
        String defaultFilterId = "default-response-filter";
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addResponseFilter("my-response-filter", filterWithBinding)
                .addResponseFilterBinding("my-response-filter", "http://*/filtered/*")
                .addResponseFilter(defaultFilterId, defaultFilter)
                .setResponseFilterDefaultForPort(defaultFilterId, 0)
                .build();
        MyRequestHandler requestHandler = new MyRequestHandler();
        JettyTestDriver testDriver = newDriver(requestHandler, filterBindings);

        testDriver.client().get("/filtered/status.html");

        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(defaultFilter, never()).filter(any(Response.class), any(Request.class));
        verify(filterWithBinding, times(1)).filter(any(Response.class), any(Request.class));

        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatMetricAreReported() throws IOException, InterruptedException {
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", mock(RequestFilter.class))
                .addRequestFilterBinding("my-request-filter", "http://*/*")
                .build();
        MetricConsumerMock metricConsumerMock = new MetricConsumerMock();
        MyRequestHandler requestHandler = new MyRequestHandler();
        JettyTestDriver testDriver = newDriver(requestHandler, filterBindings, metricConsumerMock);

        testDriver.client().get("/status.html");
        assertThat(requestHandler.awaitInvocation(), is(true));
        verify(metricConsumerMock.mockitoMock())
                .add(MetricDefinitions.FILTERING_REQUEST_HANDLED, 1L, MetricConsumerMock.STATIC_CONTEXT);
        verify(metricConsumerMock.mockitoMock(), never())
                .add(MetricDefinitions.FILTERING_REQUEST_UNHANDLED, 1L, MetricConsumerMock.STATIC_CONTEXT);
        verify(metricConsumerMock.mockitoMock(), never())
                .add(MetricDefinitions.FILTERING_RESPONSE_HANDLED, 1L, MetricConsumerMock.STATIC_CONTEXT);
        verify(metricConsumerMock.mockitoMock())
                .add(MetricDefinitions.FILTERING_RESPONSE_UNHANDLED, 1L, MetricConsumerMock.STATIC_CONTEXT);
        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatStrictFilteringRejectsRequestsNotMatchingFilterChains() throws IOException {
        RequestFilter filter = mock(RequestFilter.class);
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", filter)
                .addRequestFilterBinding("my-request-filter", "http://*/filtered/*")
                .setStrictFiltering(true)
                .build();
        MyRequestHandler requestHandler = new MyRequestHandler();
        JettyTestDriver testDriver = newDriver(requestHandler, filterBindings, new MetricConsumerMock());

        testDriver.client().get("/unfiltered/")
                .expectStatusCode(is(Response.Status.FORBIDDEN))
                .expectContent(containsString("Request did not match any request filter chain"));
        verify(filter, never()).filter(any(), any());
        assertThat(testDriver.close(), is(true));
    }

    @Test
    void requireThatRequestHandlerSpecIsAvailableThroughDelegate() throws IOException, InterruptedException {
        MyRequestHandler requestHandler = new MyHttpRequestHandler();
        MyDelegatedHandler delegateHandler1 = new MyDelegatedHandler(requestHandler);
        MyDelegatedHandler delegateHandler2 = new MyDelegatedHandler(delegateHandler1);
        requestHandlerSpecTest(delegateHandler2);
    }

    @Test
    void requireThatRequestHandlerSpecIsAvailable() throws IOException, InterruptedException {
        MyRequestHandler requestHandler = new MyHttpRequestHandler();
        requestHandlerSpecTest(requestHandler);
    }

    private void requestHandlerSpecTest(MyRequestHandler requestHandler) throws IOException, InterruptedException {
        RequestFilter filter = mock(RequestFilter.class);
        FilterBindings filterBindings = new FilterBindings.Builder()
                .addRequestFilter("my-request-filter", filter)
                .addRequestFilterBinding("my-request-filter", "http://*/filtered/*")
                .build();

        JettyTestDriver testDriver = newDriver(requestHandler, filterBindings, new MetricConsumerMock());

        testDriver.client().get("/filtered/")
                .expectStatusCode(is(Response.Status.OK));
        ArgumentCaptor<HttpRequest> requestArgumentCaptor = ArgumentCaptor.forClass(HttpRequest.class);
        verify(filter).filter(requestArgumentCaptor.capture(), any(ResponseHandler.class));
        assertTrue(requestArgumentCaptor.getValue().context().containsKey(RequestHandlerSpec.ATTRIBUTE_NAME));
    }

    private static JettyTestDriver newDriver(MyRequestHandler requestHandler, FilterBindings filterBindings) {
        return newDriver(requestHandler, filterBindings, new MetricConsumerMock());
    }

    private static JettyTestDriver newDriver(
            MyRequestHandler requestHandler,
            FilterBindings filterBindings,
            MetricConsumerMock metricConsumer) {
        return JettyTestDriver.newInstance(
                requestHandler,
                newFilterModule(filterBindings, metricConsumer));
    }

    private static com.google.inject.Module newFilterModule(
            FilterBindings filterBindings, MetricConsumerMock metricConsumer) {
        return Modules.combine(
                new AbstractModule() {
                    @Override
                    protected void configure() {

                        bind(FilterBindings.class).toInstance(filterBindings);
                        bind(ServerConfig.class).toInstance(new ServerConfig(new ServerConfig.Builder()));
                        bind(ConnectorConfig.class).toInstance(new ConnectorConfig(new ConnectorConfig.Builder()));
                        bind(ConnectionLog.class).toInstance(new VoidConnectionLog());
                        bind(RequestLog.class).toInstance(new VoidRequestLog());
                    }
                },
                new ConnectorFactoryRegistryModule(),
                metricConsumer.asGuiceModule());
    }

    private static abstract class RequestFilterMockBase extends AbstractResource implements RequestFilter {}
    private static abstract class ResponseFilterMockBase extends AbstractResource implements ResponseFilter {}

    private static class MyRequestHandler extends AbstractRequestHandler {
        private final CountDownLatch invocationLatch = new CountDownLatch(1);
        private final AtomicReference<Map<String, List<String>>> headerCopy = new AtomicReference<>(null);

        @Override
        public ContentChannel handleRequest(final Request request, final ResponseHandler handler) {
            try {
                headerCopy.set(new HashMap<>(request.headers()));
                ResponseDispatch.newInstance(Response.Status.OK).dispatch(handler);
                return null;
            } finally {
                invocationLatch.countDown();
            }
        }

        public boolean hasBeenInvokedYet() {
            return invocationLatch.getCount() == 0L;
        }

        public boolean awaitInvocation() throws InterruptedException {
            return invocationLatch.await(60, TimeUnit.SECONDS);
        }

        public Map<String, List<String>> getHeaderMap() {
            return headerCopy.get();
        }
    }

    private static class RespondForbiddenFilter extends AbstractResource implements RequestFilter {
        @Override
        public void filter(final HttpRequest request, final ResponseHandler handler) {
            ResponseDispatch.newInstance(Response.Status.FORBIDDEN).dispatch(handler);
        }
    }

    private static class ThrowingRequestFilter extends AbstractResource implements RequestFilter {
        @Override
        public void filter(final HttpRequest request, final ResponseHandler handler) {
            throw new RuntimeException();
        }
    }

    private static class ThrowingResponseFilter extends AbstractResource implements ResponseFilter {
        @Override
        public void filter(final Response response, final Request request) {
            throw new RuntimeException();
        }
    }

    private static class HeaderRequestFilter extends AbstractResource implements RequestFilter {
        private final String key;
        private final String val;

        public HeaderRequestFilter(final String key, final String val) {
            this.key = key;
            this.val = val;
        }

        @Override
        public void filter(final HttpRequest request, final ResponseHandler handler) {
            request.headers().add(key, val);
        }
    }

    private static class HeaderResponseFilter extends AbstractResource implements ResponseFilter {
        private final String key;
        private final String val;

        public HeaderResponseFilter(final String key, final String val) {
            this.key = key;
            this.val = val;
        }

        @Override
        public void filter(final Response response, final Request request) {
            response.headers().add(key, val);
        }
    }

    public class NullCompletionHandlerFilter extends AbstractResource implements RequestFilter {
        private final int responseStatus;
        private final String responseMessage;

        public NullCompletionHandlerFilter(final int responseStatus, final String responseMessage) {
            this.responseStatus = responseStatus;
            this.responseMessage = responseMessage;
        }

        @Override
        public void filter(final HttpRequest request, final ResponseHandler responseHandler) {
            final HttpResponse response = HttpResponse.newInstance(responseStatus);
            final ContentChannel channel = responseHandler.handleResponse(response);
            final CompletionHandler completionHandler = null;
            channel.write(ByteBuffer.wrap(responseMessage.getBytes()), completionHandler);
            channel.close(null);
        }
    }

    private static class MyDelegatedHandler extends MyRequestHandler implements DelegatedRequestHandler {

        private final RequestHandler delegate;

        public MyDelegatedHandler(RequestHandler delegate) {
            this.delegate = delegate;
        }

        @Override
        public RequestHandler getDelegate() {
            return delegate;
        }
        @Override
        public ContentChannel handleRequest(Request request, ResponseHandler handler) {
            return delegate.handleRequest(request, handler);
        }
        @Override
        public void handleTimeout(Request request, ResponseHandler handler) {
            delegate.handleTimeout(request, handler);
        }
    }

    private static class MyHttpRequestHandler extends MyRequestHandler implements HttpRequestHandler {
        @Override
        public RequestHandlerSpec requestHandlerSpec() {
            return RequestHandlerSpec.DEFAULT_INSTANCE;
        }
    }
}