1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.container.jdisc;
import com.yahoo.component.ComponentId;
import com.yahoo.component.provider.ComponentRegistry;
import com.yahoo.container.core.ChainsConfig;
import com.yahoo.container.http.filter.FilterChainRepository;
import com.yahoo.jdisc.http.ServerConfig;
import com.yahoo.jdisc.http.filter.RequestFilter;
import com.yahoo.jdisc.http.filter.ResponseFilter;
import com.yahoo.jdisc.http.server.jetty.FilterBindings;
import org.junit.jupiter.api.Test;
import java.util.Set;
import java.util.stream.Collectors;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;
import static org.mockito.Mockito.mock;
/**
* @author Oyvind Bakksjo
* @author bjorncs
*/
public class FilterBindingsProviderTest {
final ServerConfig.Builder configBuilder = new ServerConfig.Builder();
@Test
void requireThatEmptyInputGivesEmptyOutput() {
final FilterChainRepository filterChainRepository = new FilterChainRepository(
new ChainsConfig(new ChainsConfig.Builder()),
new ComponentRegistry<>(),
new ComponentRegistry<>(),
new ComponentRegistry<>(),
new ComponentRegistry<>());
final FilterBindingsProvider provider = new FilterBindingsProvider(
new ComponentId("foo"),
new ServerConfig(configBuilder),
filterChainRepository,
new ComponentRegistry<>());
final FilterBindings filterBindings = provider.get();
assertNotNull(filterBindings);
assertTrue(filterBindings.requestFilterIds().isEmpty());
assertTrue(filterBindings.responseFilterIds().isEmpty());
}
@Test
void requireThatCorrectlyConfiguredFiltersAreIncluded() {
final String requestFilter1Id = "requestFilter1";
final String requestFilter2Id = "requestFilter2";
final String requestFilter3Id = "requestFilter3";
final String responseFilter1Id = "responseFilter1";
final String responseFilter2Id = "responseFilter2";
final String responseFilter3Id = "responseFilter3";
// Set up config.
configBuilder.filter(new ServerConfig.Filter.Builder().id(requestFilter1Id).binding("http://*/a"));
configBuilder.filter(new ServerConfig.Filter.Builder().id(requestFilter2Id).binding("http://*/b"));
configBuilder.filter(new ServerConfig.Filter.Builder().id(responseFilter1Id).binding("http://*/c"));
configBuilder.filter(new ServerConfig.Filter.Builder().id(responseFilter3Id).binding("http://*/d"));
// Set up registry.
final ComponentRegistry<RequestFilter> availableRequestFilters = new ComponentRegistry<>();
final RequestFilter requestFilter1Instance = mock(RequestFilter.class);
final RequestFilter requestFilter2Instance = mock(RequestFilter.class);
final RequestFilter requestFilter3Instance = mock(RequestFilter.class);
availableRequestFilters.register(ComponentId.fromString(requestFilter1Id), requestFilter1Instance);
availableRequestFilters.register(ComponentId.fromString(requestFilter2Id), requestFilter2Instance);
availableRequestFilters.register(ComponentId.fromString(requestFilter3Id), requestFilter3Instance);
final ComponentRegistry<ResponseFilter> availableResponseFilters = new ComponentRegistry<>();
final ResponseFilter responseFilter1Instance = mock(ResponseFilter.class);
final ResponseFilter responseFilter2Instance = mock(ResponseFilter.class);
final ResponseFilter responseFilter3Instance = mock(ResponseFilter.class);
availableResponseFilters.register(ComponentId.fromString(responseFilter1Id), responseFilter1Instance);
availableResponseFilters.register(ComponentId.fromString(responseFilter2Id), responseFilter2Instance);
availableResponseFilters.register(ComponentId.fromString(responseFilter3Id), responseFilter3Instance);
final FilterChainRepository filterChainRepository = new FilterChainRepository(
new ChainsConfig(new ChainsConfig.Builder()),
availableRequestFilters,
availableResponseFilters,
new ComponentRegistry<>(),
new ComponentRegistry<>());
// Set up the provider that we aim to test.
final FilterBindingsProvider provider = new FilterBindingsProvider(
new ComponentId("foo"),
new ServerConfig(configBuilder),
filterChainRepository,
new ComponentRegistry<>());
// Execute.
final FilterBindings filterBindings = provider.get();
// Verify.
assertNotNull(filterBindings);
assertEquals(filterBindings.requestFilters().stream().collect(Collectors.toSet()),
Set.of(requestFilter1Instance, requestFilter2Instance));
assertEquals(filterBindings.responseFilters().stream().collect(Collectors.toSet()),
Set.of(responseFilter1Instance, responseFilter3Instance));
}
private interface DualRoleFilter extends RequestFilter, ResponseFilter {}
@Test
void requireThatInstanceCanNotBeBothRequestAndResponseFilter() {
final String filterId = "filter";
// Set up config.
configBuilder.filter(new ServerConfig.Filter.Builder().id(filterId).binding("http://*/*"));
// Set up registry.
final DualRoleFilter filterInstance = mock(DualRoleFilter.class);
final ComponentRegistry<RequestFilter> availableRequestFilters = new ComponentRegistry<>();
availableRequestFilters.register(ComponentId.fromString(filterId), filterInstance);
final FilterChainRepository filterChainRepository = new FilterChainRepository(
new ChainsConfig(new ChainsConfig.Builder()),
availableRequestFilters,
new ComponentRegistry<>(),
new ComponentRegistry<>(),
new ComponentRegistry<>());
try {
new FilterBindingsProvider(
new ComponentId("foo"),
new ServerConfig(configBuilder),
filterChainRepository,
new ComponentRegistry<>());
fail("Dual-role filter should not be accepted");
} catch (RuntimeException e) {
assertTrue(e.getMessage().contains("Invalid config"));
}
}
@Test
void requireThatConfigWithUnknownReferenceFails() {
// Set up config.
configBuilder.filter(new ServerConfig.Filter.Builder().id("someFilter").binding("http://*/*"));
// Set up registry.
final FilterChainRepository filterChainRepository = new FilterChainRepository(
new ChainsConfig(new ChainsConfig.Builder()),
new ComponentRegistry<>(),
new ComponentRegistry<>(),
new ComponentRegistry<>(),
new ComponentRegistry<>());
try {
new FilterBindingsProvider(
new ComponentId("foo"),
new ServerConfig(configBuilder),
filterChainRepository,
new ComponentRegistry<>());
fail("Config with unknown filter reference should not be accepted");
} catch (RuntimeException e) {
assertTrue(e.getMessage().contains("Invalid config"));
}
}
}
|
