aboutsummaryrefslogtreecommitdiffstats
path: root/container-search/src/test/java/com/yahoo/prelude/query/test/QueryCanonicalizerTestCase.java
blob: d14697da981ec0f2f12f59727ca349084b42c44c (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.prelude.query.test;

import com.yahoo.prelude.query.*;
import com.yahoo.search.Query;
import com.yahoo.search.query.QueryTree;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;

/**
 * @author bratseth
 */
public class QueryCanonicalizerTestCase {

    @Test
    void testSingleLevelSingleItemComposite() {
        CompositeItem root = new AndItem();

        root.addItem(new WordItem("word"));
        assertCanonicalized("word", null, root);
    }

    @Test
    void testSingleLevelSingleItemNonReducibleComposite() {
        CompositeItem root = new WeakAndItem();

        root.addItem(new WordItem("word"));
        assertCanonicalized("WEAKAND(100) word", null, root);
    }

    @Test
    void testMultilevelSingleItemComposite() {
        CompositeItem root = new AndItem();
        CompositeItem and1 = new AndItem();
        CompositeItem and2 = new AndItem();

        root.addItem(and1);
        and1.addItem(and2);
        and2.addItem(new WordItem("word"));
        assertCanonicalized("word", null, root);
    }

    @Test
    void testMultilevelComposite() {
        // AND (RANK (AND a b c)) WAND(25,0.0,1.0)
        AndItem and = new AndItem();
        RankItem rank = new RankItem();
        and.addItem(rank);
        AndItem nestedAnd = new AndItem();
        nestedAnd.addItem(new WordItem("a"));
        nestedAnd.addItem(new WordItem("b"));
        nestedAnd.addItem(new WordItem("c"));
        rank.addItem(nestedAnd);
        WandItem wand = new WandItem("default", 100);
        and.addItem(wand);

        assertCanonicalized("AND a b c WAND(100,0.0,1.0) default}", null, and);
    }

    @Test
    void testMultilevelEmptyComposite() {
        CompositeItem root = new AndItem();
        CompositeItem and1 = new AndItem();
        CompositeItem and2 = new AndItem();

        root.addItem(and1);
        and1.addItem(and2);
        assertCanonicalized(null, "No query", new Query());
    }

    @Test
    void testMultilevelMultiBranchEmptyComposite() {
        CompositeItem root = new AndItem();
        CompositeItem and1 = new AndItem();
        CompositeItem and21 = new AndItem();
        CompositeItem and22 = new AndItem();
        CompositeItem and31 = new AndItem();
        CompositeItem and32 = new AndItem();

        root.addItem(and1);
        and1.addItem(and21);
        and1.addItem(and22);
        and22.addItem(and31);
        and22.addItem(and32);
        assertCanonicalized(null, "No query", new Query());
    }

    @Test
    void testMultilevelMultiBranchSingleItemComposite() {
        CompositeItem root = new AndItem();
        CompositeItem and1 = new AndItem();
        CompositeItem and21 = new AndItem();
        CompositeItem and22 = new AndItem();
        CompositeItem and31 = new AndItem();
        CompositeItem and32 = new AndItem();

        root.addItem(and1);
        and1.addItem(and21);
        and1.addItem(and22);
        and22.addItem(and31);
        and22.addItem(and32);
        and22.addItem(new WordItem("word"));
        assertCanonicalized("word", null, new Query("?query=word&type=all"));
    }

    @Test
    void testMultilevelWeakAndCollapsing() {
        CompositeItem root = new WeakAndItem();
        CompositeItem l1 = new WeakAndItem();
        CompositeItem l2 = new WeakAndItem();
        CompositeItem l3 = new WeakAndItem();
        CompositeItem l4 = new WeakAndItem();

        root.addItem(l1);

        l1.addItem(l2);
        l1.addItem(new WordItem("l1"));

        l2.addItem(l3);
        l2.addItem(new WordItem("l2"));

        l3.addItem(l4);
        l3.addItem(new WordItem("l3"));

        l4.addItem(new WordItem("l4"));

        assertCanonicalized("WEAKAND(100) l4 l3 l2 l1", null, root);
    }

    @Test
    void testWeakAndCollapsingRequireSameNAndIndex() {
        CompositeItem root = new WeakAndItem(10);
        CompositeItem l1 = new WeakAndItem(100);
        CompositeItem l2 = new WeakAndItem(100);
        l2.setIndexName("other");

        root.addItem(l1);

        l1.addItem(l2);
        l1.addItem(new WordItem("l1"));

        l2.addItem(new WordItem("l2"));

        assertCanonicalized("WEAKAND(10) (WEAKAND(100) (WEAKAND(100) l2) l1)", null, root);
    }

    @Test
    void testNullRoot() {
        assertCanonicalized(null, "No query", new Query());
    }

    @Test
    void testNestedNull() {
        CompositeItem root = new AndItem();
        CompositeItem or = new AndItem();
        CompositeItem and = new AndItem();

        root.addItem(or);
        or.addItem(and);
        Query query = new Query();

        query.getModel().getQueryTree().setRoot(root);

        assertCanonicalized(null, "No query", root);
    }

    @Test
    void testNestedNullItem() {
        CompositeItem root = new AndItem();
        CompositeItem or = new AndItem();
        CompositeItem and = new AndItem();
        and.addItem(new NullItem());
        and.addItem(new NullItem());

        root.addItem(or);
        or.addItem(and);
        Query query = new Query();

        query.getModel().getQueryTree().setRoot(root);

        assertCanonicalized(null, "No query", root);
    }

    @Test
    void testNestedNullAndSingle() {
        CompositeItem root = new AndItem();
        CompositeItem or = new OrItem();

        root.addItem(or);
        CompositeItem and = new AndItem();

        or.addItem(and);
        or.addItem(new WordItem("word"));
        assertCanonicalized("word", null, root);
    }

    @Test
    void testRemovalOfUnnecessaryComposites() {
        CompositeItem root = new AndItem();
        CompositeItem or = new OrItem();

        root.addItem(or);
        CompositeItem and = new AndItem();

        or.addItem(new WordItem("word1"));
        or.addItem(and);
        or.addItem(new WordItem("word2"));
        or.addItem(new WordItem("word3"));
        assertCanonicalized("OR word1 word2 word3", null, root);
    }

    /** Multiple levels of the same AND/OR should collapse */
    @Test
    void testMultilevelCollapsing() {
        CompositeItem root = new AndItem();
        CompositeItem l1 = new AndItem();
        CompositeItem l2 = new AndItem();
        CompositeItem l3 = new AndItem();

        root.addItem(l1);

        l1.addItem(new WordItem("l1i1"));
        l1.addItem(l2);

        l2.addItem(new WordItem("l2i1"));
        l2.addItem(l3);
        l2.addItem(new WordItem("l2i2"));

        l3.addItem(new WordItem("l3i1"));
        l3.addItem(new WordItem("l3i2"));

        assertCanonicalized("AND l1i1 l2i1 l3i1 l3i2 l2i2", null, root);
    }

    /** Multiple levels of different composites should not collapse */
    @Test
    void testMultilevelNonCollapsing() {
        CompositeItem root = new AndItem();
        CompositeItem l1 = new AndItem();
        CompositeItem l2 = new OrItem();
        CompositeItem l3 = new AndItem();

        root.addItem(l1);

        l1.addItem(new WordItem("l1i1"));
        l1.addItem(l2);

        l2.addItem(new WordItem("l2i1"));
        l2.addItem(l3);

        l3.addItem(new WordItem("l3i1"));

        assertCanonicalized("AND l1i1 (OR l2i1 l3i1)", null, root);
    }

    /** Multiple levels of RANK should collapse */
    @Test
    void testMultilevelRankCollapsing() {
        CompositeItem root = new RankItem();
        CompositeItem l1 = new RankItem();
        CompositeItem l2 = new RankItem();
        CompositeItem l3 = new RankItem();
        CompositeItem l4 = new RankItem();

        root.addItem(l1);

        l1.addItem(l2);
        l1.addItem(new WordItem("l1"));

        l2.addItem(l3);
        l2.addItem(new WordItem("l2"));

        l3.addItem(l4);
        l3.addItem(new WordItem("l3"));

        l4.addItem(new WordItem("l4"));

        assertCanonicalized("RANK l4 l3 l2 l1", null, root);
    }

    @Test
    void testNegativeMustHaveNegatives() {
        CompositeItem root = new NotItem();

        root.addItem(new WordItem("positive"));
        assertCanonicalized("positive", null, root);
    }

    @Test
    void testNegative() {
        NotItem root = new NotItem();

        root.addNegativeItem(new WordItem("negative"));
        assertCanonicalized("-negative", null, root);
    }

    @Test
    void testNegativeOnly() {
        CompositeItem root = new AndItem();
        NotItem not = new NotItem();

        root.addItem(not);
        root.addItem(new WordItem("word"));
        not.addNegativeItem(new WordItem("negative"));
        assertCanonicalized("AND (-negative) word", null, root);
    }

    @Test
    void testCollapseFalseItemInAnd() {
        CompositeItem root = new AndItem();
        root.addItem(new WordItem("i1"));
        root.addItem(new FalseItem());
        assertCanonicalized("FALSE", null, root);
    }

    @Test
    void testRemoveFalseItemInOr() {
        CompositeItem root = new OrItem();
        AndItem and = new AndItem(); // this gets collapse to just FALSE, which is then removed
        root.addItem(and);
        and.addItem(new WordItem("i1"));
        and.addItem(new FalseItem());
        root.addItem(new WordItem("i1")); // ... which causes the OR to collapse, leaving this
        assertCanonicalized("i1", null, root);
    }

    @Test
    void testCollapseFalseItemInNot() {
        CompositeItem root = new NotItem();
        root.addItem(new FalseItem()); // false ANDNOT ... is false
        root.addItem(new WordItem("i1"));
        assertCanonicalized("FALSE", null, root);
    }

    @Test
    void testRemoveFalseItemInNot() {
        CompositeItem root = new NotItem();
        root.addItem(new WordItem("i1"));
        root.addItem(new FalseItem()); // ... ANDNOT false is redundant
        assertCanonicalized("i1", null, root);
    }

    @Test
    void testCollapseFalseItemInRank() {
        CompositeItem root = new RankItem();
        root.addItem(new FalseItem()); // false RANK ... is false
        root.addItem(new WordItem("i1"));
        assertCanonicalized("FALSE", null, root);
    }

    @Test
    void testRemoveFalseItemInRank() {
        CompositeItem root = new RankItem();
        root.addItem(new WordItem("i1"));
        root.addItem(new FalseItem()); // ... RANK false is redundant
        assertCanonicalized("i1", null, root);
    }

    /**
     * Tests that connexity is preserved by cloning and transferred to rank properties by preparing the query
     * (which strictly is an implementation detail which we should rather hide).
     */
    @Test
    void testConnexityAndCloning() {
        Query q = new Query("?query=a%20b");
        CompositeItem root = (CompositeItem) q.getModel().getQueryTree().getRoot();
        ((WordItem) root.getItem(0)).setConnectivity(root.getItem(1), java.lang.Math.E);
        q = q.clone();

        assertNull(q.getRanking().getProperties().get("vespa.term.1.connexity"), "Not prepared yet");
        q.prepare();
        assertEquals("2", q.getRanking().getProperties().get("vespa.term.1.connexity").get(0));
        assertEquals("2.718281828459045", q.getRanking().getProperties().get("vespa.term.1.connexity").get(1));
        q = q.clone(); // The clone stays prepared
        assertEquals("2", q.getRanking().getProperties().get("vespa.term.1.connexity").get(0));
        assertEquals("2.718281828459045", q.getRanking().getProperties().get("vespa.term.1.connexity").get(1));
    }

    /**
     * Tests that significance is transferred to rank properties by preparing the query
     * (which strictly is an implementation detail which we should rather hide).
     */
    @Test
    void testSignificance() {
        Query q = new Query("?query=a%20b");
        CompositeItem root = (CompositeItem) q.getModel().getQueryTree().getRoot();
        ((WordItem) root.getItem(0)).setSignificance(0.5);
        ((WordItem) root.getItem(1)).setSignificance(0.95);
        q.prepare();
        assertEquals("0.5", q.getRanking().getProperties().get("vespa.term.1.significance").get(0));
        assertEquals("0.95", q.getRanking().getProperties().get("vespa.term.2.significance").get(0));
    }

    @Test
    void testPhraseWeight() {
        PhraseItem root = new PhraseItem();
        root.setWeight(200);
        root.addItem(new WordItem("a"));
        assertCanonicalized("a!200", null, root);
    }

    @Test
    void testEquivDuplicateRemoval() {
        {
            EquivItem root = new EquivItem();
            root.addItem(new WordItem("a"));
            root.addItem(new WordItem("b"));
            assertCanonicalized("EQUIV a b", null, root);
        }
        {
            EquivItem root = new EquivItem();
            root.addItem(new WordItem("a"));
            root.addItem(new WordItem("b"));
            assertCanonicalized("EQUIV a b", null, root);
        }
        {
            EquivItem root = new EquivItem();
            root.addItem(new WordItem("a"));
            root.addItem(new WordItem("a"));
            assertCanonicalized("a", null, root);
        }
        {
            EquivItem root = new EquivItem();
            root.addItem(new WordItem("a"));
            root.addItem(new WordItem("a"));
            root.addItem(new WordItem("a"));
            root.addItem(new WordItem("a"));
            root.addItem(new WordItem("a"));
            assertCanonicalized("a", null, root);
        }
        {
            EquivItem root = new EquivItem();
            root.addItem(new WordItem("a"));
            root.addItem(new WordItem("b"));
            root.addItem(new WordItem("a"));
            assertCanonicalized("EQUIV a b", null, root);
        }
        {
            EquivItem root = new EquivItem();
            PhraseItem one = new PhraseItem();
            PhraseItem theOther = new PhraseItem();
            WordItem first = new WordItem("a");
            WordItem second = new WordItem("b");
            one.addItem(first);
            one.addItem(second);
            theOther.addItem(first.clone());
            theOther.addItem(second.clone());
            root.addItem(one);
            root.addItem(theOther);
            assertCanonicalized("\"a b\"", null, root);
        }
        {
            EquivItem root = new EquivItem();
            PhraseSegmentItem one = new PhraseSegmentItem("a b", "a b", true, false);
            PhraseSegmentItem theOther = new PhraseSegmentItem("a b", "a b", true, false);
            WordItem first = new WordItem("a");
            WordItem second = new WordItem("b");
            one.addItem(first);
            one.addItem(second);
            theOther.addItem(first.clone());
            theOther.addItem(second.clone());
            root.addItem(one);
            root.addItem(theOther);
            assertCanonicalized("'a b'", null, root);
        }
    }

    @Test
    void queryTreeExceedsAllowedSize() {
        Query query = new Query();
        QueryTree tree = query.getModel().getQueryTree();
        tree.setRoot(new WordItem("A"));
        tree.and(new WordItem("B"));

        assertNull(QueryCanonicalizer.canonicalize(query));
        query.properties().set("maxQueryItems", 2);
        assertEquals("Query tree exceeds allowed item count. Configured limit: 2 - Item count: 3", QueryCanonicalizer.canonicalize(query));
    }

    private void assertCanonicalized(String canonicalForm, String expectedError, Item root) {
        Query query = new Query();
        query.getModel().getQueryTree().setRoot(root);
        assertCanonicalized(canonicalForm, expectedError, query);
    }

    private void assertCanonicalized(String canonicalForm, String expectedError, Query query) {
        String error = QueryCanonicalizer.canonicalize(query);

        assertEquals(expectedError, error);
        if (canonicalForm == null) {
            assertNull(query.getModel().getQueryTree().getRoot());
        } else {
            assertEquals(canonicalForm, query.getModel().getQueryTree().getRoot().toString());
        }
    }

}