1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.api.role;
import com.yahoo.config.provision.ApplicationName;
import com.yahoo.config.provision.SystemName;
import com.yahoo.config.provision.TenantName;
import org.junit.jupiter.api.Test;
import java.net.URI;
import java.util.List;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
/**
* @author mpolden
*/
public class RoleTest {
private static final Enforcer mainEnforcer = new Enforcer(SystemName.main);
private static final Enforcer publicEnforcer = new Enforcer(SystemName.Public);
private static final Enforcer publicCdEnforcer = new Enforcer(SystemName.PublicCd);
@Test
void operator_membership() {
Role role = Role.hostedOperator();
// Operator actions
assertFalse(mainEnforcer.allows(role, Action.create, URI.create("/not/explicitly/defined")));
assertTrue(mainEnforcer.allows(role, Action.create, URI.create("/controller/v1/foo")));
assertTrue(mainEnforcer.allows(role, Action.update, URI.create("/os/v1/bar")));
assertTrue(mainEnforcer.allows(role, Action.update, URI.create("/application/v4/tenant/t1/application/a1")));
assertTrue(mainEnforcer.allows(role, Action.update, URI.create("/application/v4/tenant/t2/application/a2")));
assertTrue(mainEnforcer.allows(role, Action.read, URI.create("/routing/v1/")));
assertTrue(mainEnforcer.allows(role, Action.read, URI.create("/routing/v1/status/environment/")));
assertTrue(mainEnforcer.allows(role, Action.read, URI.create("/routing/v1/status/environment/prod")));
assertTrue(mainEnforcer.allows(role, Action.create, URI.create("/routing/v1/inactive/environment/prod/region/us-north-1")));
}
@Test
void supporter_membership() {
Role role = Role.hostedSupporter();
// No create update or delete
assertFalse(mainEnforcer.allows(role, Action.create, URI.create("/not/explicitly/defined")));
assertFalse(mainEnforcer.allows(role, Action.create, URI.create("/controller/v1/foo")));
assertFalse(mainEnforcer.allows(role, Action.update, URI.create("/os/v1/bar")));
assertFalse(mainEnforcer.allows(role, Action.update, URI.create("/application/v4/tenant/t1/application/a1")));
assertFalse(mainEnforcer.allows(role, Action.update, URI.create("/application/v4/tenant/t2/application/a2")));
assertFalse(mainEnforcer.allows(role, Action.delete, URI.create("/application/v4/tenant/t8/application/a6/instance/i1/environment/dev/region/r1")));
// But reads is ok (but still only for valid paths)
assertFalse(mainEnforcer.allows(role, Action.read, URI.create("/not/explicitly/defined")));
assertTrue(mainEnforcer.allows(role, Action.read, URI.create("/controller/v1/foo")));
assertTrue(mainEnforcer.allows(role, Action.read, URI.create("/os/v1/bar")));
assertTrue(mainEnforcer.allows(role, Action.read, URI.create("/application/v4/tenant/t1/application/a1")));
assertTrue(mainEnforcer.allows(role, Action.read, URI.create("/application/v4/tenant/t2/application/a2")));
assertFalse(mainEnforcer.allows(role, Action.delete, URI.create("/application/v4/tenant/t8/application/a6/instance/i1/environment/dev/region/r1")));
// Check that we are allowed to create tenants in public.
// hostedSupporter isn't actually allowed to create tenants - but any logged in user will be a member of the "everyone" role.
assertTrue(publicEnforcer.allows(Role.everyone(), Action.create, URI.create("/application/v4/tenant/t1")));
}
@Test
void tenant_membership() {
Role role = Role.athenzTenantAdmin(TenantName.from("t1"));
assertFalse(mainEnforcer.allows(role, Action.create, URI.create("/not/explicitly/defined")));
assertFalse(mainEnforcer.allows(role, Action.create, URI.create("/controller/v1/foo")), "Deny access to operator API");
assertFalse(mainEnforcer.allows(role, Action.update, URI.create("/application/v4/tenant/t2/application/a2")), "Deny access to other tenant and app");
assertTrue(mainEnforcer.allows(role, Action.update, URI.create("/application/v4/tenant/t1/application/a1")));
Role publicSystem = Role.athenzTenantAdmin(TenantName.from("t1"));
assertFalse(publicEnforcer.allows(publicSystem, Action.read, URI.create("/controller/v1/foo")));
assertTrue(publicEnforcer.allows(publicSystem, Action.read, URI.create("/badge/v1/badge")));
assertTrue(publicEnforcer.allows(publicSystem, Action.update, URI.create("/application/v4/tenant/t1/application/a1")));
}
@Test
void build_service_membership() {
Role role = Role.buildService(TenantName.from("t1"), ApplicationName.from("a1"));
assertFalse(publicEnforcer.allows(role, Action.create, URI.create("/not/explicitly/defined")));
assertFalse(publicEnforcer.allows(role, Action.update, URI.create("/application/v4/tenant/t1/application/a1")));
assertTrue(publicEnforcer.allows(role, Action.create, URI.create("/application/v4/tenant/t1/application/a1/submit")));
assertFalse(publicEnforcer.allows(role, Action.read, URI.create("/controller/v1/foo")), "No global read access");
}
@Test
void new_implications() {
TenantName tenant1 = TenantName.from("t1");
ApplicationName application1 = ApplicationName.from("a1");
ApplicationName application2 = ApplicationName.from("a2");
Role tenantAdmin1 = Role.administrator(tenant1);
Role tenantDeveloper1 = Role.developer(tenant1);
Role applicationHeadless11 = Role.headless(tenant1, application1);
Role applicationHeadless12 = Role.headless(tenant1, application2);
assertFalse(tenantAdmin1.implies(tenantDeveloper1));
assertFalse(tenantAdmin1.implies(applicationHeadless11));
assertFalse(applicationHeadless11.implies(applicationHeadless12));
}
@Test
void system_flags() {
URI deployUri = URI.create("/system-flags/v1/deploy");
Action action = Action.update;
assertTrue(mainEnforcer.allows(Role.systemFlagsDeployer(), action, deployUri));
assertTrue(mainEnforcer.allows(Role.hostedOperator(), action, deployUri));
assertFalse(mainEnforcer.allows(Role.hostedSupporter(), action, deployUri));
assertFalse(mainEnforcer.allows(Role.systemFlagsDryrunner(), action, deployUri));
assertFalse(mainEnforcer.allows(Role.everyone(), action, deployUri));
URI dryrunUri = URI.create("/system-flags/v1/dryrun");
assertTrue(mainEnforcer.allows(Role.systemFlagsDeployer(), action, dryrunUri));
assertTrue(mainEnforcer.allows(Role.hostedOperator(), action, dryrunUri));
assertFalse(mainEnforcer.allows(Role.hostedSupporter(), action, dryrunUri));
assertTrue(mainEnforcer.allows(Role.systemFlagsDryrunner(), action, dryrunUri));
assertFalse(mainEnforcer.allows(Role.everyone(), action, dryrunUri));
}
@Test
void routing() {
var tenantUrl = URI.create("/routing/v1/status/tenant/t1");
var applicationUrl = URI.create("/routing/v1/status/tenant/t1/application/a1");
var instanceUrl = URI.create("/routing/v1/status/tenant/t1/application/a1/instance/i1");
var deploymentUrl = URI.create("/routing/v1/status/tenant/t1/application/a1/instance/i1/environment/prod/region/us-north-1");
// Read
for (var url : List.of(tenantUrl, applicationUrl, instanceUrl, deploymentUrl)) {
var allowedRole = Role.reader(TenantName.from("t1"));
var disallowedRole = Role.reader(TenantName.from("t2"));
assertTrue(mainEnforcer.allows(allowedRole, Action.read, url), allowedRole + " can read " + url);
assertFalse(mainEnforcer.allows(disallowedRole, Action.read, url), disallowedRole + " cannot read " + url);
}
// Write
{
var url = URI.create("/routing/v1/inactive/tenant/t1/application/a1/instance/i1/environment/prod/region/us-north-1");
var allowedRole = Role.developer(TenantName.from("t1"));
var disallowedRole = Role.developer(TenantName.from("t2"));
assertTrue(mainEnforcer.allows(allowedRole, Action.create, url), allowedRole + " can override status at " + url);
assertTrue(mainEnforcer.allows(allowedRole, Action.delete, url), allowedRole + " can clear status at " + url);
assertFalse(mainEnforcer.allows(disallowedRole, Action.create, url), disallowedRole + " cannot override status at " + url);
assertFalse(mainEnforcer.allows(disallowedRole, Action.delete, url), disallowedRole + " cannot clear status at " + url);
}
}
private static class EnforcerTester {
private final Enforcer enforcer;
private final URI resource;
EnforcerTester(Enforcer enforcer) {
this(enforcer, null);
}
EnforcerTester(Enforcer enforcer, URI uri) {
this.enforcer = enforcer;
this.resource = uri;
}
public EnforcerTester on(String uri) {
return new EnforcerTester(enforcer, URI.create(uri));
}
public EnforcerTester assertAction(Role role, Action ...actions) {
var allowed = List.of(actions);
allowed.forEach(action -> {
var msg = String.format("%s should be allowed to %s on %s", role, action, resource);
assertTrue(enforcer.allows(role, action, resource), msg);
});
Action.all().stream().filter(a -> ! allowed.contains(a)).forEach(action -> {
var msg = String.format("%s should not be allowed to %s on %s", role, action, resource);
assertFalse(enforcer.allows(role, action, resource), msg);
});
return this;
}
}
}
|
