1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
|
// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.maintenance;
import com.yahoo.config.provision.ApplicationId;
import com.yahoo.config.provision.NodeType;
import com.yahoo.config.provision.zone.ZoneId;
import com.yahoo.vespa.hosted.controller.api.integration.configserver.Node;
import com.yahoo.vespa.hosted.controller.integration.NodeRepositoryMock;
import org.junit.jupiter.api.Test;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
/**
* @author smorgrav
*/
public class ChangeManagementAssessorTest {
private final ChangeManagementAssessor changeManagementAssessor = new ChangeManagementAssessor(new NodeRepositoryMock());
@Test
void empty_input_variations() {
ZoneId zone = ZoneId.from("prod", "eu-trd");
List<String> hostNames = new ArrayList<>();
List<Node> allNodesInZone = new ArrayList<>();
// Both zone and hostnames are empty
ChangeManagementAssessor.Assessment assessment
= changeManagementAssessor.assessmentInner(hostNames, allNodesInZone, zone);
assertEquals(0, assessment.getClusterAssessments().size());
}
@Test
void one_host_one_cluster_no_groups() {
ZoneId zone = ZoneId.from("prod", "eu-trd");
List<String> hostNames = Collections.singletonList("host1");
List<Node> allNodesInZone = new ArrayList<>();
allNodesInZone.add(createNode("node1", "host1", "default", 0));
allNodesInZone.add(createNode("node2", "host1", "default", 0));
allNodesInZone.add(createNode("node3", "host1", "default", 0));
// Add an not impacted hosts
allNodesInZone.add(createNode("node4", "host2", "default", 0));
// Add tenant hosts
allNodesInZone.add(createHost("host1", NodeType.host));
allNodesInZone.add(createHost("host2", NodeType.host));
// Make Assessment
List<ChangeManagementAssessor.ClusterAssessment> assessments
= changeManagementAssessor.assessmentInner(hostNames, allNodesInZone, zone).getClusterAssessments();
// Assess the assessment :-o
assertEquals(1, assessments.size());
assertEquals(3, assessments.get(0).clusterImpact);
assertEquals(4, assessments.get(0).clusterSize);
assertEquals(1, assessments.get(0).groupsImpact);
assertEquals(1, assessments.get(0).groupsTotal);
assertEquals("content:default", assessments.get(0).cluster);
assertEquals("mytenant:myapp:default", assessments.get(0).app);
assertEquals("prod.eu-trd", assessments.get(0).zone);
}
@Test
void one_of_two_groups_in_one_of_two_clusters() {
ZoneId zone = ZoneId.from("prod", "eu-trd");
List<String> hostNames = List.of("host1", "host2", "host5");
List<Node> allNodesInZone = new ArrayList<>();
// Two impacted nodes on host1
allNodesInZone.add(createNode("node1", "host1", "default", 0));
allNodesInZone.add(createNode("node2", "host1", "default", 0));
// One impacted nodes on host2
allNodesInZone.add(createNode("node3", "host2", "default", 0));
// Another group on hosts not impacted
allNodesInZone.add(createNode("node4", "host3", "default", 1));
allNodesInZone.add(createNode("node5", "host3", "default", 1));
allNodesInZone.add(createNode("node6", "host3", "default", 1));
// Another cluster on hosts not impacted - this one also with three different groups (should all be ignored here)
allNodesInZone.add(createNode("node4", "host4", "myman", 4));
allNodesInZone.add(createNode("node5", "host4", "myman", 5));
allNodesInZone.add(createNode("node6", "host4", "myman", 6));
// Add tenant hosts
allNodesInZone.add(createHost("host1", NodeType.host));
allNodesInZone.add(createHost("host2", NodeType.host));
// Make Assessment
ChangeManagementAssessor.Assessment assessment
= changeManagementAssessor.assessmentInner(hostNames, allNodesInZone, zone);
// Assess the assessment :-o
List<ChangeManagementAssessor.ClusterAssessment> clusterAssessments = assessment.getClusterAssessments();
assertEquals(1, clusterAssessments.size()); //One cluster is impacted
assertEquals(3, clusterAssessments.get(0).clusterImpact);
assertEquals(6, clusterAssessments.get(0).clusterSize);
assertEquals(1, clusterAssessments.get(0).groupsImpact);
assertEquals(2, clusterAssessments.get(0).groupsTotal);
assertEquals("content:default", clusterAssessments.get(0).cluster);
assertEquals("mytenant:myapp:default", clusterAssessments.get(0).app);
assertEquals("prod.eu-trd", clusterAssessments.get(0).zone);
assertEquals("Impact not larger than upgrade policy", clusterAssessments.get(0).impact);
List<ChangeManagementAssessor.HostAssessment> hostAssessments = assessment.getHostAssessments();
assertEquals(2, hostAssessments.size());
assertTrue(hostAssessments.stream().anyMatch(hostAssessment ->
hostAssessment.hostName.equals("host1") &&
hostAssessment.switchName.equals("switch1") &&
hostAssessment.numberOfChildren == 2 &&
hostAssessment.numberOfProblematicChildren == 2
));
}
@Test
void two_config_nodes() {
var zone = ZoneId.from("prod", "eu-trd");
var hostNames = List.of("config1", "config2");
var allNodesInZone = new ArrayList<Node>();
// Add config nodes and parents
allNodesInZone.add(createNode("config1", "confighost1", "config", 0, NodeType.config));
allNodesInZone.add(createHost("confighost1", NodeType.confighost));
allNodesInZone.add(createNode("config2", "confighost2", "config", 0, NodeType.config));
allNodesInZone.add(createHost("confighost2", NodeType.confighost));
var assessment = changeManagementAssessor.assessmentInner(hostNames, allNodesInZone, zone).getClusterAssessments();
var configAssessment = assessment.get(0);
assertEquals("Large impact. Consider reprovisioning one or more config servers", configAssessment.impact);
assertEquals(2, configAssessment.clusterImpact);
}
@Test
void one_of_three_proxy_nodes() {
var zone = ZoneId.from("prod", "eu-trd");
var hostNames = List.of("routing1");
var allNodesInZone = new ArrayList<Node>();
// Add routing nodes and parents
allNodesInZone.add(createNode("routing1", "parentrouting1", "routing", 0, NodeType.proxy));
allNodesInZone.add(createHost("parentrouting1", NodeType.proxyhost));
allNodesInZone.add(createNode("routing2", "parentrouting2", "routing", 0, NodeType.proxy));
allNodesInZone.add(createHost("parentrouting2", NodeType.proxyhost));
allNodesInZone.add(createNode("routing3", "parentrouting3", "routing", 0, NodeType.proxy));
allNodesInZone.add(createHost("parentrouting3", NodeType.proxyhost));
var assessment = changeManagementAssessor.assessmentInner(hostNames, allNodesInZone, zone).getClusterAssessments();
assertEquals("33% of routing nodes impacted. Consider reprovisioning if too many", assessment.get(0).impact);
}
private Node createNode(String nodename, String hostname, String clusterId, int group) {
return createNode(nodename, hostname, clusterId, group, NodeType.tenant);
}
private Node createNode(String nodename, String hostname, String clusterId, int group, NodeType nodeType) {
return Node.builder().hostname(nodename)
.parentHostname(hostname)
.state(Node.State.active)
.owner(ApplicationId.from("mytenant", "myapp", "default"))
.group(String.valueOf(group))
.clusterId(clusterId)
.clusterType(Node.ClusterType.content)
.type(nodeType)
.build();
}
private Node createHost(String hostname, NodeType nodeType) {
return Node.builder()
.hostname(hostname)
.switchHostname("switch1")
.state(Node.State.active)
.owner(ApplicationId.from("mytenant", "myapp", "default"))
.group(String.valueOf(0))
.clusterId(nodeType.name())
.clusterType(Node.ClusterType.content)
.type(nodeType)
.build();
}
}
|
