1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.maintenance;
import com.yahoo.config.provision.zone.ZoneId;
import com.yahoo.vespa.hosted.controller.ControllerTester;
import com.yahoo.vespa.hosted.controller.api.integration.vcmr.ChangeRequest;
import com.yahoo.vespa.hosted.controller.api.integration.vcmr.ChangeRequestSource;
import com.yahoo.vespa.hosted.controller.api.integration.vcmr.ChangeRequestSource.Status;
import com.yahoo.vespa.hosted.controller.api.integration.vcmr.MockChangeRequestClient;
import com.yahoo.vespa.hosted.controller.api.integration.vcmr.VespaChangeRequest;
import org.junit.jupiter.api.Test;
import java.time.Duration;
import java.time.ZonedDateTime;
import java.util.List;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
* @author olaa
*/
public class ChangeRequestMaintainerTest {
private final ControllerTester tester = new ControllerTester();
private final MockChangeRequestClient changeRequestClient = tester.serviceRegistry().changeRequestClient();
private final ChangeRequestMaintainer changeRequestMaintainer = new ChangeRequestMaintainer(tester.controller(), Duration.ofMinutes(1));
@Test
void updates_status_time_and_approval() {
var time = ZonedDateTime.now();
var persistedChangeRequest = persistedChangeRequest("some-id", time.minusDays(5), Status.WAITING_FOR_APPROVAL);
tester.curator().writeChangeRequest(persistedChangeRequest);
var updatedChangeRequest = newChangeRequest("some-id", ChangeRequest.Approval.APPROVED, time, Status.CANCELED);
changeRequestClient.setUpcomingChangeRequests(List.of(updatedChangeRequest));
changeRequestMaintainer.maintain();
persistedChangeRequest = tester.curator().readChangeRequest("some-id").get();
assertEquals(Status.CANCELED, persistedChangeRequest.getChangeRequestSource().status());
assertEquals(ChangeRequest.Approval.APPROVED, persistedChangeRequest.getApproval());
assertEquals(time, persistedChangeRequest.getChangeRequestSource().plannedStartTime());
assertEquals(0, changeRequestClient.getApprovedChangeRequests().size());
}
@Test
void deletes_old_change_requests() {
var now = ZonedDateTime.now();
var before = now.minus(Duration.ofDays(8));
var newChangeRequest = persistedChangeRequest("new", now, Status.CLOSED);
var oldChangeRequest = persistedChangeRequest("old", before, Status.CLOSED);
tester.curator().writeChangeRequest(newChangeRequest);
tester.curator().writeChangeRequest(oldChangeRequest);
changeRequestMaintainer.maintain();
var persistedChangeRequests = tester.curator().readChangeRequests();
assertEquals(1, persistedChangeRequests.size());
assertEquals(newChangeRequest, persistedChangeRequests.get(0));
}
@Test
void approves_change_request_if_non_prod() {
var time = ZonedDateTime.now();
var prodChangeRequest = newChangeRequest("id1", ChangeRequest.Approval.REQUESTED, time, Status.WAITING_FOR_APPROVAL);
var nonProdApprovalRequested = newChangeRequest("id2", "unknown-node", ChangeRequest.Approval.REQUESTED, time, Status.WAITING_FOR_APPROVAL);
var nonProdApproved = newChangeRequest("id3", "unknown-node", ChangeRequest.Approval.APPROVED, time, Status.WAITING_FOR_APPROVAL);
changeRequestClient.setUpcomingChangeRequests(List.of(
prodChangeRequest,
nonProdApprovalRequested,
nonProdApproved
));
changeRequestMaintainer.maintain();
var persistedChangeRequests = tester.curator().readChangeRequests();
assertEquals(1, persistedChangeRequests.size());
assertEquals(prodChangeRequest.getId(), persistedChangeRequests.get(0).getId());
assertEquals(1, changeRequestClient.getApprovedChangeRequests().size());
assertEquals(nonProdApprovalRequested.getId(), changeRequestClient.getApprovedChangeRequests().get(0).getId());
}
private ChangeRequest newChangeRequest(String id, ChangeRequest.Approval approval, ZonedDateTime time, Status status) {
return newChangeRequest(id, "node-1-tenant-host-prod.us-east-3", approval, time, status);
}
private ChangeRequest newChangeRequest(String id, String hostname, ChangeRequest.Approval approval, ZonedDateTime time, Status status) {
return new ChangeRequest.Builder()
.id(id)
.approval(approval)
.impact(ChangeRequest.Impact.VERY_HIGH)
.impactedSwitches(List.of())
.impactedHosts(List.of(hostname))
.changeRequestSource(new ChangeRequestSource.Builder()
.plannedStartTime(time)
.plannedEndTime(time)
.id("some-id")
.url("some-url")
.system("some-system")
.status(status)
.category("some-category")
.build())
.build();
}
private VespaChangeRequest persistedChangeRequest(String id, ZonedDateTime time, Status status) {
return new VespaChangeRequest(
newChangeRequest(id, ChangeRequest.Approval.REQUESTED, time, status),
ZoneId.from("prod.us-east-3")
);
}
}
|
