1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.maintenance;
import com.yahoo.component.Version;
import com.yahoo.config.provision.ApplicationId;
import com.yahoo.vespa.hosted.controller.LockedTenant;
import com.yahoo.vespa.hosted.controller.api.integration.organization.Contact;
import com.yahoo.vespa.hosted.controller.api.integration.organization.IssueId;
import com.yahoo.vespa.hosted.controller.api.integration.stubs.LoggingDeploymentIssues;
import com.yahoo.vespa.hosted.controller.application.Change;
import com.yahoo.vespa.hosted.controller.application.TenantAndApplicationId;
import com.yahoo.vespa.hosted.controller.application.pkg.ApplicationPackage;
import com.yahoo.vespa.hosted.controller.deployment.ApplicationPackageBuilder;
import com.yahoo.vespa.hosted.controller.deployment.DeploymentTester;
import com.yahoo.vespa.hosted.controller.versions.VespaVersion;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import java.time.Duration;
import java.util.HashMap;
import java.util.Map;
import static com.yahoo.config.application.api.DeploymentSpec.UpgradePolicy.canary;
import static com.yahoo.vespa.hosted.controller.deployment.DeploymentContext.productionUsWest1;
import static com.yahoo.vespa.hosted.controller.deployment.DeploymentContext.stagingTest;
import static com.yahoo.vespa.hosted.controller.deployment.DeploymentContext.systemTest;
import static com.yahoo.vespa.hosted.controller.maintenance.DeploymentIssueReporter.maxFailureAge;
import static com.yahoo.vespa.hosted.controller.maintenance.DeploymentIssueReporter.maxInactivity;
import static com.yahoo.vespa.hosted.controller.maintenance.DeploymentIssueReporter.upgradeGracePeriod;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
/**
* @author jonmv
*/
public class DeploymentIssueReporterTest {
private final static ApplicationPackage applicationPackage = new ApplicationPackageBuilder()
.region("us-west-1")
.build();
private final static ApplicationPackage canaryPackage = new ApplicationPackageBuilder()
.region("us-west-1")
.upgradePolicy("canary")
.build();
private DeploymentTester tester;
private DeploymentIssueReporter reporter;
private MockDeploymentIssues issues;
@BeforeEach
public void setup() {
tester = new DeploymentTester();
issues = new MockDeploymentIssues();
reporter = new DeploymentIssueReporter(tester.controller(), issues, Duration.ofDays(1));
}
@Test
void nonProductionAppGetsNoIssues() {
tester.controllerTester().upgradeSystem(Version.fromString("6.2"));
var app = tester.newDeploymentContext("application", "tenant", "default");
Contact contact = tester.controllerTester().serviceRegistry().contactRetrieverMock().contact();
tester.controller().tenants().lockOrThrow(app.instanceId().tenant(), LockedTenant.Athenz.class, tenant ->
tester.controller().tenants().store(tenant.with(contact)));
// app submits a package with no production deployments, and shall not receive issues.
app.submit(new ApplicationPackageBuilder().systemTest().stagingTest().build()).runJob(systemTest).failDeployment(stagingTest);
// Advance to where deployment issues should be detected.
tester.clock().advance(maxFailureAge.plus(Duration.ofDays(1)));
assertFalse(issues.isOpenFor(app.application().id()), "No issues are produced for app.");
}
@Test
void testDeploymentFailureReporting() {
tester.controllerTester().upgradeSystem(Version.fromString("6.2"));
// Create and deploy one application for each of three tenants.
var app1 = tester.newDeploymentContext("application1", "tenant1", "default");
var app2 = tester.newDeploymentContext("application2", "tenant2", "default");
var app3 = tester.newDeploymentContext("application3", "tenant3", "default");
Contact contact = tester.controllerTester().serviceRegistry().contactRetrieverMock().contact();
tester.controller().tenants().lockOrThrow(app1.instanceId().tenant(), LockedTenant.Athenz.class, tenant ->
tester.controller().tenants().store(tenant.with(contact)));
tester.controller().tenants().lockOrThrow(app2.instanceId().tenant(), LockedTenant.Athenz.class, tenant ->
tester.controller().tenants().store(tenant.with(contact)));
tester.controller().tenants().lockOrThrow(app3.instanceId().tenant(), LockedTenant.Athenz.class, tenant ->
tester.controller().tenants().store(tenant.with(contact)));
// NOTE: All maintenance should be idempotent within a small enough time interval, so maintain is called twice in succession throughout.
// app 1 fails staging tests.
app1.submit(applicationPackage).runJob(systemTest).timeOutConvergence(stagingTest);
// app2 is successful, but will fail later.
app2.submit(applicationPackage).deploy();
// app 3 fails a production job.
app3.submit(applicationPackage).runJob(systemTest).runJob(stagingTest).failDeployment(productionUsWest1);
reporter.maintain();
reporter.maintain();
assertEquals(0, issues.size(), "No deployments are detected as failing for a long time initially.");
// Advance to where deployment issues should be detected.
tester.clock().advance(maxFailureAge.plus(Duration.ofDays(1)));
reporter.maintain();
reporter.maintain();
assertTrue(issues.isOpenFor(app1.application().id()), "One issue is produced for app1.");
assertFalse(issues.isOpenFor(app2.application().id()), "No issues are produced for app2.");
assertTrue(issues.isOpenFor(app3.application().id()), "One issue is produced for app3.");
// app3 closes their issue prematurely; see that it is refiled.
issues.closeFor(app3.application().id());
assertFalse(issues.isOpenFor(app3.application().id()), "No issue is open for app3.");
reporter.maintain();
reporter.maintain();
assertTrue(issues.isOpenFor(app3.application().id()), "Issue is re-filed for app3.");
// Some time passes; tenant1 leaves her issue unattended, while tenant3 starts work and updates the issue.
tester.clock().advance(maxInactivity.plus(maxFailureAge));
issues.touchFor(app3.application().id());
reporter.maintain();
reporter.maintain();
assertEquals(1, issues.escalationLevelFor(app1.application().id()), "The issue for app1 is escalated once.");
// app3 fixes their problems, but the ticket for app3 is left open; see the resolved ticket is not escalated when another escalation period has passed.
app3.runJob(productionUsWest1);
tester.clock().advance(maxInactivity.plus(Duration.ofDays(1)));
reporter.maintain();
reporter.maintain();
assertFalse(issues.platformIssue(), "We no longer have a platform issue.");
assertEquals(2, issues.escalationLevelFor(app1.application().id()), "The issue for app1 is escalated once more.");
assertEquals(0, issues.escalationLevelFor(app3.application().id()), "The issue for app3 is not escalated.");
// app3 now has a new failure past max failure age; see that a new issue is filed.
app3.submit(applicationPackage).failDeployment(systemTest);
tester.clock().advance(maxInactivity.plus(maxFailureAge));
reporter.maintain();
reporter.maintain();
assertTrue(issues.isOpenFor(app3.application().id()), "A new issue is filed for app3.");
// app2 is changed to be a canary
app2.submit(canaryPackage).deploy();
assertEquals(canary, app2.application().deploymentSpec().requireInstance("default").upgradePolicy());
assertEquals(Change.empty(), app2.instance().change());
// Bump system version to upgrade canary app2.
Version version = Version.fromString("6.3");
tester.controllerTester().upgradeSystem(version);
tester.upgrader().maintain();
assertEquals(version, tester.controller().readSystemVersion());
app2.timeOutUpgrade(systemTest);
tester.controllerTester().upgradeSystem(version);
assertEquals(VespaVersion.Confidence.broken, tester.controller().readVersionStatus().systemVersion().get().confidence());
assertFalse(issues.platformIssue(), "We have no platform issues initially.");
reporter.maintain();
reporter.maintain();
assertFalse(issues.platformIssue(), "We have no platform issue before the grace period is out for the failing canary.");
tester.clock().advance(upgradeGracePeriod.plus(upgradeGracePeriod));
reporter.maintain();
reporter.maintain();
assertTrue(issues.platformIssue(), "We get a platform issue when confidence is broken");
assertFalse(issues.isOpenFor(app2.application().id()), "No deployment issue is filed for app2, which has a version upgrade failure.");
app2.runJob(systemTest);
tester.controllerTester().upgradeSystem(version);
assertEquals(VespaVersion.Confidence.low, tester.controller().readVersionStatus().systemVersion().get().confidence());
}
class MockDeploymentIssues extends LoggingDeploymentIssues {
private final Map<TenantAndApplicationId, IssueId> applicationIssues = new HashMap<>();
private final Map<IssueId, Integer> issueLevels = new HashMap<>();
MockDeploymentIssues() {
super(tester.clock());
}
@Override
protected void escalateIssue(IssueId issueId) {
super.escalateIssue(issueId);
issueLevels.merge(issueId, 1, Integer::sum);
}
@Override
protected IssueId fileIssue(ApplicationId applicationId) {
IssueId issueId = super.fileIssue(applicationId);
applicationIssues.put(TenantAndApplicationId.from(applicationId), issueId);
return issueId;
}
void closeFor(TenantAndApplicationId id) {
issueUpdates.remove(applicationIssues.remove(id));
}
void touchFor(TenantAndApplicationId id) {
issueUpdates.put(applicationIssues.get(id), tester.clock().instant());
}
boolean isOpenFor(TenantAndApplicationId id) {
return applicationIssues.containsKey(id);
}
int escalationLevelFor(TenantAndApplicationId id) {
return issueLevels.getOrDefault(applicationIssues.get(id), 0);
}
int size() {
return issueUpdates.size();
}
boolean platformIssue() {
return platformIssue.get();
}
}
}
|
