summaryrefslogtreecommitdiffstats
path: root/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/OsUpgradeSchedulerTest.java
blob: 51bda73025dd4ed6f30a65613b78832b127c45f5 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.maintenance;

import com.yahoo.component.Version;
import com.yahoo.config.provision.CloudName;
import com.yahoo.config.provision.zone.ZoneApi;
import com.yahoo.vespa.hosted.controller.ControllerTester;
import com.yahoo.vespa.hosted.controller.api.integration.deployment.StableOsVersion;
import com.yahoo.vespa.hosted.controller.integration.ZoneApiMock;
import com.yahoo.vespa.hosted.controller.versions.OsVersionTarget;
import org.junit.Test;

import java.time.Duration;
import java.time.Instant;
import java.util.List;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

/**
 * @author mpolden
 */
public class OsUpgradeSchedulerTest {

    @Test
    public void schedule_calendar_versioned_release() {
        ControllerTester tester = new ControllerTester();
        OsUpgradeScheduler scheduler = new OsUpgradeScheduler(tester.controller(), Duration.ofDays(1));
        Instant t0 = Instant.parse("2021-01-23T00:00:00.00Z"); // Outside trigger period
        tester.clock().setInstant(t0);

        CloudName cloud = CloudName.from("cloud");
        ZoneApi zone = zone("prod.us-west-1", cloud);
        tester.zoneRegistry().setZones(zone).reprovisionToUpgradeOsIn(zone);

        // Initial run does nothing as the cloud does not have a target
        scheduler.maintain();
        assertTrue("No target set", tester.controller().osVersionTarget(cloud).isEmpty());

        // Target is set
        Version version0 = Version.fromString("7.0.0.20210123190005");
        tester.controller().upgradeOsIn(cloud, version0, Duration.ofDays(1), false);

        // Target remains unchanged as it hasn't expired yet
        for (var interval : List.of(Duration.ZERO, Duration.ofDays(30))) {
            tester.clock().advance(interval);
            scheduler.maintain();
            assertEquals(version0, tester.controller().osVersionTarget(cloud).get().osVersion().version());
        }

        // Just over 45 days pass, and a new target replaces the expired one
        Version version1 = Version.fromString("7.0.0.20210302");
        tester.clock().advance(Duration.ofDays(15).plus(Duration.ofSeconds(1)));
        scheduler.maintain();
        assertEquals("Target is unchanged because we're outside trigger period", version0,
                     tester.controller().osVersionTarget(cloud).get().osVersion().version());
        tester.clock().advance(Duration.ofHours(7)); // Put us inside the trigger period
        scheduler.maintain();
        assertEquals("New target set", version1,
                     tester.controller().osVersionTarget(cloud).get().osVersion().version());

        // A few days pass and target remains unchanged
        tester.clock().advance(Duration.ofDays(2));
        scheduler.maintain();
        assertEquals(version1, tester.controller().osVersionTarget(cloud).get().osVersion().version());
    }

    @Test
    public void schedule_stable_release() {
        ControllerTester tester = new ControllerTester();
        OsUpgradeScheduler scheduler = new OsUpgradeScheduler(tester.controller(), Duration.ofDays(1));
        Instant t0 = Instant.parse("2021-06-21T07:00:00.00Z"); // Inside trigger period
        tester.clock().setInstant(t0);

        // Set initial target
        CloudName cloud = tester.controller().clouds().iterator().next();
        Version version0 = Version.fromString("8.0");
        tester.controller().upgradeOsIn(cloud, version0, Duration.ZERO, false);

        // New version is promoted to stable
        Version version1 = Version.fromString("8.1");
        tester.serviceRegistry().artifactRepository().promoteOsVersion(new StableOsVersion(version1, tester.clock().instant()));
        scheduler.maintain();
        assertEquals("Target is unchanged as not enough time has passed", version0,
                     tester.controller().osVersionTarget(cloud).get().osVersion().version());

        // Enough time passes since promotion of stable release
        tester.clock().advance(Duration.ofDays(7).plus(Duration.ofSeconds(1)));
        scheduler.maintain();
        OsVersionTarget target0 = tester.controller().osVersionTarget(cloud).get();
        assertEquals(version1, target0.osVersion().version());
        assertEquals("No budget when upgrading to stable release",
                     Duration.ZERO, target0.upgradeBudget());

        // Another version is promoted, but target remains unchanged as the release hasn't aged enough
        tester.clock().advance(Duration.ofDays(1));
        Version version2 = Version.fromString("8.2");
        tester.serviceRegistry().artifactRepository().promoteOsVersion(new StableOsVersion(version2, tester.clock().instant()));
        scheduler.maintain();
        OsVersionTarget target1 = tester.controller().osVersionTarget(cloud).get();
        assertEquals("Target is unchanged as not enough time has passed", version1,
                     target1.osVersion().version());
        assertEquals("Target is not re-scheduled", target0.scheduledAt(), target1.scheduledAt());

        // A newer version is triggered manually
        Version version3 = Version.fromString("8.3");
        tester.controller().upgradeOsIn(cloud, version3, Duration.ZERO, false);

        // Enough time passes for stable version to be promoted. Nothing happens as stable is now before the manually
        // triggered version
        tester.clock().advance(Duration.ofDays(7).plus(Duration.ofSeconds(1)));
        scheduler.maintain();
        assertEquals(version3, tester.controller().osVersionTarget(cloud).get().osVersion().version());
    }

    private static ZoneApi zone(String id, CloudName cloud) {
        return ZoneApiMock.newBuilder().withId(id).with(cloud).build();
    }

}