1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
|
// Copyright 2018 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.maintenance;
import com.yahoo.component.Version;
import com.yahoo.config.provision.ApplicationId;
import com.yahoo.vespa.hosted.controller.NodeRepositoryMock;
import com.yahoo.vespa.hosted.controller.api.integration.configserver.Node;
import com.yahoo.vespa.hosted.controller.api.integration.zone.UpgradePolicy;
import com.yahoo.vespa.hosted.controller.api.integration.zone.ZoneId;
import com.yahoo.vespa.hosted.controller.application.SystemApplication;
import com.yahoo.vespa.hosted.controller.deployment.DeploymentTester;
import org.junit.Ignore;
import org.junit.Test;
import java.util.Arrays;
import java.util.List;
import java.util.function.Function;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
/**
* @author mpolden
*/
public class SystemUpgraderTest {
private static final ZoneId zone1 = ZoneId.from("prod", "eu-west-1");
private static final ZoneId zone2 = ZoneId.from("prod", "us-west-1");
private static final ZoneId zone3 = ZoneId.from("prod", "us-central-1");
private static final ZoneId zone4 = ZoneId.from("prod", "us-east-3");
private final DeploymentTester tester = new DeploymentTester();
@Test
public void upgrade_system() {
tester.controllerTester().zoneRegistry().setUpgradePolicy(
UpgradePolicy.create()
.upgrade(zone1)
.upgradeInParallel(zone2, zone3)
.upgrade(zone4)
);
Version version1 = Version.fromString("6.5");
// Bootstrap a system without host applications
tester.configServer().bootstrap(Arrays.asList(zone1, zone2, zone3, zone4), SystemApplication.configServer,
SystemApplication.zone);
// Fail a few nodes. Failed nodes should not affect versions
failNodeIn(zone1, SystemApplication.configServer);
failNodeIn(zone3, SystemApplication.zone);
tester.upgradeSystem(version1);
tester.systemUpgrader().maintain();
assertCurrentVersion(SystemApplication.configServer, version1, zone1, zone2, zone3, zone4);
assertCurrentVersion(SystemApplication.zone, version1, zone1, zone2, zone3, zone4);
// Controller upgrades
Version version2 = Version.fromString("6.6");
tester.upgradeController(version2);
assertEquals(version2, tester.controller().versionStatus().controllerVersion().get().versionNumber());
// System upgrade starts
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.configServer, version2, zone1);
// Other zones remain on previous version
assertWantedVersion(SystemApplication.configServer, version1, zone2, zone3, zone4);
// Zone application is not upgraded yet
assertWantedVersion(SystemApplication.zone, version1, zone1, zone2, zone3, zone4);
// zone1: zone-config-server upgrades
completeUpgrade(SystemApplication.configServer, version2, zone1);
// zone 1: zone-application upgrades
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.zone, version2, zone1);
completeUpgrade(SystemApplication.zone, version2, zone1);
assertTrue("Deployed zone application",
tester.configServer().application(SystemApplication.zone.id()).isPresent());
// zone 2, 3 and 4: still targets old version
assertWantedVersion(SystemApplication.configServer, version1, zone2, zone3, zone4);
assertWantedVersion(SystemApplication.zone, version1, zone2, zone3, zone4);
// zone 2 and 3: zone-config-server upgrades, first in zone 2, then in zone 3
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.configServer, version2, zone2, zone3);
assertWantedVersion(SystemApplication.configServer, version1, zone4);
assertWantedVersion(SystemApplication.zone, version1, zone2, zone3, zone4);
completeUpgrade(SystemApplication.configServer, version2, zone2);
// zone-application starts upgrading in zone 2, while zone-config-server completes upgrade in zone 3
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.zone, version2, zone2);
assertWantedVersion(SystemApplication.zone, version1, zone3);
completeUpgrade(SystemApplication.configServer, version2, zone3);
// zone 2 and 3: zone-application upgrades in parallel
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.zone, version2, zone2, zone3);
completeUpgrade(SystemApplication.zone, version2, zone2, zone3);
// zone 4: zone-config-server upgrades
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.configServer, version2, zone4);
assertWantedVersion(SystemApplication.zone, version1, zone4);
completeUpgrade(SystemApplication.configServer, version2, zone4);
// System version remains unchanged until final application upgrades
tester.computeVersionStatus();
assertEquals(version1, tester.controller().versionStatus().systemVersion().get().versionNumber());
// zone 4: zone-application upgrades
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.zone, version2, zone4);
completeUpgrade(SystemApplication.zone, version2, zone4);
tester.computeVersionStatus();
assertEquals(version2, tester.controller().versionStatus().systemVersion().get().versionNumber());
// Next run does nothing as system is now upgraded
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.configServer, version2, zone1, zone2, zone3, zone4);
assertWantedVersion(SystemApplication.zone, version2, zone1, zone2, zone3, zone4);
}
@Test
@Ignore // TODO: Unignore once host applications support upgrade
public void upgrade_system_containing_host_applications() {
tester.controllerTester().zoneRegistry().setUpgradePolicy(
UpgradePolicy.create()
.upgrade(zone1)
.upgradeInParallel(zone2, zone3)
.upgrade(zone4)
);
Version version1 = Version.fromString("6.5");
tester.configServer().bootstrap(Arrays.asList(zone1, zone2, zone3, zone4), SystemApplication.all());
tester.upgradeSystem(version1);
tester.systemUpgrader().maintain();
assertCurrentVersion(SystemApplication.all(), version1, zone1, zone2, zone3, zone4);
// Controller upgrades
Version version2 = Version.fromString("6.6");
tester.upgradeController(version2);
assertEquals(version2, tester.controller().versionStatus().controllerVersion().get().versionNumber());
// System upgrades in zone 1:
tester.systemUpgrader().maintain();
List<SystemApplication> allExceptZone = Arrays.asList(SystemApplication.configServerHost,
SystemApplication.proxyHost,
SystemApplication.configServer);
completeUpgrade(allExceptZone, version2, zone1);
tester.systemUpgrader().maintain();
completeUpgrade(SystemApplication.zone, version2, zone1);
assertWantedVersion(SystemApplication.all(), version1, zone2, zone3, zone4);
// zone 2 and 3:
tester.systemUpgrader().maintain();
completeUpgrade(allExceptZone, version2, zone2, zone3);
tester.systemUpgrader().maintain();
completeUpgrade(SystemApplication.zone, version2, zone2, zone3);
assertWantedVersion(SystemApplication.all(), version1, zone4);
// zone 4:
tester.systemUpgrader().maintain();
completeUpgrade(allExceptZone, version2, zone4);
tester.systemUpgrader().maintain();
completeUpgrade(SystemApplication.zone, version2, zone4);
// All done
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.all(), version2, zone1, zone2, zone3, zone4);
}
@Test
public void never_downgrades_system() {
ZoneId zone = ZoneId.from("prod", "eu-west-1");
tester.controllerTester().zoneRegistry().setUpgradePolicy(UpgradePolicy.create().upgrade(zone));
Version version = Version.fromString("6.5");
tester.upgradeSystem(version);
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.configServer, version, zone);
assertWantedVersion(SystemApplication.zone, version, zone);
// Controller is downgraded
tester.upgradeController(Version.fromString("6.4"));
// Wanted version for zone remains unchanged
tester.systemUpgrader().maintain();
assertWantedVersion(SystemApplication.configServer, version, zone);
assertWantedVersion(SystemApplication.zone, version, zone);
}
/** Simulate upgrade of nodes allocated to given application. In a real system this is done by the node itself */
private void completeUpgrade(SystemApplication application, Version version, ZoneId... zones) {
assertWantedVersion(application, version, zones);
for (ZoneId zone : zones) {
for (Node node : nodeRepository().listOperational(zone, application.id())) {
nodeRepository().add(zone, new Node(node.hostname(), node.state(), node.type(), node.owner(),
node.wantedVersion(), node.wantedVersion()));
}
assertCurrentVersion(application, version, zone);
}
}
private void completeUpgrade(List<SystemApplication> applications, Version version, ZoneId... zones) {
applications.forEach(application -> completeUpgrade(application, version, zones));
}
private void failNodeIn(ZoneId zone, SystemApplication application) {
List<Node> nodes = nodeRepository().list(zone, application.id());
if (nodes.isEmpty()) {
throw new IllegalArgumentException("No nodes allocated to " + application.id());
}
Node node = nodes.get(0);
nodeRepository().add(zone, new Node(node.hostname(), Node.State.failed, node.type(), node.owner(),
node.currentVersion(), node.wantedVersion()));
}
private void assertWantedVersion(SystemApplication application, Version version, ZoneId... zones) {
assertVersion(application.id(), version, Node::wantedVersion, zones);
}
private void assertCurrentVersion(SystemApplication application, Version version, ZoneId... zones) {
assertVersion(application.id(), version, Node::currentVersion, zones);
}
private void assertWantedVersion(List<SystemApplication> applications, Version version, ZoneId... zones) {
applications.forEach(application -> assertVersion(application.id(), version, Node::wantedVersion, zones));
}
private void assertCurrentVersion(List<SystemApplication> applications, Version version, ZoneId... zones) {
applications.forEach(application -> assertVersion(application.id(), version, Node::currentVersion, zones));
}
private void assertVersion(ApplicationId application, Version version, Function<Node, Version> versionField,
ZoneId... zones) {
for (ZoneId zone : zones) {
for (Node node : nodeRepository().listOperational(zone, application)) {
assertEquals(application + " version", version, versionField.apply(node));
}
}
}
private NodeRepositoryMock nodeRepository() {
return tester.controllerTester().configServer().nodeRepository();
}
}
|