summaryrefslogtreecommitdiffstats
path: root/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/TrafficShareUpdaterTest.java
blob: 5c26e270846f27fd37a40f5057f77a6e3f93a2e5 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.maintenance;

import com.yahoo.component.Version;
import com.yahoo.config.application.api.xml.DeploymentSpecXmlReader;
import com.yahoo.config.provision.ApplicationId;
import com.yahoo.config.provision.zone.ZoneId;
import com.yahoo.vespa.hosted.controller.Application;
import com.yahoo.vespa.hosted.controller.api.application.v4.model.ClusterMetrics;
import com.yahoo.vespa.hosted.controller.api.identifiers.DeploymentId;
import com.yahoo.vespa.hosted.controller.application.pkg.ApplicationPackage;
import com.yahoo.vespa.hosted.controller.deployment.DeploymentContext;
import com.yahoo.vespa.hosted.controller.deployment.DeploymentTester;
import com.yahoo.vespa.hosted.controller.integration.NodeRepositoryMock;
import org.junit.jupiter.api.Test;

import java.time.Duration;
import java.util.Map;
import java.util.OptionalLong;

import static org.junit.jupiter.api.Assertions.assertEquals;

/**
 * Tests the traffic fraction updater. This also tests its dependency on DeploymentMetricsMaintainer.
 *
 * @author bratseth
 */
public class TrafficShareUpdaterTest {

    @Test
    void testTrafficUpdaterImplicitBcp() {
        DeploymentTester tester = new DeploymentTester();
        Version version = Version.fromString("7.1");
        tester.controllerTester().upgradeSystem(Version.fromString("7.1"));
        var context = tester.newDeploymentContext();
        var deploymentMetricsMaintainer = new DeploymentMetricsMaintainer(tester.controller(), Duration.ofDays(1));
        var updater = new TrafficShareUpdater(tester.controller(), Duration.ofDays(1));
        ZoneId prod1 = ZoneId.from("prod", "ap-northeast-1");
        ZoneId prod2 = ZoneId.from("prod", "us-east-3");
        ZoneId prod3 = ZoneId.from("prod", "us-west-1");
        context.runJob(DeploymentContext.perfUsEast3, new ApplicationPackage(new byte[0]), version); // Ignored
        context.runJob(DeploymentContext.productionApNortheast1, new ApplicationPackage(new byte[0]), version);

        // One zone
        context.runJob(DeploymentContext.productionApNortheast1, new ApplicationPackage(new byte[0]), version);
        setQpsMetric(50.0, context.application().id().defaultInstance(), prod1, tester);
        deploymentMetricsMaintainer.maintain();
        assertEquals(1.0, updater.maintain(), 0.0000001);
        assertTrafficFraction(1.0, 1.0, context.instanceId(), prod1, tester);

        // Two zones
        context.runJob(DeploymentContext.productionUsEast3, new ApplicationPackage(new byte[0]), version);
        setQpsMetric(60.0, context.application().id().defaultInstance(), prod1, tester);
        setQpsMetric(20.0, context.application().id().defaultInstance(), prod2, tester);
        deploymentMetricsMaintainer.maintain();
        assertEquals(1.0, updater.maintain(), 0.0000001);
        assertTrafficFraction(0.75, 1.0, context.instanceId(), prod1, tester);
        assertTrafficFraction(0.25, 1.0, context.instanceId(), prod2, tester);

        // Three zones
        context.runJob(DeploymentContext.productionUsWest1, new ApplicationPackage(new byte[0]), version);
        setQpsMetric(53.0, context.application().id().defaultInstance(), prod1, tester);
        setQpsMetric(45.0, context.application().id().defaultInstance(), prod2, tester);
        setQpsMetric(02.0, context.application().id().defaultInstance(), prod3, tester);
        deploymentMetricsMaintainer.maintain();
        assertEquals(1.0, updater.maintain(), 0.0000001);
        assertTrafficFraction(0.53, 0.53 + (double)45/2 / 100, context.instanceId(), prod1, tester);
        assertTrafficFraction(0.45, 0.45 + (double)53/2 / 100, context.instanceId(), prod2, tester);
        assertTrafficFraction(0.02, 0.02 + (double)53/2 / 100, context.instanceId(), prod3, tester);
    }

    @Test
    void testTrafficUpdaterHotCold() {
        var spec = """
                <deployment version="1.0">
                  <staging/>
                  <prod>
                    <region>ap-northeast-1</region>
                    <region>ap-southeast-1</region>
                    <region>us-east-3</region>
                    <region>us-central-1</region>
                    <region>eu-west-1</region>
                  </prod>
                  <bcp>
                    <group>
                      <region>ap-northeast-1</region>
                      <region>ap-southeast-1</region>
                    </group>
                    <group>
                      <region>us-east-3</region>
                      <region>us-central-1</region>
                    </group>
                    <group>
                      <region>eu-west-1</region>
                    </group>
                  </bcp>
                </deployment>
                """;

        DeploymentTester tester = new DeploymentTester();
        Version version = Version.fromString("7.1");
        tester.controllerTester().upgradeSystem(Version.fromString("7.1"));
        var context = tester.newDeploymentContext();
        var deploymentSpec = new DeploymentSpecXmlReader(true).read(spec);
        tester.controller().applications()
              .lockApplicationOrThrow(context.application().id(),
                                      locked -> tester.controller().applications().store(locked.with(deploymentSpec)));

        var deploymentMetricsMaintainer = new DeploymentMetricsMaintainer(tester.controller(), Duration.ofDays(1));
        var updater = new TrafficShareUpdater(tester.controller(), Duration.ofDays(1));

        ZoneId ap1 = ZoneId.from("prod", "ap-northeast-1");
        ZoneId ap2 = ZoneId.from("prod", "ap-southeast-1");
        ZoneId us1 = ZoneId.from("prod", "us-east-3");
        ZoneId us2 = ZoneId.from("prod", "us-central-1");
        ZoneId eu1 = ZoneId.from("prod", "eu-west-1");

        context.runJob(DeploymentContext.productionApNortheast1, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionApSoutheast1, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionUsEast3, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionUsCentral1, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionEuWest1, new ApplicationPackage(new byte[0]), version);

        setQpsMetric(50.0, context.application().id().defaultInstance(), ap1, tester);
        setQpsMetric(00.0, context.application().id().defaultInstance(), ap2, tester);
        setQpsMetric(10.0, context.application().id().defaultInstance(), us1, tester);
        setQpsMetric(00.0, context.application().id().defaultInstance(), us2, tester);
        setQpsMetric(40.0, context.application().id().defaultInstance(), eu1, tester);

        deploymentMetricsMaintainer.maintain();
        assertEquals(1.0, updater.maintain(), 0.0000001);
        assertTrafficFraction(0.5, 0.5, context.instanceId(), ap1, tester);
        assertTrafficFraction(0.0, 0.5, context.instanceId(), ap2, tester);
        assertTrafficFraction(0.1, 0.1, context.instanceId(), us1, tester);
        assertTrafficFraction(0.0, 0.1, context.instanceId(), us2, tester);
        assertTrafficFraction(0.4, 0.4, context.instanceId(), eu1, tester);
    }

    @Test
    void testTrafficUpdaterOverlappingGroups() {
        var spec = """
                <deployment version="1.0">
                  <staging/>
                  <prod>
                    <region>ap-northeast-1</region>
                    <region>ap-southeast-1</region>
                    <region>us-east-3</region>
                    <region>us-central-1</region>
                    <region>us-west-1</region>
                    <region>eu-west-1</region>
                  </prod>
                  <bcp>
                    <group>
                      <region>ap-northeast-1</region>
                      <region>ap-southeast-1</region>
                      <region fraction="0.5">eu-west-1</region>
                    </group>
                    <group>
                      <region>us-east-3</region>
                      <region>us-central-1</region>
                      <region>us-west-1</region>
                      <region fraction="0.5">eu-west-1</region>
                    </group>
                  </bcp>
                </deployment>
                """;

        DeploymentTester tester = new DeploymentTester();
        Version version = Version.fromString("7.1");
        tester.controllerTester().upgradeSystem(Version.fromString("7.1"));
        var context = tester.newDeploymentContext();
        var deploymentSpec = new DeploymentSpecXmlReader(true).read(spec);
        tester.controller().applications()
                  .lockApplicationOrThrow(context.application().id(),
                                          locked -> tester.controller().applications().store(locked.with(deploymentSpec)));

        var deploymentMetricsMaintainer = new DeploymentMetricsMaintainer(tester.controller(), Duration.ofDays(1));
        var updater = new TrafficShareUpdater(tester.controller(), Duration.ofDays(1));

        ZoneId ap1 = ZoneId.from("prod", "ap-northeast-1");
        ZoneId ap2 = ZoneId.from("prod", "ap-southeast-1");
        ZoneId us1 = ZoneId.from("prod", "us-east-3");
        ZoneId us2 = ZoneId.from("prod", "us-central-1");
        ZoneId us3 = ZoneId.from("prod", "us-west-1");
        ZoneId eu1 = ZoneId.from("prod", "eu-west-1");

        context.runJob(DeploymentContext.productionApNortheast1, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionApSoutheast1, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionUsEast3, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionUsCentral1, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionUsWest1, new ApplicationPackage(new byte[0]), version);
        context.runJob(DeploymentContext.productionEuWest1, new ApplicationPackage(new byte[0]), version);

        setQpsMetric(20.0, context.application().id().defaultInstance(), ap1, tester);
        setQpsMetric(50.0, context.application().id().defaultInstance(), ap2, tester);
        setQpsMetric(00.0, context.application().id().defaultInstance(), us1, tester);
        setQpsMetric(30.0, context.application().id().defaultInstance(), us2, tester);
        setQpsMetric(40.0, context.application().id().defaultInstance(), us3, tester);
        setQpsMetric(60.0, context.application().id().defaultInstance(), eu1, tester);

        deploymentMetricsMaintainer.maintain();
        assertEquals(1.0, updater.maintain(), 0.0000001);
        assertTrafficFraction(0.10, 0.10 + 50 / 200.0 / 1.5, context.instanceId(), ap1, tester);
        assertTrafficFraction(0.25, 0.25 + 30 / 200.0 / 1.5, context.instanceId(), ap2, tester);
        assertTrafficFraction(0.00, 0.00 + 40 / 200.0 / 2.5, context.instanceId(), us1, tester);
        assertTrafficFraction(0.15, 0.15 + 40 / 200.0 / 2.5, context.instanceId(), us2, tester);
        assertTrafficFraction(0.20, 0.20 + 30 / 200.0 / 2.5, context.instanceId(), us3, tester);
        assertTrafficFraction(0.30, 0.30 + 0.5 * 50 / 200.0 / 1.5 + 0.5 * 40 / 200.0 / 2.5, context.instanceId(), eu1, tester);
    }

    private void setQpsMetric(double qps, ApplicationId application, ZoneId zone, DeploymentTester tester) {
        var clusterMetrics = new ClusterMetrics("default", "container", Map.of(ClusterMetrics.QUERIES_PER_SECOND, qps));
        tester.controllerTester().serviceRegistry().configServerMock().setMetrics(new DeploymentId(application, zone), clusterMetrics);
    }

    private void assertTrafficFraction(double currentReadShare, double maxReadShare,
                                       ApplicationId application, ZoneId zone, DeploymentTester tester) {
        NodeRepositoryMock mock = (NodeRepositoryMock)tester.controller().serviceRegistry().configServer().nodeRepository();
        assertEquals(currentReadShare, mock.getTrafficFraction(application, zone).getFirst(), 0.00001, "Current read share");
        assertEquals(maxReadShare, mock.getTrafficFraction(application, zone).getSecond(), 0.00001, "Max read share");
    }

}