1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.restapi.filter;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.yahoo.application.container.handler.Request;
import com.yahoo.config.provision.SystemName;
import com.yahoo.jdisc.http.HttpRequest.Method;
import com.yahoo.jdisc.http.filter.DiscFilterRequest;
import com.yahoo.vespa.hosted.controller.ControllerTester;
import com.yahoo.vespa.hosted.controller.api.role.Role;
import com.yahoo.vespa.hosted.controller.api.role.SecurityContext;
import com.yahoo.vespa.hosted.controller.restapi.ApplicationRequestToDiscFilterRequestWrapper;
import org.junit.Test;
import java.io.IOException;
import java.io.UncheckedIOException;
import java.util.Optional;
import java.util.Set;
import static com.yahoo.container.jdisc.RequestHandlerTestDriver.MockResponseHandler;
import static com.yahoo.jdisc.http.HttpResponse.Status.FORBIDDEN;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
/**
* @author bjorncs
* @author jonmv
*/
public class ControllerAuthorizationFilterTest {
private static final ObjectMapper mapper = new ObjectMapper();
@Test
public void operator() {
ControllerTester tester = new ControllerTester();
SecurityContext securityContext = new SecurityContext(() -> "operator", Set.of(Role.hostedOperator()));
ControllerAuthorizationFilter filter = createFilter(tester);
assertIsAllowed(invokeFilter(filter, createRequest(Method.POST, "/zone/v2/path", securityContext)));
assertIsAllowed(invokeFilter(filter, createRequest(Method.PUT, "/application/v4/user", securityContext)));
assertIsAllowed(invokeFilter(filter, createRequest(Method.GET, "/zone/v1/path", securityContext)));
}
@Test
public void supporter() {
ControllerTester tester = new ControllerTester();
SecurityContext securityContext = new SecurityContext(() -> "operator", Set.of(Role.hostedSupporter()));
ControllerAuthorizationFilter filter = createFilter(tester);
assertIsForbidden(invokeFilter(filter, createRequest(Method.POST, "/zone/v2/path", securityContext)));
assertIsAllowed(invokeFilter(filter, createRequest(Method.GET, "/zone/v1/path", securityContext)));
}
@Test
public void unprivileged() {
ControllerTester tester = new ControllerTester();
SecurityContext securityContext = new SecurityContext(() -> "user", Set.of(Role.everyone()));
ControllerAuthorizationFilter filter = createFilter(tester);
assertIsForbidden(invokeFilter(filter, createRequest(Method.POST, "/zone/v2/path", securityContext)));
assertIsAllowed(invokeFilter(filter, createRequest(Method.PUT, "/application/v4/user", securityContext)));
assertIsAllowed(invokeFilter(filter, createRequest(Method.GET, "/zone/v1/path", securityContext)));
}
@Test
public void unprivilegedInPublic() {
ControllerTester tester = new ControllerTester();
tester.zoneRegistry().setSystemName(SystemName.Public);
SecurityContext securityContext = new SecurityContext(() -> "user", Set.of(Role.everyone()));
ControllerAuthorizationFilter filter = createFilter(tester);
assertIsForbidden(invokeFilter(filter, createRequest(Method.POST, "/zone/v2/path", securityContext)));
assertIsForbidden(invokeFilter(filter, createRequest(Method.PUT, "/application/v4/user", securityContext)));
assertIsAllowed(invokeFilter(filter, createRequest(Method.GET, "/zone/v1/path", securityContext)));
}
private static void assertIsAllowed(Optional<AuthorizationResponse> response) {
assertFalse("Expected no response from filter, but got \"" +
response.map(r -> r.message + "\" (" + r.statusCode + ")").orElse(""),
response.isPresent());
}
private static void assertIsForbidden(Optional<AuthorizationResponse> response) {
assertTrue("Expected a response from filter", response.isPresent());
assertEquals("Invalid status code", FORBIDDEN, response.get().statusCode);
}
private static ControllerAuthorizationFilter createFilter(ControllerTester tester) {
return new ControllerAuthorizationFilter(tester.controller());
}
private static Optional<AuthorizationResponse> invokeFilter(ControllerAuthorizationFilter filter,
DiscFilterRequest request) {
MockResponseHandler responseHandlerMock = new MockResponseHandler();
filter.filter(request, responseHandlerMock);
return Optional.ofNullable(responseHandlerMock.getResponse())
.map(response -> new AuthorizationResponse(response.getStatus(), getErrorMessage(responseHandlerMock)));
}
private static DiscFilterRequest createRequest(Method method, String path, SecurityContext securityContext) {
Request request = new Request(path, new byte[0], Request.Method.valueOf(method.name()), securityContext.principal());
request.getAttributes().put(SecurityContext.ATTRIBUTE_NAME, securityContext);
return new ApplicationRequestToDiscFilterRequestWrapper(request);
}
private static String getErrorMessage(MockResponseHandler responseHandler) {
try {
return mapper.readTree(responseHandler.readAll()).get("message").asText();
} catch (IOException e) {
throw new UncheckedIOException(e);
}
}
private static class AuthorizationResponse {
final int statusCode;
final String message;
AuthorizationResponse(int statusCode, String message) {
this.statusCode = statusCode;
this.message = message;
}
}
}
|
