1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
|
// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.controller.versions;
import com.google.common.collect.ImmutableSet;
import com.yahoo.component.Version;
import com.yahoo.component.Vtag;
import com.yahoo.config.provision.Environment;
import com.yahoo.vespa.hosted.controller.Application;
import com.yahoo.vespa.hosted.controller.Controller;
import com.yahoo.vespa.hosted.controller.ControllerTester;
import com.yahoo.vespa.hosted.controller.api.identifiers.TenantId;
import com.yahoo.vespa.hosted.controller.application.ApplicationPackage;
import com.yahoo.vespa.hosted.controller.deployment.ApplicationPackageBuilder;
import com.yahoo.vespa.hosted.controller.deployment.DeploymentTester;
import com.yahoo.vespa.hosted.controller.versions.VespaVersion.Confidence;
import org.junit.Test;
import java.net.URI;
import java.net.URISyntaxException;
import java.time.Duration;
import java.util.List;
import static com.yahoo.vespa.hosted.controller.application.DeploymentJobs.JobType.productionUsEast3;
import static com.yahoo.vespa.hosted.controller.application.DeploymentJobs.JobType.productionUsWest1;
import static com.yahoo.vespa.hosted.controller.application.DeploymentJobs.JobType.stagingTest;
import static com.yahoo.vespa.hosted.controller.application.DeploymentJobs.JobType.systemTest;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
/**
* Test computing of version status
*
* @author bratseth
*/
public class VersionStatusTest {
@Test
public void testEmptyVersionStatus() {
VersionStatus status = VersionStatus.empty();
assertFalse(status.systemVersion().isPresent());
assertTrue(status.versions().isEmpty());
}
@Test
public void testSystemVersionIsControllerVersionIfConfigserversAreNewer() {
ControllerTester tester = new ControllerTester();
Version largerThanCurrent = new Version(Vtag.currentVersion.getMajor() + 1);
tester.configServer().setDefaultVersion(largerThanCurrent);
VersionStatus versionStatus = VersionStatus.compute(tester.controller());
assertEquals(Vtag.currentVersion, versionStatus.systemVersion().get().versionNumber());
}
@Test
public void testSystemVersionIsVersionOfOldestConfigServer() throws URISyntaxException {
ControllerTester tester = new ControllerTester();
Version oldest = new Version(5);
tester.configServer().versions().put(new URI("https://cfg.prod.corp-us-east-1.test:4443"), oldest);
VersionStatus versionStatus = VersionStatus.compute(tester.controller());
assertEquals(oldest, versionStatus.systemVersion().get().versionNumber());
}
@Test
public void testVersionStatusAfterApplicationUpdates() {
DeploymentTester tester = new DeploymentTester();
ApplicationPackage applicationPackage = new ApplicationPackageBuilder()
.upgradePolicy("default")
.environment(Environment.prod)
.region("us-west-1")
.region("us-east-3")
.build();
Version version1 = new Version("5.1");
Version version2 = new Version("5.2");
tester.upgradeSystem(version1);
// Setup applications
Application app1 = tester.createAndDeploy("app1", 11, applicationPackage);
Application app2 = tester.createAndDeploy("app2", 22, applicationPackage);
Application app3 = tester.createAndDeploy("app3", 33, applicationPackage);
// version2 is released
tester.upgradeSystem(version2);
// - app1 is in production on version1, but then fails in system test on version2
tester.completeUpgradeWithError(app1, version2, applicationPackage, systemTest);
// - app2 is partially in production on version1 and partially on version2
tester.completeUpgradeWithError(app2, version2, applicationPackage, productionUsEast3);
// - app3 is in production on version1, but then fails in staging test on version2
tester.completeUpgradeWithError(app3, version2, applicationPackage, stagingTest);
tester.updateVersionStatus();
List<VespaVersion> versions = tester.controller().versionStatus().versions();
assertEquals("The two versions above exist", 2, versions.size());
System.err.println(tester.controller().applications().deploymentTrigger().jobTimeoutLimit());
VespaVersion v1 = versions.get(0);
assertEquals(version1, v1.versionNumber());
assertEquals("No applications are failing on version1.", ImmutableSet.of(), v1.statistics().failing());
assertEquals("All applications have at least one active production deployment on version 1.", ImmutableSet.of(app1.id(), app2.id(), app3.id()), v1.statistics().production());
assertEquals("No applications have active deployment jobs on version1.", ImmutableSet.of(), v1.statistics().deploying());
VespaVersion v2 = versions.get(1);
assertEquals(version2, v2.versionNumber());
assertEquals("All applications have failed on version2 in at least one zone.", ImmutableSet.of(app1.id(), app2.id(), app3.id()), v2.statistics().failing());
assertEquals("Only app2 has successfully deployed to production on version2.", ImmutableSet.of(app2.id()), v2.statistics().production());
// Should test the below, but can't easily be done with current test framework. This test passes in DeploymentApiTest.
// assertEquals("All applications are being retried on version2.", ImmutableSet.of(app1.id(), app2.id(), app3.id()), v2.statistics().deploying());
}
@Test
public void testVersionConfidence() {
DeploymentTester tester = new DeploymentTester();
Version version0 = new Version("5.0");
tester.upgradeSystem(version0);
// Setup applications - all running on version0
Application canary0 = tester.createAndDeploy("canary0", 1, "canary");
Application canary1 = tester.createAndDeploy("canary1", 2, "canary");
Application canary2 = tester.createAndDeploy("canary2", 3, "canary");
Application default0 = tester.createAndDeploy("default0", 4, "default");
Application default1 = tester.createAndDeploy("default1", 5, "default");
Application default2 = tester.createAndDeploy("default2", 6, "default");
Application default3 = tester.createAndDeploy("default3", 7, "default");
Application default4 = tester.createAndDeploy("default4", 8, "default");
Application default5 = tester.createAndDeploy("default5", 9, "default");
Application default6 = tester.createAndDeploy("default6", 10, "default");
Application default7 = tester.createAndDeploy("default7", 11, "default");
Application default8 = tester.createAndDeploy("default8", 12, "default");
Application default9 = tester.createAndDeploy("default9", 13, "default");
Application conservative0 = tester.createAndDeploy("conservative1", 14, "conservative");
// Applications that do not affect confidence calculation:
// Application without deployment
Application ignored0 = tester.createApplication("ignored0", "tenant1", 1000, 1000L);
// Pull request builds
tester.controllerTester().createApplication(new TenantId("tenant1"),
"ignored1",
"43", 1000);
assertEquals("All applications running on this version: High",
Confidence.high, confidence(tester.controller(), version0));
// New version is released
Version version1 = new Version("5.1");
tester.upgradeSystem(version1);
// Canaries upgrade to new versions and fail
tester.completeUpgrade(canary0, version1, "canary");
tester.completeUpgradeWithError(canary1, version1, "canary", productionUsWest1);
tester.updateVersionStatus();
assertEquals("One canary failed: Broken",
Confidence.broken, confidence(tester.controller(), version1));
// New version is released
Version version2 = new Version("5.2");
tester.upgradeSystem(version2);
assertEquals("Confidence defaults to low for version with no applications",
Confidence.low, confidence(tester.controller(), version2));
// All canaries upgrade successfully
tester.completeUpgrade(canary0, version2, "canary");
tester.jobCompletion(productionUsWest1).application(canary1).unsuccessful().submit();
tester.completeUpgrade(canary1, version2, "canary");
assertEquals("Confidence for remains unchanged for version1: Broken",
Confidence.broken, confidence(tester.controller(), version1));
assertEquals("Nothing has failed but not all canaries have upgraded: Low",
Confidence.low, confidence(tester.controller(), version2));
// Remaining canary upgrades to version2 which raises confidence to normal and more apps upgrade
tester.jobCompletion(systemTest).application(canary2).unsuccessful().submit();
tester.completeUpgrade(canary2, version2, "canary");
tester.upgradeSystem(version2);
assertEquals("Canaries have upgraded: Normal",
Confidence.normal, confidence(tester.controller(), version2));
tester.completeUpgrade(default0, version2, "default");
tester.completeUpgrade(default1, version2, "default");
tester.completeUpgrade(default2, version2, "default");
tester.completeUpgrade(default3, version2, "default");
tester.completeUpgrade(default4, version2, "default");
tester.completeUpgrade(default5, version2, "default");
tester.completeUpgrade(default6, version2, "default");
tester.completeUpgrade(default7, version2, "default");
tester.updateVersionStatus();
// Remember confidence across restart
tester.restartController();
assertEquals("Confidence remains unchanged for version0: High",
Confidence.high, confidence(tester.controller(), version0));
assertEquals("All canaries deployed + < 90% of defaults: Normal",
Confidence.normal, confidence(tester.controller(), version2));
assertTrue("Status for version without applications is removed",
tester.controller().versionStatus().versions().stream()
.noneMatch(vespaVersion -> vespaVersion.versionNumber().equals(version1)));
// Another default application upgrades, raising confidence to high
tester.completeUpgrade(default8, version2, "default");
tester.completeUpgrade(default9, version2, "default");
tester.updateVersionStatus();
assertEquals("Confidence remains unchanged for version0: High",
Confidence.high, confidence(tester.controller(), version0));
assertEquals("90% of defaults deployed successfully: High",
VespaVersion.Confidence.high, confidence(tester.controller(), version2));
// A new version is released, all canaries upgrade successfully, but enough "default" apps fail to mark version
// as broken
Version version3 = new Version("5.3");
tester.upgradeSystem(version3);
tester.completeUpgrade(canary0, version3, "canary");
tester.completeUpgrade(canary1, version3, "canary");
tester.completeUpgrade(canary2, version3, "canary");
tester.upgradeSystem(version3);
tester.completeUpgradeWithError(default0, version3, "default", stagingTest);
tester.completeUpgradeWithError(default1, version3, "default", stagingTest);
tester.completeUpgradeWithError(default2, version3, "default", stagingTest);
tester.completeUpgradeWithError(default9, version3, "default", stagingTest);
tester.updateVersionStatus();
assertEquals("Confidence remains unchanged for version0: High",
Confidence.high, confidence(tester.controller(), version0));
assertEquals("Confidence remains unchanged for version2: High",
Confidence.high, confidence(tester.controller(), version2));
assertEquals("40% of defaults failed: Broken",
VespaVersion.Confidence.broken, confidence(tester.controller(), version3));
// Test version order
List<VespaVersion> versions = tester.controller().versionStatus().versions();
assertEquals(3, versions.size());
assertEquals("5", versions.get(0).versionNumber().toString());
assertEquals("5.2", versions.get(1).versionNumber().toString());
assertEquals("5.3", versions.get(2).versionNumber().toString());
}
@Test
public void testConfidenceOverride() {
DeploymentTester tester = new DeploymentTester();
Version version0 = new Version("5.0");
tester.upgradeSystem(version0);
// Create and deploy application on current version
Application app = tester.createAndDeploy("app", 1, "canary");
tester.updateVersionStatus();
assertEquals(Confidence.high, confidence(tester.controller(), version0));
// Override confidence
tester.upgrader().overrideConfidence(version0, Confidence.broken);
tester.updateVersionStatus();
assertEquals(Confidence.broken, confidence(tester.controller(), version0));
// New version is released and application upgrades
Version version1 = new Version("5.1");
tester.upgradeSystem(version1);
tester.completeUpgrade(app, version1, "canary");
tester.updateVersionStatus();
assertEquals(Confidence.high, confidence(tester.controller(), version1));
// Stale override was removed
assertFalse("Stale override removed", tester.controller().curator().readConfidenceOverrides()
.keySet().contains(version0));
}
private Confidence confidence(Controller controller, Version version) {
return controller.versionStatus().versions().stream()
.filter(v -> v.statistics().version().equals(version))
.findFirst()
.map(VespaVersion::confidence)
.orElseThrow(() -> new IllegalArgumentException("Expected to find version: " + version));
}
}
|
