1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
|
// Copyright Verizon Media. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
#include <vespa/vespalib/testkit/test_kit.h>
#include <vespa/vespalib/testkit/time_bomb.h>
#include <vespa/vespalib/util/stringfmt.h>
#include <vespa/vespalib/data/slime/slime.h>
#include <vespa/vespalib/util/child_process.h>
#include <vespa/vespalib/data/input.h>
#include <vespa/vespalib/data/output.h>
#include <vespa/vespalib/data/simple_buffer.h>
#include <vespa/vespalib/util/size_literals.h>
#include <vespa/eval/eval/test/test_io.h>
using namespace vespalib;
using namespace vespalib::eval::test;
using vespalib::make_string_short::fmt;
using vespalib::slime::JsonFormat;
using vespalib::slime::Inspector;
vespalib::string module_build_path("../../../../");
vespalib::string binary = module_build_path + "src/apps/eval_expr/vespa-eval-expr";
vespalib::string server_cmd = binary + " json-repl";
//-----------------------------------------------------------------------------
void read_until_eof(Input &input) {
for (auto mem = input.obtain(); mem.size > 0; mem = input.obtain()) {
input.evict(mem.size);
}
}
// Output adapter used to write to stdin of a child process
class ChildIn : public Output {
ChildProcess &_child;
SimpleBuffer _output;
public:
ChildIn(ChildProcess &child) : _child(child) {}
WritableMemory reserve(size_t bytes) override {
return _output.reserve(bytes);
}
Output &commit(size_t bytes) override {
_output.commit(bytes);
Memory buf = _output.obtain();
ASSERT_TRUE(_child.write(buf.data, buf.size));
_output.evict(buf.size);
return *this;
}
};
// Input adapter used to read from stdout of a child process
class ChildOut : public Input {
ChildProcess &_child;
SimpleBuffer _input;
public:
ChildOut(ChildProcess &child)
: _child(child)
{
EXPECT_TRUE(_child.running());
EXPECT_TRUE(!_child.failed());
}
Memory obtain() override {
if ((_input.get().size == 0) && !_child.eof()) {
WritableMemory buf = _input.reserve(4_Ki);
uint32_t res = _child.read(buf.data, buf.size);
ASSERT_TRUE((res > 0) || _child.eof());
_input.commit(res);
}
return _input.obtain();
}
Input &evict(size_t bytes) override {
_input.evict(bytes);
return *this;
}
};
//-----------------------------------------------------------------------------
struct Result {
vespalib::string error;
vespalib::string result;
std::vector<std::pair<vespalib::string, vespalib::string>> steps;
Result(const Inspector &obj)
: error(obj["error"].asString().make_string()),
result(obj["result"].asString().make_string()),
steps()
{
const auto &arr = obj["steps"];
for (size_t i = 0; i < arr.entries(); ++i) {
steps.emplace_back(arr[i]["class"].asString().make_string(),
arr[i]["symbol"].asString().make_string());
}
}
void verify_result(const vespalib::string &expect) {
EXPECT_EQUAL(error, "");
EXPECT_EQUAL(result, expect);
}
void verify_error(const vespalib::string &expect) {
EXPECT_EQUAL(steps.size(), 0u);
EXPECT_EQUAL(result, "");
fprintf(stderr, "... does error '%s' contain message '%s'?\n",
error.c_str(), expect.c_str());
EXPECT_TRUE(error.find(expect) != error.npos);
}
~Result();
};
Result::~Result() = default;
void dump_message(const char *prefix, const Slime &slime) {
SimpleBuffer buf;
slime::JsonFormat::encode(slime, buf, true);
auto str = buf.get().make_string();
fprintf(stderr, "%s%s\n", prefix, str.c_str());
}
class Server {
private:
TimeBomb _bomb;
ChildProcess _child;
ChildIn _child_stdin;
ChildOut _child_stdout;
public:
Server()
: _bomb(60),
_child(server_cmd.c_str()),
_child_stdin(_child),
_child_stdout(_child) {}
~Server();
Slime invoke(const Slime &req) {
dump_message("request --> ", req);
write_compact(req, _child_stdin);
Slime reply;
ASSERT_TRUE(JsonFormat::decode(_child_stdout, reply));
dump_message(" reply <-- ", reply);
return reply;
}
Result eval(const vespalib::string &expr, const vespalib::string &name = {}, bool verbose = false) {
Slime req;
auto &obj = req.setObject();
obj.setString("expr", expr.c_str());
if (!name.empty()) {
obj.setString("name", name.c_str());
}
if (verbose) {
obj.setBool("verbose", true);
}
Slime reply = invoke(req);
return {reply.get()};
}
};
Server::~Server() {
_child.close();
read_until_eof(_child_stdout);
ASSERT_TRUE(_child.wait());
ASSERT_TRUE(!_child.running());
ASSERT_TRUE(!_child.failed());
}
//-----------------------------------------------------------------------------
TEST("print server command") {
fprintf(stderr, "server cmd: %s\n", server_cmd.c_str());
}
//-----------------------------------------------------------------------------
TEST_F("require that simple evaluation works", Server()) {
TEST_DO(f1.eval("2+2").verify_result("4"));
}
TEST_F("require that multiple dependent expressions work", Server()) {
TEST_DO(f1.eval("2+2", "a").verify_result("4"));
TEST_DO(f1.eval("a+2", "b").verify_result("6"));
TEST_DO(f1.eval("a+b").verify_result("10"));
}
TEST_F("require that symbols can be overwritten", Server()) {
TEST_DO(f1.eval("1", "a").verify_result("1"));
TEST_DO(f1.eval("a+1", "a").verify_result("2"));
TEST_DO(f1.eval("a+1", "a").verify_result("3"));
TEST_DO(f1.eval("a+1", "a").verify_result("4"));
}
TEST_F("require that tensor result is returned in verbose verbatim form", Server()) {
TEST_DO(f1.eval("1", "a").verify_result("1"));
TEST_DO(f1.eval("2", "b").verify_result("2"));
TEST_DO(f1.eval("3", "c").verify_result("3"));
TEST_DO(f1.eval("tensor(x[3]):[a,b,c]").verify_result("tensor(x[3]):{{x:0}:1,{x:1}:2,{x:2}:3}"));
}
TEST_F("require that execution steps can be extracted", Server()) {
TEST_DO(f1.eval("1", "a").verify_result("1"));
TEST_DO(f1.eval("2", "b").verify_result("2"));
TEST_DO(f1.eval("3", "c").verify_result("3"));
auto res1 = f1.eval("a+b+c");
auto res2 = f1.eval("a+b+c", "", true);
EXPECT_EQUAL(res1.steps.size(), 0u);
EXPECT_EQUAL(res2.steps.size(), 5u);
for (const auto &step: res2.steps) {
fprintf(stderr, "step:\n class: %s\n symbol: %s\n",
step.first.c_str(), step.second.c_str());
}
}
//-----------------------------------------------------------------------------
TEST_F("require that operation batching works", Server()) {
Slime req;
auto &arr = req.setArray();
auto &req1 = arr.addObject();
req1.setString("expr", "2+2");
req1.setString("name", "a");
auto &req2 = arr.addObject();
req2.setString("expr", "a+2");
req2.setString("name", "b");
auto &req3 = arr.addObject();
req3.setString("expr", "this does not parse");
auto &req4 = arr.addObject();
req4.setString("expr", "a+b");
Slime reply = f1.invoke(req);
EXPECT_EQUAL(reply.get().entries(), 4u);
EXPECT_TRUE(reply[2]["error"].asString().size > 0);
EXPECT_EQUAL(reply[3]["result"].asString().make_string(), "10");
}
TEST_F("require that empty operation batch works", Server()) {
Slime req;
req.setArray();
Slime reply = f1.invoke(req);
EXPECT_TRUE(reply.get().type().getId() == slime::ARRAY::ID);
EXPECT_EQUAL(reply.get().entries(), 0u);
}
//-----------------------------------------------------------------------------
TEST_F("require that empty expression produces error", Server()) {
TEST_DO(f1.eval("").verify_error("missing expression"));
}
TEST_F("require that parse error produces error", Server()) {
TEST_DO(f1.eval("this does not parse").verify_error("expression parsing failed"));
}
TEST_F("require that type issues produces error", Server()) {
TEST_DO(f1.eval("tensor(x[3]):[1,2,3]", "a").verify_result("tensor(x[3]):{{x:0}:1,{x:1}:2,{x:2}:3}"));
TEST_DO(f1.eval("tensor(x[2]):[4,5]", "b").verify_result("tensor(x[2]):{{x:0}:4,{x:1}:5}"));
TEST_DO(f1.eval("a+b").verify_error("type resolving failed"));
}
//-----------------------------------------------------------------------------
TEST_MAIN_WITH_PROCESS_PROXY() { TEST_RUN_ALL(); }
|
