1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
#include <vespa/eval/eval/fast_value.h>
#include <vespa/eval/eval/tensor_function.h>
#include <vespa/eval/eval/test/eval_fixture.h>
#include <vespa/eval/eval/test/gen_spec.h>
#include <vespa/eval/instruction/dense_dot_product_function.h>
#include <vespa/vespalib/testkit/test_kit.h>
#include <vespa/vespalib/util/stash.h>
#include <vespa/vespalib/util/stringfmt.h>
#include <vespa/log/log.h>
LOG_SETUP("dense_dot_product_function_test");
using namespace vespalib;
using namespace vespalib::eval;
using namespace vespalib::eval::test;
const ValueBuilderFactory &prod_factory = FastValueBuilderFactory::get();
TensorSpec makeTensor(size_t numCells, double cellBias) {
return GenSpec(cellBias).idx("x", numCells);
}
const double leftBias = 3.0;
const double rightBias = 5.0;
double calcDotProduct(size_t numCells) {
double result = 0;
for (size_t i = 0; i < numCells; ++i) {
result += (i + leftBias) * (i + rightBias);
}
return result;
}
void check_gen_with_result(size_t l, size_t r, double wanted) {
EvalFixture::ParamRepo param_repo;
param_repo.add("a", makeTensor(l, leftBias));
param_repo.add("b", makeTensor(r, rightBias));
vespalib::string expr = "reduce(a*b,sum,x)";
EvalFixture evaluator(prod_factory, expr, param_repo, true);
EXPECT_EQUAL(GenSpec(wanted).gen(), evaluator.result());
EXPECT_EQUAL(evaluator.result(), EvalFixture::ref(expr, param_repo));
auto info = evaluator.find_all<DenseDotProductFunction>();
EXPECT_EQUAL(info.size(), 1u);
};
// this should not be possible to set up:
// TEST("require that empty dot product is correct")
TEST("require that basic dot product with equal sizes is correct") {
check_gen_with_result(2, 2, (3.0 * 5.0) + (4.0 * 6.0));
}
//-----------------------------------------------------------------------------
void assertDotProduct(size_t numCells) {
check_gen_with_result(numCells, numCells, calcDotProduct(numCells));
}
void assertDotProduct(size_t lhsNumCells, size_t rhsNumCells) {
size_t numCells = std::min(lhsNumCells, rhsNumCells);
check_gen_with_result(lhsNumCells, rhsNumCells, calcDotProduct(numCells));
}
TEST("require that dot product with equal sizes is correct") {
TEST_DO(assertDotProduct(8));
TEST_DO(assertDotProduct(16));
TEST_DO(assertDotProduct(32));
TEST_DO(assertDotProduct(64));
TEST_DO(assertDotProduct(128));
TEST_DO(assertDotProduct(256));
TEST_DO(assertDotProduct(512));
TEST_DO(assertDotProduct(1024));
TEST_DO(assertDotProduct(8 + 3));
TEST_DO(assertDotProduct(16 + 3));
TEST_DO(assertDotProduct(32 + 3));
TEST_DO(assertDotProduct(64 + 3));
TEST_DO(assertDotProduct(128 + 3));
TEST_DO(assertDotProduct(256 + 3));
TEST_DO(assertDotProduct(512 + 3));
TEST_DO(assertDotProduct(1024 + 3));
}
//-----------------------------------------------------------------------------
struct FunInfo {
using LookFor = DenseDotProductFunction;
void verify(const LookFor &fun) const {
EXPECT_TRUE(fun.result_is_mutable());
}
};
void assertOptimized(const vespalib::string &expr) {
TEST_STATE(expr.c_str());
auto all_types = CellTypeSpace(CellTypeUtils::list_types(), 2);
EvalFixture::verify<FunInfo>(expr, {FunInfo{}}, all_types);
}
void assertNotOptimized(const vespalib::string &expr) {
TEST_STATE(expr.c_str());
CellTypeSpace just_double({CellType::DOUBLE}, 2);
EvalFixture::verify<FunInfo>(expr, {}, just_double);
}
TEST("require that dot product works with tensor function") {
TEST_DO(assertOptimized("reduce(x5$1*x5$2,sum)"));
TEST_DO(assertOptimized("reduce(x5$1*x5$2,sum,x)"));
TEST_DO(assertOptimized("reduce(join(x5$1,x5$2,f(x,y)(x*y)),sum)"));
TEST_DO(assertOptimized("reduce(join(x5$1,x5$2,f(x,y)(x*y)),sum,x)"));
}
TEST("require that dot product with compatible dimensions is optimized") {
TEST_DO(assertOptimized("reduce(x1$1*x1$2,sum)"));
TEST_DO(assertOptimized("reduce(x3$1*x3$2,sum)"));
TEST_DO(assertOptimized("reduce(x5$1*x5$2,sum)"));
}
TEST("require that dot product with incompatible dimensions is NOT optimized") {
TEST_DO(assertNotOptimized("reduce(x3*y3,sum)"));
TEST_DO(assertNotOptimized("reduce(y3*x3,sum)"));
TEST_DO(assertNotOptimized("reduce(x3*x3y3,sum)"));
TEST_DO(assertNotOptimized("reduce(x3y3*x3,sum)"));
}
TEST("require that expressions similar to dot product are not optimized") {
TEST_DO(assertNotOptimized("reduce(x3$1*x3$2,prod)"));
TEST_DO(assertNotOptimized("reduce(x3$1+x3$2,sum)"));
TEST_DO(assertNotOptimized("reduce(join(x3$1,x3$2,f(x,y)(x+y)),sum)"));
TEST_DO(assertNotOptimized("reduce(join(x3$1,x3$2,f(x,y)(x*x)),sum)"));
TEST_DO(assertNotOptimized("reduce(join(x3$1,x3$2,f(x,y)(y*y)),sum)"));
// TEST_DO(assertNotOptimized("reduce(join(x3$1,x3$2,f(x,y)(y*x)),sum)"));
}
TEST("require that multi-dimensional dot product can be optimized") {
TEST_DO(assertOptimized("reduce(x3y3$1*x3y3$2,sum)"));
TEST_DO(assertOptimized("reduce(x3y3$1*x3y3$2,sum)"));
}
TEST("require that result must be double to trigger optimization") {
TEST_DO(assertOptimized("reduce(x3y3$1*x3y3$2,sum,x,y)"));
TEST_DO(assertNotOptimized("reduce(x3y3$1*x3y3$2,sum,x)"));
TEST_DO(assertNotOptimized("reduce(x3y3$1*x3y3$2,sum,y)"));
}
void verify_compatible(const vespalib::string &a, const vespalib::string &b) {
auto a_type = ValueType::from_spec(a);
auto b_type = ValueType::from_spec(b);
EXPECT_TRUE(!a_type.is_error());
EXPECT_TRUE(!b_type.is_error());
EXPECT_TRUE(DenseDotProductFunction::compatible_types(ValueType::double_type(), a_type, b_type));
EXPECT_TRUE(DenseDotProductFunction::compatible_types(ValueType::double_type(), b_type, a_type));
}
void verify_not_compatible(const vespalib::string &a, const vespalib::string &b) {
auto a_type = ValueType::from_spec(a);
auto b_type = ValueType::from_spec(b);
EXPECT_TRUE(!a_type.is_error());
EXPECT_TRUE(!b_type.is_error());
EXPECT_TRUE(!DenseDotProductFunction::compatible_types(ValueType::double_type(), a_type, b_type));
EXPECT_TRUE(!DenseDotProductFunction::compatible_types(ValueType::double_type(), b_type, a_type));
}
TEST("require that type compatibility test is appropriate") {
TEST_DO(verify_compatible("tensor(x[5])", "tensor(x[5])"));
TEST_DO(verify_compatible("tensor(x[5])", "tensor<float>(x[5])"));
TEST_DO(verify_compatible("tensor<float>(x[5])", "tensor(x[5])"));
TEST_DO(verify_compatible("tensor<float>(x[5])", "tensor<float>(x[5])"));
TEST_DO(verify_not_compatible("tensor(x[5])", "tensor(x[6])"));
TEST_DO(verify_not_compatible("tensor(x[5])", "tensor(y[5])"));
TEST_DO(verify_compatible("tensor(x[3],y[7],z[9])", "tensor(x[3],y[7],z[9])"));
TEST_DO(verify_not_compatible("tensor(x[3],y[7],z[9])", "tensor(x[5],y[7],z[9])"));
TEST_DO(verify_not_compatible("tensor(x[9],y[7],z[5])", "tensor(x[5],y[7],z[9])"));
}
TEST("require that optimization also works for tensors with non-double cells") {
TEST_DO(assertOptimized("reduce(x5$1*x5$2,sum)"));
TEST_DO(assertOptimized("reduce(x5$1*x5$2,sum)"));
TEST_DO(assertOptimized("reduce(x5$1*x5$2,sum)"));
}
//-----------------------------------------------------------------------------
TEST_MAIN() { TEST_RUN_ALL(); }
|
