1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
|
// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.node.admin.maintenance.acl;
import com.google.common.net.InetAddresses;
import com.yahoo.vespa.hosted.dockerapi.Container;
import com.yahoo.vespa.hosted.dockerapi.ContainerName;
import com.yahoo.vespa.hosted.dockerapi.DockerImage;
import com.yahoo.vespa.hosted.dockerapi.ProcessResult;
import com.yahoo.vespa.hosted.node.admin.component.Environment;
import com.yahoo.vespa.hosted.node.admin.configserver.noderepository.Acl;
import com.yahoo.vespa.hosted.node.admin.configserver.noderepository.NodeRepository;
import com.yahoo.vespa.hosted.node.admin.docker.DockerNetworking;
import com.yahoo.vespa.hosted.node.admin.docker.DockerOperations;
import com.yahoo.vespa.hosted.node.admin.task.util.network.IPAddressesMock;
import com.yahoo.vespa.hosted.node.admin.task.util.network.IPVersion;
import org.junit.Before;
import org.junit.Test;
import java.net.InetAddress;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.anyVararg;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
public class AclMaintainerTest {
private static final String NODE_ADMIN_HOSTNAME = "node-admin.region-1.yahoo.com";
private final IPAddressesMock ipAddresses = new IPAddressesMock();
private final DockerOperations dockerOperations = mock(DockerOperations.class);
private final NodeRepository nodeRepository = mock(NodeRepository.class);
private final Map<String, Container> containers = new HashMap<>();
private final List<Container> containerList = new ArrayList<>();
private final Environment env = mock(Environment.class);
private final AclMaintainer aclMaintainer =
new AclMaintainer(dockerOperations, nodeRepository, NODE_ADMIN_HOSTNAME, ipAddresses, env);
@Before
public void before() {
when(dockerOperations.getAllManagedContainers()).thenReturn(containerList);
when(env.getCloud()).thenReturn("AWS");
when(env.getDockerNetworking()).thenReturn(DockerNetworking.NPT);
}
@Test
public void no_redirect_in_yahoo() {
when(env.getCloud()).thenReturn("YAHOO");
when(env.getDockerNetworking()).thenReturn(DockerNetworking.MACVLAN);
Container container = addContainer("container1", "container1.host.com", Container.State.RUNNING);
Map<String, Acl> acls = makeAcl(container.hostname, "4321", "2001::1");
when(nodeRepository.getAcls(NODE_ADMIN_HOSTNAME)).thenReturn(acls);
whenListRules(container.name, "filter", IPVersion.IPv6, "");
whenListRules(container.name, "filter", IPVersion.IPv4, "");
aclMaintainer.run();
verify(dockerOperations, never()).executeCommandInNetworkNamespace(eq(container.name), eq("iptables"), eq("-S"), eq("-t"), eq("nat"));
verify(dockerOperations, never()).executeCommandInNetworkNamespace(eq(container.name), eq("ip6tables"), eq("-S"), eq("-t"), eq("nat"));
verify(dockerOperations, times(1)).executeCommandInNetworkNamespace(eq(container.name), eq("iptables-restore"), anyVararg());
verify(dockerOperations, times(1)).executeCommandInNetworkNamespace(eq(container.name), eq("ip6tables-restore"), anyVararg());
}
@Test
public void empty_trusted_ports_are_handled() {
Container container = addContainer("container1", "container1.host.com", Container.State.RUNNING);
Map<String, Acl> acls = makeAcl(container.hostname, "4321", "2001::1");
when(nodeRepository.getAcls(NODE_ADMIN_HOSTNAME)).thenReturn(acls);
whenListRules(container.name, "filter", IPVersion.IPv6, "");
whenListRules(container.name, "filter", IPVersion.IPv4, "");
whenListRules(container.name, "nat", IPVersion.IPv4, "");
whenListRules(container.name, "nat", IPVersion.IPv6, "");
aclMaintainer.run();
verify(dockerOperations, times(1)).executeCommandInNetworkNamespace(eq(container.name), eq("iptables-restore"), anyVararg()); //we don;t have a ip4 address for the container so no redirect either
verify(dockerOperations, times(2)).executeCommandInNetworkNamespace(eq(container.name), eq("ip6tables-restore"), anyVararg());
}
@Test
public void configures_container_acl_when_iptables_differs() {
Container container = addContainer("container1", "container1.host.com", Container.State.RUNNING);
Map<String, Acl> acls = makeAcl(container.hostname, "4321", "2001::1");
when(nodeRepository.getAcls(NODE_ADMIN_HOSTNAME)).thenReturn(acls);
whenListRules(container.name, "filter", IPVersion.IPv6, "");
whenListRules(container.name, "filter", IPVersion.IPv4, "");
whenListRules(container.name, "nat", IPVersion.IPv4, "");
whenListRules(container.name, "nat", IPVersion.IPv6, "");
aclMaintainer.run();
verify(dockerOperations, times(1)).executeCommandInNetworkNamespace(eq(container.name), eq("iptables-restore"), anyVararg()); //we don;t have a ip4 address for the container so no redirect either
verify(dockerOperations, times(2)).executeCommandInNetworkNamespace(eq(container.name), eq("ip6tables-restore"), anyVararg());
}
@Test
public void ignore_containers_not_running() {
Container container = addContainer("container1", "container1.host.com", Container.State.EXITED);
Map<String, Acl> acls = makeAcl(container.hostname, "4321", "2001::1");
when(nodeRepository.getAcls(NODE_ADMIN_HOSTNAME)).thenReturn(acls);
aclMaintainer.run();
verify(dockerOperations, never()).executeCommandInNetworkNamespace(eq(container.name), anyVararg());
}
@Test
public void only_configure_iptables_for_ipversion_that_differs() {
Container container = addContainer("container1", "container1.host.com", Container.State.RUNNING);
Map<String, Acl> acls = makeAcl(container.hostname, "4321,2345,22", "2001::1", "fd01:1234::4321");
when(nodeRepository.getAcls(NODE_ADMIN_HOSTNAME)).thenReturn(acls);
String IPV6 = "-P INPUT ACCEPT\n" +
"-P FORWARD ACCEPT\n" +
"-P OUTPUT ACCEPT\n" +
"-A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT\n" +
"-A INPUT -i lo -j ACCEPT\n" +
"-A INPUT -p ipv6-icmp -j ACCEPT\n" +
"-A INPUT -p tcp -m multiport --dports 22,2345,4321 -j ACCEPT\n" +
"-A INPUT -s 2001::1/128 -j ACCEPT\n" +
"-A INPUT -s fd01:1234::4321/128 -j ACCEPT\n" +
"-A INPUT -j REJECT --reject-with icmp6-port-unreachable";
String NATv6 = "-P PREROUTING ACCEPT\n" +
"-P INPUT ACCEPT\n" +
"-P OUTPUT ACCEPT\n" +
"-P POSTROUTING ACCEPT\n" +
"-A OUTPUT -d 3001::1/128 -j REDIRECT";
whenListRules(container.name, "filter", IPVersion.IPv6, IPV6);
whenListRules(container.name, "filter", IPVersion.IPv4, ""); //IPv4 will then differ from wanted
whenListRules(container.name, "nat", IPVersion.IPv6, NATv6);
aclMaintainer.run();
verify(dockerOperations, times(1)).executeCommandInNetworkNamespace(eq(container.name), eq("iptables-restore"), anyVararg());
verify(dockerOperations, never()).executeCommandInNetworkNamespace(eq(container.name), eq("ip6tables-restore"), anyVararg());
}
@Test
public void does_not_configure_acl_if_iptables_dualstack_are_ok() {
Container container = addContainer("container1", "container1.host.com", Container.State.RUNNING);
Map<String, Acl> acls = makeAcl(container.hostname, "22,4443,2222", "2001::1", "192.64.13.2");
when(nodeRepository.getAcls(NODE_ADMIN_HOSTNAME)).thenReturn(acls);
String IPV4_FILTER = "-P INPUT ACCEPT\n" +
"-P FORWARD ACCEPT\n" +
"-P OUTPUT ACCEPT\n" +
"-A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT\n" +
"-A INPUT -i lo -j ACCEPT\n" +
"-A INPUT -p icmp -j ACCEPT\n" +
"-A INPUT -p tcp -m multiport --dports 22,2222,4443 -j ACCEPT\n" +
"-A INPUT -s 192.64.13.2/32 -j ACCEPT\n" +
"-A INPUT -j REJECT --reject-with icmp-port-unreachable";
String IPV6_FILTER = "-P INPUT ACCEPT\n" +
"-P FORWARD ACCEPT\n" +
"-P OUTPUT ACCEPT\n" +
"-A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT\n" +
"-A INPUT -i lo -j ACCEPT\n" +
"-A INPUT -p ipv6-icmp -j ACCEPT\n" +
"-A INPUT -p tcp -m multiport --dports 22,2222,4443 -j ACCEPT\n" +
"-A INPUT -s 2001::1/128 -j ACCEPT\n" +
"-A INPUT -j REJECT --reject-with icmp6-port-unreachable";
String IPV6_NAT = "-P PREROUTING ACCEPT\n" +
"-P INPUT ACCEPT\n" +
"-P OUTPUT ACCEPT\n" +
"-P POSTROUTING ACCEPT\n" +
"-A OUTPUT -d 3001::1/128 -j REDIRECT";
whenListRules(container.name, "filter", IPVersion.IPv6, IPV6_FILTER);
whenListRules(container.name, "nat", IPVersion.IPv6, IPV6_NAT);
whenListRules(container.name, "filter", IPVersion.IPv4, IPV4_FILTER);
aclMaintainer.run();
verify(dockerOperations, never()).executeCommandInNetworkNamespace(any(), eq("ip6tables-restore"), anyVararg());
verify(dockerOperations, never()).executeCommandInNetworkNamespace(any(), eq("iptables-restore"), anyVararg());
}
@Test
public void rollback_is_attempted_when_applying_acl_fail() {
Container container = addContainer("container1", "container1.host.com", Container.State.RUNNING);
Map<String, Acl> acls = makeAcl(container.hostname, "4321", "2001::1");
when(nodeRepository.getAcls(NODE_ADMIN_HOSTNAME)).thenReturn(acls);
String IPV6_NAT = "-P PREROUTING ACCEPT\n" +
"-P INPUT ACCEPT\n" +
"-P OUTPUT ACCEPT\n" +
"-P POSTROUTING ACCEPT\n" +
"-A OUTPUT -d 3001::1/128 -j REDIRECT";
whenListRules(container.name, "filter", IPVersion.IPv6, "");
whenListRules(container.name, "filter", IPVersion.IPv4, "");
whenListRules(container.name, "nat", IPVersion.IPv6, IPV6_NAT);
when(dockerOperations.executeCommandInNetworkNamespace(
eq(container.name),
eq("ip6tables-restore"), anyVararg())).thenThrow(new RuntimeException("iptables restore failed"));
when(dockerOperations.executeCommandInNetworkNamespace(
eq(container.name),
eq("iptables-restore"), anyVararg())).thenThrow(new RuntimeException("iptables restore failed"));
aclMaintainer.run();
verify(dockerOperations, times(1)).executeCommandInNetworkNamespace(eq(container.name),
eq("ip6tables"), eq("-F"), eq("-t"), eq("filter"));
verify(dockerOperations, times(1)).executeCommandInNetworkNamespace(eq(container.name),
eq("iptables"), eq("-F"), eq("-t"), eq("filter"));
}
private void whenListRules(ContainerName name, String table, IPVersion ipVersion, String result) {
when(dockerOperations.executeCommandInNetworkNamespace(
eq(name),
eq(ipVersion.iptablesCmd()), eq("-S"), eq("-t"), eq(table)))
.thenReturn(new ProcessResult(0, result, ""));
}
private Container addContainer(String name, String hostname, Container.State state) {
final ContainerName containerName = new ContainerName(name);
final Container container = new Container(hostname, new DockerImage("mock"), null,
containerName, state, 2);
containers.put(name, container);
containerList.add(container);
ipAddresses.addAddress(hostname, "3001::" + containers.size());
return container;
}
private Map<String, Acl> makeAcl(String containerHostname, String portsCommaSeparated, String... addresses) {
Map<String, Acl> map = new HashMap<>();
List<Integer> ports = Arrays.stream(portsCommaSeparated.split(","))
.map(Integer::valueOf)
.collect(Collectors.toList());
List<InetAddress> hosts = Arrays.stream(addresses)
.map(InetAddresses::forString)
.collect(Collectors.toList());
Acl acl = new Acl(ports, hosts);
map.put(containerHostname, acl);
return map;
}
}
|
