1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
// Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.vespa.hosted.node.admin.nodeadmin;
import com.yahoo.jdisc.test.TestTimer;
import com.yahoo.vespa.hosted.node.admin.container.metrics.Metrics;
import com.yahoo.vespa.hosted.node.admin.nodeagent.NodeAgentContext;
import com.yahoo.vespa.hosted.node.admin.nodeagent.NodeAgentContextImpl;
import com.yahoo.vespa.test.file.TestFileSystem;
import org.junit.jupiter.api.Test;
import org.mockito.InOrder;
import java.time.Duration;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import static com.yahoo.vespa.hosted.node.admin.nodeadmin.NodeAdminImpl.NodeAgentWithScheduler;
import static com.yahoo.vespa.hosted.node.admin.nodeadmin.NodeAdminImpl.NodeAgentWithSchedulerFactory;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyBoolean;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.inOrder;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when;
/**
* @author bakksjo
*/
public class NodeAdminImplTest {
private final NodeAgentWithSchedulerFactory nodeAgentWithSchedulerFactory = mock(NodeAgentWithSchedulerFactory.class);
private final TestTimer timer = new TestTimer();
private final ProcMeminfoReader procMeminfoReader = mock(ProcMeminfoReader.class);
private final NodeAdminImpl nodeAdmin = new NodeAdminImpl(nodeAgentWithSchedulerFactory,
new Metrics(), timer, Duration.ZERO, Duration.ZERO, procMeminfoReader);
@Test
void nodeAgentsAreProperlyLifeCycleManaged() {
final NodeAgentContext context1 = createNodeAgentContext("host1.test.yahoo.com");
final NodeAgentContext context2 = createNodeAgentContext("host2.test.yahoo.com");
final NodeAgentWithScheduler nodeAgent1 = mockNodeAgentWithSchedulerFactory(context1);
final NodeAgentWithScheduler nodeAgent2 = mockNodeAgentWithSchedulerFactory(context2);
final InOrder inOrder = inOrder(nodeAgentWithSchedulerFactory, nodeAgent1, nodeAgent2);
nodeAdmin.refreshContainersToRun(Set.of());
verifyNoMoreInteractions(nodeAgentWithSchedulerFactory);
nodeAdmin.refreshContainersToRun(Set.of(context1));
inOrder.verify(nodeAgent1).start();
inOrder.verify(nodeAgent2, never()).start();
inOrder.verify(nodeAgent1, never()).stopForRemoval();
nodeAdmin.refreshContainersToRun(Set.of(context1));
inOrder.verify(nodeAgentWithSchedulerFactory, never()).create(any());
inOrder.verify(nodeAgent1, never()).start();
inOrder.verify(nodeAgent1, never()).stopForRemoval();
nodeAdmin.refreshContainersToRun(Set.of());
inOrder.verify(nodeAgentWithSchedulerFactory, never()).create(any());
verify(nodeAgent1).stopForRemoval();
nodeAdmin.refreshContainersToRun(Set.of(context2));
inOrder.verify(nodeAgent2).start();
inOrder.verify(nodeAgent2, never()).stopForRemoval();
inOrder.verify(nodeAgent1, never()).stopForRemoval();
nodeAdmin.refreshContainersToRun(Set.of());
inOrder.verify(nodeAgentWithSchedulerFactory, never()).create(any());
inOrder.verify(nodeAgent2, never()).start();
inOrder.verify(nodeAgent2).stopForRemoval();
inOrder.verify(nodeAgent1, never()).start();
inOrder.verify(nodeAgent1, never()).stopForRemoval();
}
@Test
void testSetFrozen() {
Set<NodeAgentContext> contexts = new HashSet<>();
List<NodeAgentWithScheduler> nodeAgents = new ArrayList<>();
for (int i = 0; i < 3; i++) {
NodeAgentContext context = createNodeAgentContext("host" + i + ".test.yahoo.com");
NodeAgentWithScheduler nodeAgent = mockNodeAgentWithSchedulerFactory(context);
contexts.add(context);
nodeAgents.add(nodeAgent);
}
nodeAdmin.refreshContainersToRun(contexts);
assertTrue(nodeAdmin.isFrozen()); // Initially everything is frozen to force convergence
mockNodeAgentSetFrozenResponse(nodeAgents, true, true, true);
assertTrue(nodeAdmin.setFrozen(false)); // Unfreeze everything
mockNodeAgentSetFrozenResponse(nodeAgents, false, false, false);
assertFalse(nodeAdmin.setFrozen(true)); // NodeAdmin freezes only when all the NodeAgents are frozen
mockNodeAgentSetFrozenResponse(nodeAgents, false, true, true);
assertFalse(nodeAdmin.setFrozen(true));
assertFalse(nodeAdmin.isFrozen());
mockNodeAgentSetFrozenResponse(nodeAgents, true, true, true);
assertTrue(nodeAdmin.setFrozen(true));
assertTrue(nodeAdmin.isFrozen());
mockNodeAgentSetFrozenResponse(nodeAgents, true, true, true);
assertTrue(nodeAdmin.setFrozen(true));
assertTrue(nodeAdmin.isFrozen());
mockNodeAgentSetFrozenResponse(nodeAgents, false, false, false);
assertFalse(nodeAdmin.setFrozen(false));
assertFalse(nodeAdmin.isFrozen()); // NodeAdmin unfreezes instantly
mockNodeAgentSetFrozenResponse(nodeAgents, false, false, true);
assertFalse(nodeAdmin.setFrozen(false));
assertFalse(nodeAdmin.isFrozen());
mockNodeAgentSetFrozenResponse(nodeAgents, true, true, true);
assertTrue(nodeAdmin.setFrozen(false));
assertFalse(nodeAdmin.isFrozen());
}
@Test
void testSubsystemFreezeDuration() {
// Initially everything is frozen to force convergence
assertTrue(nodeAdmin.isFrozen());
assertTrue(nodeAdmin.subsystemFreezeDuration().isZero());
timer.advance(Duration.ofSeconds(1));
assertEquals(Duration.ofSeconds(1), nodeAdmin.subsystemFreezeDuration());
// Unfreezing floors freeze duration
assertTrue(nodeAdmin.setFrozen(false)); // Unfreeze everything
assertTrue(nodeAdmin.subsystemFreezeDuration().isZero());
timer.advance(Duration.ofSeconds(1));
assertTrue(nodeAdmin.subsystemFreezeDuration().isZero());
// Advancing time now will make freeze duration proceed according to clock
assertTrue(nodeAdmin.setFrozen(true));
assertTrue(nodeAdmin.subsystemFreezeDuration().isZero());
timer.advance(Duration.ofSeconds(1));
assertEquals(Duration.ofSeconds(1), nodeAdmin.subsystemFreezeDuration());
}
private void mockNodeAgentSetFrozenResponse(List<NodeAgentWithScheduler> nodeAgents, boolean... responses) {
for (int i = 0; i < nodeAgents.size(); i++) {
NodeAgentWithScheduler nodeAgent = nodeAgents.get(i);
when(nodeAgent.setFrozen(anyBoolean(), any())).thenReturn(responses[i]);
}
}
private NodeAgentContext createNodeAgentContext(String hostname) {
return NodeAgentContextImpl.builder(hostname).fileSystem(TestFileSystem.create()).build();
}
private NodeAgentWithScheduler mockNodeAgentWithSchedulerFactory(NodeAgentContext context) {
NodeAgentWithScheduler nodeAgentWithScheduler = mock(NodeAgentWithScheduler.class);
when(nodeAgentWithSchedulerFactory.create(eq(context))).thenReturn(nodeAgentWithScheduler);
return nodeAgentWithScheduler;
}
}
|
