summaryrefslogtreecommitdiffstats
path: root/node-repository/src/test/java/com/yahoo/vespa/hosted/provision/autoscale/AutoscalingUsingBcpGroupInfoTest.java
blob: be7bc3c44a878e69db074f55f3748d71370c9814 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
package com.yahoo.vespa.hosted.provision.autoscale;

import com.yahoo.config.provision.Capacity;
import com.yahoo.config.provision.ClusterInfo;
import com.yahoo.config.provision.ClusterResources;
import com.yahoo.config.provision.ClusterSpec;
import com.yahoo.config.provision.IntRange;
import com.yahoo.config.provision.NodeResources;
import com.yahoo.vespa.hosted.provision.applications.BcpGroupInfo;
import com.yahoo.vespa.hosted.provision.provisioning.DynamicProvisioningTester;
import org.junit.Test;

import java.time.Duration;
import java.util.Optional;

import static org.junit.Assert.assertEquals;

/**
 * Tests autoscaling using information from the BCP group this cluster deployment
 * is part of to supplement local data when the local deployment lacks sufficient traffic.
 *
 * @author bratseth
 */
public class AutoscalingUsingBcpGroupInfoTest {

    /** Tests with varying BCP group info parameters. */
    @Test
    public void test_autoscaling_single_content_group() {
        var fixture = DynamicProvisioningTester.fixture().awsProdSetup(true).build();

        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.1, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 3.4, 7.4, 29.0,
                                         fixture.autoscale());

        // Higher query rate
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.1, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 6.8, 7.4, 29.0,
                                         fixture.autoscale());

        // Higher headroom
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.3, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 4.0, 7.4, 29.0,
                                         fixture.autoscale());

        // Higher per query cost
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.1, 0.45));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 5.1, 7.4, 29.0,
                                         fixture.autoscale());

        // Bcp elsewhere is 0 - use local only
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(0, 1.1, 0.45));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling using local info",
                                         8, 1, 1, 7.4, 29.0,
                                         fixture.autoscale());
    }

    /** Tests with varying BCP group info parameters. */
    @Test
    public void test_autoscaling_multiple_content_groups() {
        var min = new ClusterResources(3, 3,
                                       new NodeResources(1, 4, 10, 1, NodeResources.DiskSpeed.any));
        var max = new ClusterResources(21, 3,
                                       new NodeResources(100, 1000, 1000, 1, NodeResources.DiskSpeed.any));
        var fixture = DynamicProvisioningTester.fixture()
                                               .awsProdSetup(true)
                                               .initialResources(Optional.of(new ClusterResources(9, 3, new NodeResources(2, 16, 75, 1))))
                                               .capacity(Capacity.from(min, max))
                                               .build();

        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.1, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         3, 3, 11.7, 43.2, 190.0,
                                         fixture.autoscale());

        // Higher query rate
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.1, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         3, 3, 23.1, 43.2, 190.0,
                                         fixture.autoscale());

        // Higher headroom
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.3, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         3, 3, 13.8, 43.2, 190.0,
                                         fixture.autoscale());

        // Higher per query cost
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.1, 0.45));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         3, 3, 17.4, 43.2, 190.0,
                                         fixture.autoscale());
    }

    /**
     * Tests with varying BCP group info parameters for containers.
     * Differences from content
     * - No host sharing.
     * - Memory and disk is independent of cluster size.
     */
    @Test
    public void test_autoscaling_container() {
        var fixture = DynamicProvisioningTester.fixture().clusterType(ClusterSpec.Type.container).awsProdSetup(true).build();

        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.1, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         4, 1, 8.0, 16.0, 40.8,
                                         fixture.autoscale());

        // Higher query rate (mem and disk changes are due to being assigned larger hosts where we get less overhead share
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.1, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         7, 1, 8.0, 16.0, 40.8,
                                         fixture.autoscale());

        // Higher headroom
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.3, 0.3));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 4.0, 16.0, 40.8,
                                         fixture.autoscale());

        // Higher per query cost
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.1, 0.45));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         10, 1, 4.0, 16.0, 40.8,
                                         fixture.autoscale());
    }

    @Test
    public void test_autoscaling_with_bcp_deadline() {
        var capacity = Capacity.from(new ClusterResources(2, 1,
                                                          new NodeResources(1, 4, 10, 1, NodeResources.DiskSpeed.any)),
                                     new ClusterResources(20, 1,
                                                          new NodeResources(100, 1000, 1000, 1, NodeResources.DiskSpeed.any)),
                                     IntRange.empty(), false, true, Optional.empty(),
                                     new ClusterInfo.Builder().bcpDeadline(Duration.ofMinutes(60)).build());

        var fixture = DynamicProvisioningTester.fixture()
                                               .capacity(capacity)
                                               .clusterType(ClusterSpec.Type.container).awsProdSetup(true).build();

        // We can rescale within deadline - do not take BCP info into account
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(100, 1.1, 0.45));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("No need for traffic shift headroom",
                                         3, 1, 4.0, 16.0, 40.8,
                                         fixture.autoscale());
    }

    @Test
    public void test_autoscaling_single_content_group_with_some_local_traffic() {
        var fixture = DynamicProvisioningTester.fixture().awsProdSetup(true).build();

        // Baseline: No local traffic, group traffic indicates much higher cpu usage than local
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.3, 0.45));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 11.9, 7.4, 29.0,
                                         fixture.autoscale());

        // Some local traffic
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.3, 0.45));
        Duration duration1 = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration1.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 10.0);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 6.8, 7.4, 29.0,
                                         fixture.autoscale());

        // Enough local traffic to get half the votes
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.3, 0.45));
        Duration duration2 = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration2.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 50.0);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 3.0, 7.4, 29.0,
                                         fixture.autoscale());

        // Mostly local
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.3, 0.45));
        Duration duration3 = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration3.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 90.0);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 2.2, 7.4, 29.0,
                                         fixture.autoscale());

        // Local only
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.3, 0.45));
        Duration duration4 = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration4.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 100.0);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 2.1, 7.4, 29.0,
                                         fixture.autoscale());

        // No group info, should be the same as the above
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(BcpGroupInfo.empty());
        Duration duration5 = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration5.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 100.0);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 2.1, 7.4, 29.0,
                                         fixture.autoscale());

        // 40 query rate, no group info (for reference to the below)
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(BcpGroupInfo.empty());
        Duration duration6 = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration6.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 40.0);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 1.5, 7.4, 29.0,
                                         fixture.autoscale());

        // Local query rate is too low but global is even lower so disregard it, giving the same as above
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200 / 40.0, 1.3, 0.45 * 40.0));
        Duration duration7 = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration7.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 40.0);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 1.5, 7.4, 29.0,
                                         fixture.autoscale());

        // Local query rate is too low to be fully confident, and so is global but as it is slightly larger, incorporate it slightly
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200 / 4.0, 1.3, 0.45 * 4.0));
        Duration duration8 = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration8.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 40.0);
        fixture.tester().assertResources("Scaling up cpu using bcp group cpu info",
                                         8, 1, 1.8, 7.4, 29.0,
                                         fixture.autoscale());
    }

    @Test
    public void test_autoscaling_containers_with_some_local_traffic() {
        var fixture = DynamicProvisioningTester.fixture().clusterType(ClusterSpec.Type.container).awsProdSetup(true).build();

        // Some local traffic
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.store(new BcpGroupInfo(200, 1.9, 0.01));
        Duration duration1 = fixture.loader().addCpuMeasurements(0.58f, 10);
        fixture.tester().clock().advance(duration1.negated());
        fixture.loader().addQueryRateMeasurements(10, __ -> 10.0);
        fixture.tester().assertResources("Not scaling down due to group info, even though it contains much evidence queries are cheap",
                                         3, 1, 4.0, 16.0, 40.8,
                                         fixture.autoscale());
    }

    /** Tests with varying BCP group info parameters. */
    @Test
    public void test_autoscaling_metrics() {
        var fixture = DynamicProvisioningTester.fixture().awsProdSetup(true).build();

        // Empty has metrics at zero
        assertEquals(new Autoscaling.Metrics(0, 0, 0),
                     fixture.autoscale().metrics());


        // No external load mesurements -> 0
        fixture.tester().clock().advance(Duration.ofDays(2));
        fixture.loader().addCpuMeasurements(0.7f, 10);
        assertEquals(new Autoscaling.Metrics(0, 1.0, 0),
                     fixture.autoscale().metrics());

        // External load is measured to zero -> 0
        fixture.tester().clock().advance(Duration.ofDays(2));
        var duration = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration.negated());
        fixture.loader().addQueryRateMeasurements(10, i -> 0.0);
        assertEquals(new Autoscaling.Metrics(0, 1.0, 0),
                     fixture.autoscale().metrics());

        // External load
        fixture.tester().clock().advance(Duration.ofDays(2));
        duration = fixture.loader().addCpuMeasurements(0.7f, 10);
        fixture.tester().clock().advance(duration.negated());
        fixture.loader().addQueryRateMeasurements(10, i -> 110.0);
        assertEquals(new Autoscaling.Metrics(110, 1.0, 0.05),
                     round(fixture.autoscale().metrics()));
    }

    private Autoscaling.Metrics round(Autoscaling.Metrics metrics) {
        return new Autoscaling.Metrics(Math.round(metrics.queryRate() * 100) / 100.0,
                                       Math.round(metrics.growthRateHeadroom() * 100) / 100.0,
                                       Math.round(metrics.cpuCostPerQuery() * 100) / 100.0);
    }

}