1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
#include <vespa/storage/bucketdb/bucketdatabase.h>
#include <vespa/storage/distributor/bucketdb/bucketdbmetricupdater.h>
#include <vespa/storage/distributor/distributormetricsset.h>
#include <vespa/storage/distributor/idealstatemetricsset.h>
#include <vespa/storage/config/config-stor-distributormanager.h>
#include <vespa/vespalib/util/memoryusage.h>
#include <vespa/vespalib/gtest/gtest.h>
#include <string>
namespace storage::distributor {
using document::BucketId;
using namespace ::testing;
struct BucketDBMetricUpdaterTest : Test {
void visitBucketWith2Copies1Trusted(BucketDBMetricUpdater& metricUpdater);
void visitBucketWith2CopiesBothTrusted(BucketDBMetricUpdater& metricUpdater);
void visitBucketWith1Copy(BucketDBMetricUpdater& metricUpdater);
using NodeToReplicasMap = MinReplicaMap;
NodeToReplicasMap replicaStatsOf(BucketDBMetricUpdater& metricUpdater);
BucketDBMetricUpdaterTest();
};
BucketDBMetricUpdaterTest::BucketDBMetricUpdaterTest() = default;
namespace {
void addNode(BucketInfo& info, uint16_t node, uint32_t crc) {
auto apiInfo = api::BucketInfo(crc, crc + 1, crc + 2);
std::vector<uint16_t> order;
info.addNode(BucketCopy(1234, node, apiInfo), order);
}
BucketInfo
makeInfo(uint32_t copy0Crc)
{
BucketInfo info;
addNode(info, 0, copy0Crc);
return info;
}
BucketInfo
makeInfo(uint32_t copy0Crc, uint32_t copy1Crc)
{
BucketInfo info;
addNode(info, 0, copy0Crc);
addNode(info, 1, copy1Crc);
return info;
}
} // anonymous namespace
TEST_F(BucketDBMetricUpdaterTest, doc_and_byte_counts_are_updated) {
BucketDBMetricUpdater metricUpdater;
IdealStateMetricSet ims;
DistributorMetricSet dms;
EXPECT_FALSE(metricUpdater.hasCompletedRound());
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
metricUpdater.completeRound(false);
EXPECT_TRUE(metricUpdater.hasCompletedRound());
EXPECT_EQ(0, dms.docsStored.getLast());
EXPECT_EQ(0, dms.bytesStored.getLast());
{
BucketDatabase::Entry e(document::BucketId(16, 1), makeInfo(10));
metricUpdater.visit(e, 1);
}
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_TRUE(metricUpdater.hasCompletedRound());
EXPECT_EQ(11, dms.docsStored.getLast());
EXPECT_EQ(12, dms.bytesStored.getLast());
{
BucketDatabase::Entry e(document::BucketId(16, 1), makeInfo(20));
metricUpdater.visit(e, 1);
}
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(32, dms.docsStored.getLast());
EXPECT_EQ(34, dms.bytesStored.getLast());
}
TEST_F(BucketDBMetricUpdaterTest, bucket_db_memory_usage_metrics_are_updated) {
BucketDBMetricUpdater metric_updater;
IdealStateMetricSet ims;
DistributorMetricSet dms;
vespalib::MemoryUsage mem_usage;
mem_usage.incAllocatedBytes(1000);
mem_usage.incDeadBytes(700);
metric_updater.update_db_memory_usage(mem_usage, true);
mem_usage.incAllocatedBytes(500);
mem_usage.incDeadBytes(100);
metric_updater.update_db_memory_usage(mem_usage, false);
metric_updater.completeRound(false);
metric_updater.getLastCompleteStats().propagateMetrics(ims, dms);
auto* m = dms.mutable_dbs.memory_usage.getMetric("allocated_bytes");
ASSERT_TRUE(m != nullptr);
EXPECT_EQ(m->getLongValue("last"), 1000);
m = dms.mutable_dbs.memory_usage.getMetric("dead_bytes");
ASSERT_TRUE(m != nullptr);
EXPECT_EQ(m->getLongValue("last"), 700);
m = dms.read_only_dbs.memory_usage.getMetric("allocated_bytes");
ASSERT_TRUE(m != nullptr);
EXPECT_EQ(m->getLongValue("last"), 1500);
m = dms.read_only_dbs.memory_usage.getMetric("dead_bytes");
ASSERT_TRUE(m != nullptr);
EXPECT_EQ(m->getLongValue("last"), 800);
}
TEST_F(BucketDBMetricUpdaterTest, buckets_with_too_few_and_too_many_copies) {
BucketDBMetricUpdater metricUpdater;
IdealStateMetricSet ims;
DistributorMetricSet dms;
metricUpdater.completeRound();
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(0, ims.buckets_toofewcopies.getLast());
EXPECT_EQ(0, ims.buckets_toomanycopies.getLast());
EXPECT_EQ(0, ims.buckets.getLast());
// 1 copy too little
{
BucketDatabase::Entry e(document::BucketId(16, 1), makeInfo(10));
metricUpdater.visit(e, 2);
}
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(1, ims.buckets_toofewcopies.getLast());
EXPECT_EQ(0, ims.buckets_toomanycopies.getLast());
EXPECT_EQ(1, ims.buckets.getLast());
// 1 copy too many
{
BucketDatabase::Entry e(document::BucketId(16, 1), makeInfo(40, 40));
metricUpdater.visit(e, 1);
}
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(1, ims.buckets_toofewcopies.getLast());
EXPECT_EQ(1, ims.buckets_toomanycopies.getLast());
EXPECT_EQ(2, ims.buckets.getLast());
// Right amount of copies, just inc bucket counter.
{
BucketDatabase::Entry e(document::BucketId(16, 1), makeInfo(40, 40));
metricUpdater.visit(e, 2);
}
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(1, ims.buckets_toofewcopies.getLast());
EXPECT_EQ(1, ims.buckets_toomanycopies.getLast());
EXPECT_EQ(3, ims.buckets.getLast());
}
TEST_F(BucketDBMetricUpdaterTest, buckets_with_varying_trustedness) {
BucketDBMetricUpdater metricUpdater;
IdealStateMetricSet ims;
DistributorMetricSet dms;
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(0, ims.buckets_notrusted.getLast());
// Has only trusted (implicit for first added)
{
BucketDatabase::Entry e(document::BucketId(16, 1), makeInfo(100));
metricUpdater.visit(e, 2);
}
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(0, ims.buckets_notrusted.getLast());
// Has at least one trusted (implicit for first added)
{
BucketDatabase::Entry e(document::BucketId(16, 2), makeInfo(100, 200));
metricUpdater.visit(e, 2);
}
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(0, ims.buckets_notrusted.getLast());
// Has no trusted
{
BucketInfo info(makeInfo(100, 200));
info.resetTrusted();
BucketDatabase::Entry e(document::BucketId(16, 3), std::move(info));
metricUpdater.visit(e, 2);
}
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(1, ims.buckets_notrusted.getLast());
}
TEST_F(BucketDBMetricUpdaterTest, pick_counts_from_trusted_copy) {
BucketDBMetricUpdater metricUpdater;
IdealStateMetricSet ims;
DistributorMetricSet dms;
// First copy added is implicitly trusted, but it is not the largest.
BucketDatabase::Entry e(document::BucketId(16, 2), makeInfo(100, 200));
metricUpdater.visit(e, 2);
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(101, dms.docsStored.getLast());
EXPECT_EQ(102, dms.bytesStored.getLast());
}
TEST_F(BucketDBMetricUpdaterTest, pick_largest_copy_if_no_trusted) {
BucketDBMetricUpdater metricUpdater;
IdealStateMetricSet ims;
DistributorMetricSet dms;
// No trusted copies, so must pick second copy.
BucketInfo info(makeInfo(100, 200));
info.resetTrusted();
BucketDatabase::Entry e(document::BucketId(16, 2), std::move(info));
metricUpdater.visit(e, 2);
metricUpdater.completeRound(false);
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(201, dms.docsStored.getLast());
EXPECT_EQ(202, dms.bytesStored.getLast());
}
TEST_F(BucketDBMetricUpdaterTest, complete_round_clears_working_state) {
BucketDBMetricUpdater metricUpdater;
IdealStateMetricSet ims;
DistributorMetricSet dms;
{
BucketDatabase::Entry e(document::BucketId(16, 1), makeInfo(10));
metricUpdater.visit(e, 1);
}
metricUpdater.completeRound();
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(11, dms.docsStored.getLast());
// Completing the round again with no visits having been done will
// propagate an empty working state to the complete state.
metricUpdater.completeRound();
metricUpdater.getLastCompleteStats().propagateMetrics(ims, dms);
EXPECT_EQ(0, dms.docsStored.getLast());
}
// Replicas on nodes 0 and 1.
void
BucketDBMetricUpdaterTest::visitBucketWith2Copies1Trusted(BucketDBMetricUpdater& metricUpdater)
{
BucketInfo info;
addNode(info, 0, 100);
addNode(info, 1, 101); // Note different checksums => #trusted = 1
BucketDatabase::Entry e(document::BucketId(16, 1), std::move(info));
metricUpdater.visit(e, 2);
}
// Replicas on nodes 0 and 2.
void
BucketDBMetricUpdaterTest::visitBucketWith2CopiesBothTrusted(BucketDBMetricUpdater& metricUpdater)
{
BucketInfo info;
addNode(info, 0, 200);
addNode(info, 2, 200);
BucketDatabase::Entry e(document::BucketId(16, 2), std::move(info));
metricUpdater.visit(e, 2);
}
// Single replica on node 2.
void
BucketDBMetricUpdaterTest::visitBucketWith1Copy(BucketDBMetricUpdater& metricUpdater)
{
BucketInfo info;
addNode(info, 2, 100);
BucketDatabase::Entry e(document::BucketId(16, 1), std::move(info));
metricUpdater.visit(e, 2);
}
BucketDBMetricUpdaterTest::NodeToReplicasMap
BucketDBMetricUpdaterTest::replicaStatsOf(BucketDBMetricUpdater& metricUpdater)
{
metricUpdater.completeRound(true);
return metricUpdater.getLastCompleteStats()._minBucketReplica;
}
TEST_F(BucketDBMetricUpdaterTest, min_bucket_replica_tracked_and_reported_per_node) {
BucketDBMetricUpdater metricUpdater;
// Node 0 and 1 should have min replica 1, while node 2 should have min
// replica 2.
visitBucketWith2Copies1Trusted(metricUpdater);
visitBucketWith2CopiesBothTrusted(metricUpdater);
EXPECT_EQ(NodeToReplicasMap({{0, 1}, {1, 1}, {2, 2}}),
replicaStatsOf(metricUpdater));
}
TEST_F(BucketDBMetricUpdaterTest, non_trusted_replicas_also_counted_in_mode_any) {
BucketDBMetricUpdater metricUpdater;
using CountingMode = BucketDBMetricUpdater::ReplicaCountingMode;
metricUpdater.setMinimumReplicaCountingMode(CountingMode::ANY);
visitBucketWith2Copies1Trusted(metricUpdater);
visitBucketWith2CopiesBothTrusted(metricUpdater);
EXPECT_EQ(NodeToReplicasMap({{0, 2}, {1, 2}, {2, 2}}),
replicaStatsOf(metricUpdater));
}
TEST_F(BucketDBMetricUpdaterTest, minimum_replica_count_returned_for_node_in_mode_any) {
BucketDBMetricUpdater metricUpdater;
using CountingMode = BucketDBMetricUpdater::ReplicaCountingMode;
metricUpdater.setMinimumReplicaCountingMode(CountingMode::ANY);
visitBucketWith2CopiesBothTrusted(metricUpdater);
visitBucketWith1Copy(metricUpdater);
// Node 2 has a bucket with only 1 replica.
EXPECT_EQ(NodeToReplicasMap({{0, 2}, {2, 1}}),
replicaStatsOf(metricUpdater));
}
} // storage::distributor
|
