1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
#include "dummy_cluster_context.h"
#include <tests/distributor/distributor_stripe_test_util.h>
#include <vespa/document/test/make_document_bucket.h>
#include <vespa/storage/distributor/top_level_distributor.h>
#include <vespa/storage/distributor/idealstatemanager.h>
#include <vespa/storage/distributor/operations/idealstate/removebucketoperation.h>
#include <vespa/storageapi/message/bucket.h>
#include <vespa/storageapi/message/persistence.h>
#include <vespa/vdslib/distribution/distribution.h>
#include <vespa/vespalib/gtest/gtest.h>
using document::test::makeDocumentBucket;
using namespace ::testing;
namespace storage::distributor {
struct RemoveBucketOperationTest : Test, DistributorStripeTestUtil {
void SetUp() override {
createLinks();
};
void TearDown() override {
close();
}
void reject_with_bucket_info(RemoveBucketOperation& op, size_t msg_index) {
std::shared_ptr<api::StorageCommand> msg2 = _sender.command(msg_index);
std::shared_ptr<api::StorageReply> reply(msg2->makeReply());
dynamic_cast<api::DeleteBucketReply&>(*reply).setBucketInfo(api::BucketInfo(10, 200, 1));
reply->setResult(api::ReturnCode::REJECTED);
op.receive(_sender, reply);
}
};
TEST_F(RemoveBucketOperationTest, simple) {
addNodesToBucketDB(document::BucketId(16, 1),
"0=10/100/1/t,"
"1=10/100/1/t,"
"2=10/100/1/t");
set_redundancy(1);
enable_cluster_state("distributor:1 storage:3");
RemoveBucketOperation op(dummy_cluster_context,
BucketAndNodes(makeDocumentBucket(document::BucketId(16, 1)),
toVector<uint16_t>(1, 2)));
op.setIdealStateManager(&getIdealStateManager());
op.start(_sender);
ASSERT_EQ("Delete bucket => 1,"
"Delete bucket => 2",
_sender.getCommands(true));
sendReply(op, 0);
sendReply(op, 1);
ASSERT_EQ("BucketId(0x4000000000000001) : "
"node(idx=0,crc=0xa,docs=100/100,bytes=1/1,trusted=true,active=false,ready=false)",
dumpBucket(document::BucketId(16, 1)));
}
/**
* Test that receiving a DeleteBucket failure from a storage node that sends
* back actual bucket info reinserts that bucket info into the distributor
* bucket database.
*/
TEST_F(RemoveBucketOperationTest, bucket_info_mismatch_failure) {
addNodesToBucketDB(document::BucketId(16, 1), "1=0/0/0/t");
getComponentRegisterImpl().setDistribution(
std::make_shared<lib::Distribution>(lib::Distribution::getDefaultDistributionConfig(1, 10)));
enable_cluster_state("distributor:1 storage:2");
RemoveBucketOperation op(dummy_cluster_context,
BucketAndNodes(makeDocumentBucket(document::BucketId(16, 1)),
toVector<uint16_t>(1)));
op.setIdealStateManager(&getIdealStateManager());
op.start(_sender);
ASSERT_EQ("Delete bucket => 1", _sender.getCommands(true));
ASSERT_EQ(1, _sender.commands().size());
reject_with_bucket_info(op, 0);
// RemoveBucketOperation should reinsert bucketinfo into database
ASSERT_EQ("BucketId(0x4000000000000001) : "
"node(idx=1,crc=0xa,docs=200/200,bytes=1/1,trusted=true,active=false,ready=false)",
dumpBucket(document::BucketId(16, 1)));
}
/**
* Test that receiving a DeleteBucket failure from a storage node that does
* not include valid BucketInfo in its reply does not reinsert the bucket
* into the distributor.
*/
TEST_F(RemoveBucketOperationTest, fail_with_invalid_bucket_info) {
addNodesToBucketDB(document::BucketId(16, 1), "1=0/0/0/t");
getComponentRegisterImpl().setDistribution(
std::make_shared<lib::Distribution>(lib::Distribution::getDefaultDistributionConfig(1, 10)));
enable_cluster_state("distributor:1 storage:2");
RemoveBucketOperation op(dummy_cluster_context,
BucketAndNodes(makeDocumentBucket(document::BucketId(16, 1)),
toVector<uint16_t>(1)));
op.setIdealStateManager(&getIdealStateManager());
op.start(_sender);
ASSERT_EQ("Delete bucket => 1", _sender.getCommands(true));
ASSERT_EQ(1, _sender.commands().size());
std::shared_ptr<api::StorageCommand> msg2 = _sender.command(0);
std::shared_ptr<api::StorageReply> reply(msg2->makeReply().release());
reply->setResult(api::ReturnCode::ABORTED);
op.receive(_sender, reply);
EXPECT_EQ("NONEXISTING", dumpBucket(document::BucketId(16, 1)));
}
TEST_F(RemoveBucketOperationTest, operation_blocked_when_pending_message_to_target_node) {
RemoveBucketOperation op(dummy_cluster_context,
BucketAndNodes(makeDocumentBucket(document::BucketId(16, 1)),
toVector<uint16_t>(1, 3)));
// In node target set
EXPECT_TRUE(op.shouldBlockThisOperation(api::MessageType::PUT_ID, 1, 120));
EXPECT_TRUE(op.shouldBlockThisOperation(api::MessageType::PUT_ID, 3, 120));
// Not in node target set
EXPECT_FALSE(op.shouldBlockThisOperation(api::MessageType::PUT_ID, 0, 120));
EXPECT_FALSE(op.shouldBlockThisOperation(api::MessageType::PUT_ID, 2, 120));
}
TEST_F(RemoveBucketOperationTest, cancelled_node_does_not_update_bucket_db_upon_rejection) {
addNodesToBucketDB(document::BucketId(16, 1),
"0=10/100/1/t,"
"1=10/100/1/t,"
"2=10/100/1/t");
set_redundancy(1);
enable_cluster_state("distributor:1 storage:3");
RemoveBucketOperation op(dummy_cluster_context,
BucketAndNodes(makeDocumentBucket(document::BucketId(16, 1)),
toVector<uint16_t>(1,2)));
op.setIdealStateManager(&getIdealStateManager());
op.start(_sender);
ASSERT_EQ("Delete bucket => 1,"
"Delete bucket => 2",
_sender.getCommands(true));
op.cancel(_sender, CancelScope::of_node_subset({1}));
// Rejections will by default reinsert the bucket into the DB with the bucket info contained
// in the reply, but here the node is cancelled and should therefore not be reinserted.
reject_with_bucket_info(op, 0);
sendReply(op, 1);
// Node 1 not reinserted
ASSERT_EQ("BucketId(0x4000000000000001) : "
"node(idx=0,crc=0xa,docs=100/100,bytes=1/1,trusted=true,active=false,ready=false)",
dumpBucket(document::BucketId(16, 1)));
EXPECT_FALSE(op.ok());
}
} // storage::distributor
|
