1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
|
// Copyright Yahoo. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
#include <vespa/storage/persistence/apply_bucket_diff_state.h>
#include <vespa/storage/persistence/merge_bucket_info_syncer.h>
#include <vespa/storage/persistence/filestorage/merge_handler_metrics.h>
#include <vespa/document/base/documentid.h>
#include <vespa/document/bucket/bucketid.h>
#include <vespa/document/bucket/bucketidfactory.h>
#include <vespa/document/test/make_document_bucket.h>
#include <vespa/metrics/metricset.h>
#include <vespa/persistence/spi/result.h>
#include <vespa/storageframework/defaultimplementation/clock/fakeclock.h>
#include <gtest/gtest.h>
using document::DocumentId;
using document::test::makeDocumentBucket;
using vespalib::MonitoredRefCount;
using vespalib::RetainGuard;
namespace storage {
namespace {
spi::Result spi_result_ok;
spi::Result spi_result_fail(spi::Result::ErrorType::RESOURCE_EXHAUSTED, "write blocked");
document::BucketIdFactory bucket_id_factory;
const char *test_op = "put";
document::Bucket dummy_document_bucket(makeDocumentBucket(document::BucketId(0, 16)));
class DummyMergeBucketInfoSyncer : public MergeBucketInfoSyncer
{
uint32_t& _sync_count;
vespalib::string _fail;
public:
DummyMergeBucketInfoSyncer(uint32_t& sync_count)
: MergeBucketInfoSyncer(),
_sync_count(sync_count),
_fail()
{
}
~DummyMergeBucketInfoSyncer();
void sync_bucket_info(const spi::Bucket& bucket) const override {
EXPECT_EQ(bucket, spi::Bucket(dummy_document_bucket));
++_sync_count;
if (!_fail.empty()) {
throw std::runtime_error(_fail);
}
}
void schedule_delayed_delete(std::unique_ptr<ApplyBucketDiffState>) const override { }
void set_fail(vespalib::string fail) { _fail = std::move(fail); }
};
DummyMergeBucketInfoSyncer::~DummyMergeBucketInfoSyncer() = default;
void
make_result(ApplyBucketDiffState& state, spi::Result &spi_result, const DocumentId &doc_id)
{
state.on_entry_complete(std::make_unique<spi::Result>(spi_result), doc_id, test_op);
}
void push_ok(ApplyBucketDiffState &state)
{
make_result(state, spi_result_ok, DocumentId("id::test::0"));
make_result(state, spi_result_ok, DocumentId("id::test::1"));
}
void push_bad(ApplyBucketDiffState &state)
{
make_result(state, spi_result_ok, DocumentId("id::test::0"));
make_result(state, spi_result_fail, DocumentId("id::test::1"));
make_result(state, spi_result_fail, DocumentId("id::test::2"));
}
}
class ApplyBucketDiffStateTestBase : public ::testing::Test
{
public:
uint32_t sync_count;
DummyMergeBucketInfoSyncer syncer;
metrics::MetricSet merge_handler_metrics_owner;
MergeHandlerMetrics merge_handler_metrics;
framework::defaultimplementation::FakeClock clock;
MonitoredRefCount monitored_ref_count;
ApplyBucketDiffStateTestBase()
: ::testing::Test(),
sync_count(0u),
syncer(sync_count),
merge_handler_metrics_owner("owner", {}, "owner"),
merge_handler_metrics(&merge_handler_metrics_owner),
clock(),
monitored_ref_count()
{
}
~ApplyBucketDiffStateTestBase();
std::shared_ptr<ApplyBucketDiffState> make_state() {
return ApplyBucketDiffState::create(syncer, merge_handler_metrics, clock, spi::Bucket(dummy_document_bucket), RetainGuard(monitored_ref_count));
}
};
ApplyBucketDiffStateTestBase::~ApplyBucketDiffStateTestBase() = default;
class ApplyBucketDiffStateTest : public ApplyBucketDiffStateTestBase
{
public:
std::shared_ptr<ApplyBucketDiffState> state;
ApplyBucketDiffStateTest()
: ApplyBucketDiffStateTestBase(),
state(make_state())
{
}
void reset() {
state = make_state();
}
void check_failure(std::string expected) {
auto future = state->get_future();
state.reset();
std::string fail_message = future.get();
EXPECT_EQ(expected, fail_message);
}
void check_failure() {
check_failure("Failed put for id::test::1 in Bucket(0x0000000000000010): Result(5, write blocked)");
}
};
TEST_F(ApplyBucketDiffStateTest, ok_results_can_be_checked)
{
push_ok(*state);
check_failure("");
}
TEST_F(ApplyBucketDiffStateTest, failed_result_errors_ignored)
{
push_bad(*state);
}
TEST_F(ApplyBucketDiffStateTest, first_failed_result_throws_exception)
{
push_bad(*state);
ASSERT_NO_FATAL_FAILURE(check_failure());
}
TEST_F(ApplyBucketDiffStateTest, sync_bucket_info_if_needed_on_destruct)
{
reset();
EXPECT_EQ(0, sync_count);
state->mark_stale_bucket_info();
EXPECT_EQ(0, sync_count);
reset();
EXPECT_EQ(1, sync_count);
}
TEST_F(ApplyBucketDiffStateTest, explicit_sync_bucket_info_works)
{
state->sync_bucket_info();
EXPECT_EQ(0, sync_count);
state->mark_stale_bucket_info();
state->sync_bucket_info();
EXPECT_EQ(1, sync_count);
state->sync_bucket_info();
EXPECT_EQ(1, sync_count);
reset();
EXPECT_EQ(1, sync_count);
}
TEST_F(ApplyBucketDiffStateTest, failed_sync_bucket_info_is_detected)
{
vespalib::string fail("sync bucket failed");
syncer.set_fail(fail);
state->mark_stale_bucket_info();
check_failure(fail);
}
TEST_F(ApplyBucketDiffStateTest, data_write_latency_is_updated)
{
clock.addMilliSecondsToTime(10);
state.reset();
EXPECT_EQ(10.0, merge_handler_metrics.mergeDataWriteLatency.getLast());
EXPECT_EQ(1, merge_handler_metrics.mergeDataWriteLatency.getCount());
}
TEST_F(ApplyBucketDiffStateTest, total_latency_is_not_updated)
{
clock.addMilliSecondsToTime(14);
state.reset();
EXPECT_EQ(0.0, merge_handler_metrics.mergeLatencyTotal.getLast());
EXPECT_EQ(0, merge_handler_metrics.mergeLatencyTotal.getCount());
}
TEST_F(ApplyBucketDiffStateTest, total_latency_is_updated)
{
state->set_merge_start_time(framework::MilliSecTimer(clock));
clock.addMilliSecondsToTime(14);
state.reset();
EXPECT_EQ(14.0, merge_handler_metrics.mergeLatencyTotal.getLast());
EXPECT_EQ(1, merge_handler_metrics.mergeLatencyTotal.getCount());
}
}
|
