1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
|
// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.document.restapi;
import com.yahoo.documentapi.DocumentAccess;
import com.yahoo.documentapi.ProgressToken;
import com.yahoo.documentapi.VisitorControlHandler;
import com.yahoo.documentapi.VisitorParameters;
import com.yahoo.documentapi.VisitorSession;
import com.yahoo.metrics.simple.MetricReceiver;
import com.yahoo.vdslib.VisitorStatistics;
import com.yahoo.vespaclient.ClusterDef;
import org.junit.Test;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.net.URI;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicReference;
import static org.hamcrest.CoreMatchers.containsString;
import static org.hamcrest.core.Is.is;
import static org.junit.Assert.*;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
public class OperationHandlerImplTest {
@Test(expected = IllegalArgumentException.class)
public void missingClusterDef() throws RestApiException {
List<ClusterDef> clusterDef = new ArrayList<>();
OperationHandlerImpl.resolveClusterRoute(Optional.empty(), clusterDef);
}
@Test(expected = IllegalArgumentException.class)
public void missingClusterDefSpecifiedCluster() throws RestApiException {
List<ClusterDef> clusterDef = new ArrayList<>();
OperationHandlerImpl.resolveClusterRoute(Optional.of("cluster"), clusterDef);
}
@Test(expected = RestApiException.class)
public void oneClusterPresentNotMatching() throws RestApiException {
List<ClusterDef> clusterDef = new ArrayList<>();
clusterDef.add(new ClusterDef("foo", "configId"));
OperationHandlerImpl.resolveClusterRoute(Optional.of("cluster"), clusterDef);
}
@Test()
public void oneClusterMatching() throws RestApiException {
List<ClusterDef> clusterDef = new ArrayList<>();
clusterDef.add(new ClusterDef("foo", "configId"));
assertThat(OperationHandlerImpl.resolveClusterRoute(Optional.of("foo"), clusterDef),
is("[Storage:cluster=foo;clusterconfigid=configId]"));
}
@Test()
public void oneClusterMatchingManyAvailable() throws RestApiException {
List<ClusterDef> clusterDef = new ArrayList<>();
clusterDef.add(new ClusterDef("foo2", "configId2"));
clusterDef.add(new ClusterDef("foo", "configId"));
clusterDef.add(new ClusterDef("foo3", "configId2"));
assertThat(OperationHandlerImpl.resolveClusterRoute(Optional.of("foo"), clusterDef),
is("[Storage:cluster=foo;clusterconfigid=configId]"));
}
@Test()
public void checkErrorMessage() throws RestApiException, IOException {
List<ClusterDef> clusterDef = new ArrayList<>();
clusterDef.add(new ClusterDef("foo2", "configId2"));
clusterDef.add(new ClusterDef("foo", "configId"));
clusterDef.add(new ClusterDef("foo3", "configId2"));
try {
OperationHandlerImpl.resolveClusterRoute(Optional.of("wrong"), clusterDef);
} catch(RestApiException e) {
String errorMsg = renderRestApiExceptionAsString(e);
assertThat(errorMsg, is("{\"errors\":[{\"description\":" +
"\"MISSING_CLUSTER Your vespa cluster contains the content clusters foo2 (configId2), foo (configId)," +
" foo3 (configId2), not wrong. Please select a valid vespa cluster.\",\"id\":-9}]}"));
return;
}
fail("Expected exception");
}
private String renderRestApiExceptionAsString(RestApiException e) throws IOException {
ByteArrayOutputStream stream = new ByteArrayOutputStream();
e.getResponse().render(stream);
return new String( stream.toByteArray());
}
private static class OperationHandlerImplFixture {
DocumentAccess documentAccess = mock(DocumentAccess.class);
AtomicReference<VisitorParameters> assignedParameters = new AtomicReference<>();
VisitorControlHandler.CompletionCode completionCode = VisitorControlHandler.CompletionCode.SUCCESS;
int bucketsVisited = 0;
OperationHandlerImpl createHandler() throws Exception {
VisitorSession visitorSession = mock(VisitorSession.class);
// Pre-bake an already completed session
when(documentAccess.createVisitorSession(any(VisitorParameters.class))).thenAnswer(p -> {
VisitorParameters params = (VisitorParameters)p.getArguments()[0];
assignedParameters.set(params);
VisitorStatistics statistics = new VisitorStatistics();
statistics.setBucketsVisited(bucketsVisited);
params.getControlHandler().onVisitorStatistics(statistics);
ProgressToken progress = new ProgressToken();
params.getControlHandler().onProgress(progress);
params.getControlHandler().onDone(completionCode, "bork bork");
return visitorSession;
});
OperationHandlerImpl.ClusterEnumerator clusterEnumerator = () -> Arrays.asList(new ClusterDef("foo", "configId"));
return new OperationHandlerImpl(documentAccess, clusterEnumerator, MetricReceiver.nullImplementation);
}
}
private static RestUri dummyVisitUri() throws Exception {
return new RestUri(new URI("http://localhost/document/v1/namespace/document-type/docid/"));
}
private static OperationHandler.VisitOptions visitOptionsWithWantedDocumentCount(int wantedDocumentCount) {
return new OperationHandler.VisitOptions(Optional.empty(), Optional.empty(), Optional.of(wantedDocumentCount));
}
private static OperationHandler.VisitOptions emptyVisitOptions() {
return new OperationHandler.VisitOptions(Optional.empty(), Optional.empty(), Optional.empty());
}
@Test
public void timeout_without_buckets_visited_throws_timeout_error() throws Exception {
OperationHandlerImplFixture fixture = new OperationHandlerImplFixture();
fixture.completionCode = VisitorControlHandler.CompletionCode.TIMEOUT;
fixture.bucketsVisited = 0;
// RestApiException hides its guts internally, so cannot trivially use @Rule directly to check for error category
try {
OperationHandlerImpl handler = fixture.createHandler();
handler.visit(dummyVisitUri(), "", emptyVisitOptions());
} catch (RestApiException e) {
assertThat(e.getResponse().getStatus(), is(500));
assertThat(renderRestApiExceptionAsString(e), containsString("Timed out"));
}
}
@Test
public void timeout_with_buckets_visited_does_not_throw_timeout_error() throws Exception {
OperationHandlerImplFixture fixture = new OperationHandlerImplFixture();
fixture.completionCode = VisitorControlHandler.CompletionCode.TIMEOUT;
fixture.bucketsVisited = 1;
OperationHandlerImpl handler = fixture.createHandler();
handler.visit(dummyVisitUri(), "", emptyVisitOptions());
}
@Test
public void handler_sets_default_visitor_session_timeout_parameter() throws Exception {
OperationHandlerImplFixture fixture = new OperationHandlerImplFixture();
OperationHandlerImpl handler = fixture.createHandler();
handler.visit(dummyVisitUri(), "", emptyVisitOptions());
assertThat(fixture.assignedParameters.get().getSessionTimeoutMs(), is((long)OperationHandlerImpl.VISIT_TIMEOUT_MS));
}
private static VisitorParameters generatedParametersFromVisitOptions(OperationHandler.VisitOptions options) throws Exception {
OperationHandlerImplFixture fixture = new OperationHandlerImplFixture();
OperationHandlerImpl handler = fixture.createHandler();
handler.visit(dummyVisitUri(), "", options);
return fixture.assignedParameters.get();
}
@Test
public void provided_wanted_document_count_is_propagated_to_visitor_parameters() throws Exception {
VisitorParameters params = generatedParametersFromVisitOptions(visitOptionsWithWantedDocumentCount(123));
assertThat(params.getMaxTotalHits(), is((long)123));
}
@Test
public void wanted_document_count_is_1_unless_specified() throws Exception {
VisitorParameters params = generatedParametersFromVisitOptions(emptyVisitOptions());
assertThat(params.getMaxTotalHits(), is((long)1));
}
@Test
public void too_low_wanted_document_count_is_bounded_to_1() throws Exception {
VisitorParameters params = generatedParametersFromVisitOptions(visitOptionsWithWantedDocumentCount(-1));
assertThat(params.getMaxTotalHits(), is((long)1));
params = generatedParametersFromVisitOptions(visitOptionsWithWantedDocumentCount(Integer.MIN_VALUE));
assertThat(params.getMaxTotalHits(), is((long)1));
params = generatedParametersFromVisitOptions(visitOptionsWithWantedDocumentCount(0));
assertThat(params.getMaxTotalHits(), is((long)1));
}
@Test
public void too_high_wanted_document_count_is_bounded_to_upper_bound() throws Exception {
VisitorParameters params = generatedParametersFromVisitOptions(visitOptionsWithWantedDocumentCount(OperationHandlerImpl.WANTED_DOCUMENT_COUNT_UPPER_BOUND + 1));
assertThat(params.getMaxTotalHits(), is((long)OperationHandlerImpl.WANTED_DOCUMENT_COUNT_UPPER_BOUND));
params = generatedParametersFromVisitOptions(visitOptionsWithWantedDocumentCount(Integer.MAX_VALUE));
assertThat(params.getMaxTotalHits(), is((long)OperationHandlerImpl.WANTED_DOCUMENT_COUNT_UPPER_BOUND));
}
}
|
