diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2023-12-19 00:30:10 +0100 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2023-12-19 00:30:10 +0100 |
commit | 4f382b67b1e940b18259590727968b732c9cc897 (patch) | |
tree | 48ffd03864ed54e33f5e332c73d0ac439a1202ae | |
parent | ab99ab72f238e3dcfac0176258b63612ca5f4b92 (diff) |
GC complete feature flags.balder/update-defaults-for-use-xxx-fetch-postings
4 files changed, 4 insertions, 49 deletions
diff --git a/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java b/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java index 852e02dab36..ffbbb3b4280 100644 --- a/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java +++ b/config-model-api/src/main/java/com/yahoo/config/model/api/ModelContext.java @@ -116,9 +116,9 @@ public interface ModelContext { @ModelFeatureFlag(owners = {"vekterli"}) default long mergingMaxMemoryUsagePerNode() { return -1; } @ModelFeatureFlag(owners = {"vekterli"}) default boolean usePerDocumentThrottledDeleteBucket() { return false; } @ModelFeatureFlag(owners = {"baldersheim"}) default boolean alwaysMarkPhraseExpensive() { return false; } - @ModelFeatureFlag(owners = {"baldersheim"}) default boolean createPostinglistWhenNonStrict() { return true; } - @ModelFeatureFlag(owners = {"baldersheim"}) default boolean useEstimateForFetchPostings() { return false; } - @ModelFeatureFlag(owners = {"baldersheim"}) default boolean useThreadBundleForFetchPostings() { return false; } + @ModelFeatureFlag(owners = {"baldersheim"}, removeAfter = "8.276") default boolean createPostinglistWhenNonStrict() { return true; } + @ModelFeatureFlag(owners = {"baldersheim"}, removeAfter = "8.276") default boolean useEstimateForFetchPostings() { return true; } + @ModelFeatureFlag(owners = {"baldersheim"}, removeAfter = "8.276") default boolean useThreadBundleForFetchPostings() { return true; } @ModelFeatureFlag(owners = {"hmusum"}) default boolean restartOnDeployWhenOnnxModelChanges() { return false; } } diff --git a/config-model/src/main/java/com/yahoo/schema/derived/RawRankProfile.java b/config-model/src/main/java/com/yahoo/schema/derived/RawRankProfile.java index dad39e74c37..6a1ebb39ac8 100644 --- a/config-model/src/main/java/com/yahoo/schema/derived/RawRankProfile.java +++ b/config-model/src/main/java/com/yahoo/schema/derived/RawRankProfile.java @@ -171,9 +171,6 @@ public class RawRankProfile implements RankProfilesConfig.Producer { private final OptionalDouble targetHitsMaxAdjustmentFactor; private final double rankScoreDropLimit; private final boolean alwaysMarkPhraseExpensive; - private final boolean createPostinglistWhenNonStrict; - private final boolean useEstimateForFetchPostings; - private final boolean useThreadBundleForFetchPostings; /** * The rank type definitions used to derive settings for the native rank features @@ -216,9 +213,6 @@ public class RawRankProfile implements RankProfilesConfig.Producer { numSearchPartitions = compiled.getNumSearchPartitions(); termwiseLimit = compiled.getTermwiseLimit().orElse(deployProperties.featureFlags().defaultTermwiseLimit()); alwaysMarkPhraseExpensive = deployProperties.featureFlags().alwaysMarkPhraseExpensive(); - createPostinglistWhenNonStrict = deployProperties.featureFlags().createPostinglistWhenNonStrict(); - useEstimateForFetchPostings = deployProperties.featureFlags().useEstimateForFetchPostings(); - useThreadBundleForFetchPostings = deployProperties.featureFlags().useThreadBundleForFetchPostings(); postFilterThreshold = compiled.getPostFilterThreshold(); approximateThreshold = compiled.getApproximateThreshold(); targetHitsMaxAdjustmentFactor = compiled.getTargetHitsMaxAdjustmentFactor(); @@ -472,15 +466,6 @@ public class RawRankProfile implements RankProfilesConfig.Producer { if (alwaysMarkPhraseExpensive) { properties.add(new Pair<>("vespa.matching.always_mark_phrase_expensive", String.valueOf(alwaysMarkPhraseExpensive))); } - if ( ! createPostinglistWhenNonStrict) { - properties.add(new Pair<>("vespa.matching.create_postinglist_when_non_strict", String.valueOf(createPostinglistWhenNonStrict))); - } - if (useEstimateForFetchPostings) { - properties.add(new Pair<>("vespa.matching.use_estimate_for_fetch_postings", String.valueOf(useEstimateForFetchPostings))); - } - if (useThreadBundleForFetchPostings) { - properties.add(new Pair<>("vespa.matching.use_thread_bundle_for_fetch_postings", String.valueOf(useThreadBundleForFetchPostings))); - } if (postFilterThreshold.isPresent()) { properties.add(new Pair<>("vespa.matching.global_filter.upper_limit", String.valueOf(postFilterThreshold.getAsDouble()))); } diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/deploy/ModelContextImpl.java b/configserver/src/main/java/com/yahoo/vespa/config/server/deploy/ModelContextImpl.java index 43594c943e3..639f0ec140e 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/deploy/ModelContextImpl.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/deploy/ModelContextImpl.java @@ -202,9 +202,6 @@ public class ModelContextImpl implements ModelContext { private final int heapPercentage; private final String summaryDecodePolicy; private final boolean alwaysMarkPhraseExpensive; - private final boolean createPostinglistWhenNonStrict; - private final boolean useEstimateForFetchPostings; - private final boolean useThreadBundleForFetchPostings; private final int contentLayerMetadataFeatureLevel; private final boolean dynamicHeapSize; private final String unknownConfigDefinition; @@ -256,9 +253,6 @@ public class ModelContextImpl implements ModelContext { this.mergingMaxMemoryUsagePerNode = flagValue(source, appId, version, Flags.MERGING_MAX_MEMORY_USAGE_PER_NODE); this.usePerDocumentThrottledDeleteBucket = flagValue(source, appId, version, Flags.USE_PER_DOCUMENT_THROTTLED_DELETE_BUCKET); this.alwaysMarkPhraseExpensive = flagValue(source, appId, version, Flags.ALWAYS_MARK_PHRASE_EXPENSIVE); - this.createPostinglistWhenNonStrict = flagValue(source, appId, version, Flags.CREATE_POSTINGLIST_WHEN_NON_STRICT); - this.useEstimateForFetchPostings = flagValue(source, appId, version, Flags.USE_ESTIMATE_FOR_FETCH_POSTINGS); - this.useThreadBundleForFetchPostings = flagValue(source, appId, version, Flags.USE_THREAD_BUNDLE_FOR_FETCH_POSTINGS); this.restartOnDeployWhenOnnxModelChanges = flagValue(source, appId, version, Flags.RESTART_ON_DEPLOY_WHEN_ONNX_MODEL_CHANGES); } @@ -306,9 +300,6 @@ public class ModelContextImpl implements ModelContext { return defVal; } @Override public boolean alwaysMarkPhraseExpensive() { return alwaysMarkPhraseExpensive; } - @Override public boolean createPostinglistWhenNonStrict() { return createPostinglistWhenNonStrict; } - @Override public boolean useEstimateForFetchPostings() { return useEstimateForFetchPostings; } - @Override public boolean useThreadBundleForFetchPostings() { return useThreadBundleForFetchPostings; } @Override public int contentLayerMetadataFeatureLevel() { return contentLayerMetadataFeatureLevel; } @Override public boolean dynamicHeapSize() { return dynamicHeapSize; } @Override public String unknownConfigDefinition() { return unknownConfigDefinition; } diff --git a/flags/src/main/java/com/yahoo/vespa/flags/Flags.java b/flags/src/main/java/com/yahoo/vespa/flags/Flags.java index e5227a86cfb..d96ba1295f7 100644 --- a/flags/src/main/java/com/yahoo/vespa/flags/Flags.java +++ b/flags/src/main/java/com/yahoo/vespa/flags/Flags.java @@ -327,32 +327,11 @@ public class Flags { public static final UnboundBooleanFlag ALWAYS_MARK_PHRASE_EXPENSIVE = defineFeatureFlag( "always-mark-phrase-expensive", false, - List.of("baldersheim"), "2023-11-20", "2023-12-31", + List.of("baldersheim"), "2023-11-20", "2024-02-29", "If true all phrases will be marked expensive, independent of parents", "Takes effect at redeployment", INSTANCE_ID); - public static final UnboundBooleanFlag CREATE_POSTINGLIST_WHEN_NON_STRICT = defineFeatureFlag( - "create-postinglist-when-non-strict", true, - List.of("baldersheim"), "2023-12-04", "2024-01-31", - "If true posting list can be created on the fly also for non-strict iterators", - "Takes effect at redeployment", - INSTANCE_ID); - - public static final UnboundBooleanFlag USE_ESTIMATE_FOR_FETCH_POSTINGS = defineFeatureFlag( - "use-estimate-for-fetch-postings", true, - List.of("baldersheim"), "2023-12-06", "2024-01-31", - "If true an estimate assuming uncorrelated query terms is used in Blueprint::fetchPostings", - "Takes effect at redeployment", - INSTANCE_ID); - - public static final UnboundBooleanFlag USE_THREAD_BUNDLE_FOR_FETCH_POSTINGS = defineFeatureFlag( - "use-thread-bundle-for-fetch-postings", true, - List.of("baldersheim"), "2023-12-06", "2024-01-31", - "If true the query thread bundle is used for Blueprint::fetchPostings", - "Takes effect at redeployment", - INSTANCE_ID); - public static final UnboundBooleanFlag WRITE_CONFIG_SERVER_SESSION_DATA_AS_ONE_BLOB = defineFeatureFlag( "write-config-server-session-data-as-blob", false, List.of("hmusum"), "2023-07-19", "2024-02-01", |