summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTor Egge <Tor.Egge@online.no>2023-01-28 21:28:36 +0100
committerTor Egge <Tor.Egge@online.no>2023-01-28 21:28:36 +0100
commitab05ab79a0ced00da847a1aab409a9b77b63d0aa (patch)
tree01384c209dfb027ae79c3bde9cf7247e244531c1
parentdd81671f4a11b081cf7e2b8e9ae0ebd077ea1a77 (diff)
Remove redundant or pessimizing moves.
-rw-r--r--searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp4
-rw-r--r--storage/src/tests/persistence/persistencetestutils.cpp2
-rw-r--r--storage/src/vespa/storage/persistence/asynchandler.cpp4
3 files changed, 5 insertions, 5 deletions
diff --git a/searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp b/searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp
index ca03a49ea8d..b1fda6e0efb 100644
--- a/searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp
+++ b/searchcore/src/tests/proton/documentdb/document_subdbs/document_subdbs_test.cpp
@@ -851,9 +851,9 @@ struct DocumentHandler
gate.await();
}
void putDocs() {
- PutOperation putOp = createPut(std::move(createDoc(1, 22, 33)), Timestamp(10), 10);
+ PutOperation putOp = createPut(createDoc(1, 22, 33), Timestamp(10), 10);
putDoc(putOp);
- putOp = createPut(std::move(createDoc(2, 44, 55)), Timestamp(20), 20);
+ putOp = createPut(createDoc(2, 44, 55), Timestamp(20), 20);
putDoc(putOp);
}
};
diff --git a/storage/src/tests/persistence/persistencetestutils.cpp b/storage/src/tests/persistence/persistencetestutils.cpp
index de9caebbf11..7a92c08060c 100644
--- a/storage/src/tests/persistence/persistencetestutils.cpp
+++ b/storage/src/tests/persistence/persistencetestutils.cpp
@@ -245,7 +245,7 @@ PersistenceTestUtils::doPut(const document::Document::SP& doc, document::BucketI
{
spi::Bucket b(makeSpiBucket(bid));
getPersistenceProvider().createBucket(b);
- getPersistenceProvider().put(b, time, std::move(doc));
+ getPersistenceProvider().put(b, time, doc);
}
spi::UpdateResult
diff --git a/storage/src/vespa/storage/persistence/asynchandler.cpp b/storage/src/vespa/storage/persistence/asynchandler.cpp
index 70bfb0000d1..e20c0475556 100644
--- a/storage/src/vespa/storage/persistence/asynchandler.cpp
+++ b/storage/src/vespa/storage/persistence/asynchandler.cpp
@@ -171,7 +171,7 @@ AsyncHandler::handlePut(api::PutCommand& cmd, MessageTracker::UP trackerUP) cons
tracker->checkForError(*response);
tracker->sendReply();
});
- _spi.putAsync(bucket, spi::Timestamp(cmd.getTimestamp()), std::move(cmd.getDocument()),
+ _spi.putAsync(bucket, spi::Timestamp(cmd.getTimestamp()), cmd.getDocument(),
std::make_unique<ResultTaskOperationDone>(_sequencedExecutor, cmd.getBucketId(), std::move(task)));
return trackerUP;
@@ -300,7 +300,7 @@ AsyncHandler::handleUpdate(api::UpdateCommand& cmd, MessageTracker::UP trackerUP
}
tracker->sendReply();
});
- _spi.updateAsync(bucket, spi::Timestamp(cmd.getTimestamp()), std::move(cmd.getUpdate()),
+ _spi.updateAsync(bucket, spi::Timestamp(cmd.getTimestamp()), cmd.getUpdate(),
std::make_unique<ResultTaskOperationDone>(_sequencedExecutor, cmd.getBucketId(), std::move(task)));
return trackerUP;
}