diff options
author | Harald Musum <musum@verizonmedia.com> | 2022-04-30 21:14:38 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-30 21:14:38 +0200 |
commit | a4e669f0634b5555fdc9f57130dd9a1b5ca3afcd (patch) | |
tree | c521ade71f06dfbf9bc05db5d0616faaca280bc2 | |
parent | a106018d72fad65f64487164bd11e479947e68fa (diff) | |
parent | bb53d37efdf590c0eaa47037d39849b6c31b2f03 (diff) |
Merge pull request #22376 from vespa-engine/balder/do-not-log-when-failure-is-expectedv7.580.54
Only log when failure is unexpected.
-rw-r--r-- | logd/src/logd/rpc_forwarder.cpp | 2 | ||||
-rw-r--r-- | metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/logd/src/logd/rpc_forwarder.cpp b/logd/src/logd/rpc_forwarder.cpp index cd3ab1e01b5..fbd39afeba4 100644 --- a/logd/src/logd/rpc_forwarder.cpp +++ b/logd/src/logd/rpc_forwarder.cpp @@ -141,7 +141,7 @@ RpcForwarder::flush() if (!request->CheckReturnTypes("bix")) { auto error_msg = make_string("Error in rpc reply from logserver ('%s'): '%s'", _connection_spec.c_str(), request->GetErrorMessage()); - LOG(warning, "%s", error_msg.c_str()); + LOG(debug, "%s", error_msg.c_str()); throw ConnectionException(error_msg); } ProtoConverter::ProtoLogResponse proto_response; diff --git a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java index 43588f063cc..cb8e07b0282 100644 --- a/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java +++ b/metrics-proxy/src/main/java/ai/vespa/metricsproxy/service/RemoteHealthMetricFetcher.java @@ -34,7 +34,9 @@ public class RemoteHealthMetricFetcher extends HttpMetricFetcher { try (InputStream stream = getJson()) { return createHealthMetrics(stream, fetchCount); } catch (IOException | InterruptedException | ExecutionException e) { - logMessageNoResponse(errMsgNoResponse(e), fetchCount); + if (service.isAlive()) { + logMessageNoResponse(errMsgNoResponse(e), fetchCount); + } return HealthMetric.getUnknown("Failed fetching metrics for service: " + service.getMonitoringName()); } } |