Merge pull request #23150 from vespa-engine/jonmv/fix-success-factor-computation-ಠ_ಠ

Avoid division by zero in success factor computation  ಠ_ಠ

1 files changed, 2 insertions, 1 deletions

diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
index 5178918aa48..974345330aa 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/ReadyJobsTrigger.java
@@ -20,7 +20,8 @@ public class ReadyJobsTrigger extends ControllerMaintainer {
     @Override
     public double maintain() {
         TriggerResult result = controller().applications().deploymentTrigger().triggerReadyJobs();
-        return result.triggered() * 1.0f / (result.triggered() + result.failed());
+        long total = result.triggered() + result.failed();
+        return total == 0 ? 1 : (double) result.triggered() / (result.triggered() + result.failed());
     }
 
 }