aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2023-03-02 15:59:11 +0100
committerGitHub <noreply@github.com>2023-03-02 15:59:11 +0100
commit08597abba4e053b3c6bfcce121c6f51944dba70b (patch)
treeb11dd8e023edbebc6ae0840f7e4b06c05c769aa3
parentf28ae4c9a633dd52f57401544b393b9eca54eba2 (diff)
parente73e3f8ad2659f15031c084674f0bdfdbc8251da (diff)
Merge pull request #26276 from vespa-engine/toregge/make-set-tensor-private
Make DirectTensorAttribute::set_tensor member function private.
-rw-r--r--searchlib/src/tests/features/tensor/tensor_test.cpp2
-rw-r--r--searchlib/src/vespa/searchlib/tensor/direct_tensor_attribute.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/searchlib/src/tests/features/tensor/tensor_test.cpp b/searchlib/src/tests/features/tensor/tensor_test.cpp
index 54807273aea..5ad30c61c37 100644
--- a/searchlib/src/tests/features/tensor/tensor_test.cpp
+++ b/searchlib/src/tests/features/tensor/tensor_test.cpp
@@ -121,7 +121,7 @@ struct ExecFixture
.add({{"x", "b"}}, 5)
.add({{"x", "c"}}, 7));
tensorAttr->setTensor(1, *doc_tensor);
- directAttr->set_tensor(1, std::move(doc_tensor));
+ directAttr->setTensor(1, *doc_tensor);
for (const auto &attr : attrs) {
attr->commit();
diff --git a/searchlib/src/vespa/searchlib/tensor/direct_tensor_attribute.h b/searchlib/src/vespa/searchlib/tensor/direct_tensor_attribute.h
index d331cdca440..73bd929aee6 100644
--- a/searchlib/src/vespa/searchlib/tensor/direct_tensor_attribute.h
+++ b/searchlib/src/vespa/searchlib/tensor/direct_tensor_attribute.h
@@ -14,6 +14,7 @@ class DirectTensorAttribute final : public TensorAttribute
{
DirectTensorStore _direct_store;
+ void set_tensor(DocId docId, std::unique_ptr<vespalib::eval::Value> tensor);
public:
DirectTensorAttribute(vespalib::stringref baseFileName, const Config &cfg, const NearestNeighborIndexFactory& index_factory = DefaultNearestNeighborIndexFactory());
~DirectTensorAttribute() override;
@@ -21,7 +22,6 @@ public:
void update_tensor(DocId docId,
const document::TensorUpdate &update,
bool create_empty_if_non_existing) override;
- void set_tensor(DocId docId, std::unique_ptr<vespalib::eval::Value> tensor);
const vespalib::eval::Value &get_tensor_ref(DocId docId) const override;
bool supports_get_tensor_ref() const override { return true; }