aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2021-11-28 23:30:38 +0100
committerHarald Musum <musum@yahooinc.com>2021-11-28 23:30:38 +0100
commit2951e8ed72b175b137ea8bd3b9560002847f2897 (patch)
tree5140e08f59df4d00de8553c97f9b92c65b0baee8
parent434fd1cdb6dee96513779a4a2a6719e9bb4c8b62 (diff)
Add some more logging for file distribution connects
Sometimes seeing some request fail after a very short time with connection error, not sure what causes it, trying to debug
-rw-r--r--config/src/main/java/com/yahoo/vespa/config/JRTConnection.java1
-rw-r--r--filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java8
2 files changed, 6 insertions, 3 deletions
diff --git a/config/src/main/java/com/yahoo/vespa/config/JRTConnection.java b/config/src/main/java/com/yahoo/vespa/config/JRTConnection.java
index c1fc50f6a82..f731d49941a 100644
--- a/config/src/main/java/com/yahoo/vespa/config/JRTConnection.java
+++ b/config/src/main/java/com/yahoo/vespa/config/JRTConnection.java
@@ -53,6 +53,7 @@ public class JRTConnection implements Connection {
if (target == null || !target.isValid()) {
logger.log(Level.INFO, "Connecting to " + address);
target = supervisor.connect(new Spec(address));
+ logger.log(Level.FINE, "Connected to " + address);
}
return target;
}
diff --git a/filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java b/filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java
index 6bace104d88..e3edee2956f 100644
--- a/filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java
+++ b/filedistribution/src/main/java/com/yahoo/vespa/filedistribution/FileReferenceDownloader.java
@@ -92,7 +92,8 @@ public class FileReferenceDownloader {
private boolean startDownloadRpc(FileReferenceDownload fileReferenceDownload, int retryCount, Connection connection) {
Request request = createRequest(fileReferenceDownload);
- connection.invokeSync(request, rpcTimeout(retryCount).getSeconds());
+ Duration rpcTimeout = rpcTimeout(retryCount);
+ connection.invokeSync(request, rpcTimeout.getSeconds());
Level logLevel = (retryCount > 3 ? Level.INFO : Level.FINE);
FileReference fileReference = fileReferenceDownload.fileReference();
@@ -107,8 +108,9 @@ public class FileReferenceDownloader {
}
} else {
log.log(logLevel, "Downloading " + fileReference + " from " + connection.getAddress() + " failed: " +
- request + ", error: " + request.errorMessage() + ", will switch config server for next request" +
- " (retry " + retryCount + ", rpc timeout " + rpcTimeout(retryCount) + ")");
+ request + ", error: " + request.errorCode() + "(" + request.errorMessage() +
+ "). Will switch config server for next request" +
+ " (retry " + retryCount + ", rpc timeout " + rpcTimeout + ")");
return false;
}
}