aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Marius Venstad <jvenstad@yahoo-inc.com>2018-08-16 19:00:48 +0200
committerJon Marius Venstad <jvenstad@yahoo-inc.com>2018-08-16 19:00:48 +0200
commit2d1626f0f38fbc5acab0c33c0e94e02e65b2ae98 (patch)
treebedc341a4858e0b5791d66e188075b810f588de4
parenta62a3b47817ebb52f8ea4413d37804d4da459171 (diff)
Revert "Look for upper case log levels by modifying the search term"
This reverts commit a62a3b47817ebb52f8ea4413d37804d4da459171.
-rw-r--r--vespalog/src/main/java/com/yahoo/log/LogLevel.java19
-rw-r--r--vespalog/src/test/java/com/yahoo/log/LogLevelTestCase.java9
2 files changed, 18 insertions, 10 deletions
diff --git a/vespalog/src/main/java/com/yahoo/log/LogLevel.java b/vespalog/src/main/java/com/yahoo/log/LogLevel.java
index daf2a0ff44d..f9cc4e9b7e3 100644
--- a/vespalog/src/main/java/com/yahoo/log/LogLevel.java
+++ b/vespalog/src/main/java/com/yahoo/log/LogLevel.java
@@ -1,7 +1,6 @@
// Copyright 2017 Yahoo Holdings. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
package com.yahoo.log;
-import java.nio.charset.StandardCharsets;
import java.util.HashMap;
import java.util.Map;
import java.util.LinkedHashMap;
@@ -105,13 +104,21 @@ public class LogLevel extends Level {
// manually enter the valid log levels we shall recognize in VESPA
nameToLevel = new LinkedHashMap<String, Level>(32);
nameToLevel.put("fatal", FATAL);
+ nameToLevel.put("FATAL", FATAL);
nameToLevel.put("error", ERROR);
+ nameToLevel.put("ERROR", ERROR);
nameToLevel.put("warning", WARNING);
+ nameToLevel.put("WARNING", WARNING);
nameToLevel.put("config", CONFIG);
+ nameToLevel.put("CONFIG", CONFIG);
nameToLevel.put("info", INFO);
+ nameToLevel.put("INFO", INFO);
nameToLevel.put("event", EVENT);
+ nameToLevel.put("EVENT", EVENT);
nameToLevel.put("debug", DEBUG);
+ nameToLevel.put("DEBUG", DEBUG);
nameToLevel.put("spam", SPAM);
+ nameToLevel.put("SPAM", SPAM);
}
private LogLevel(String name, int value) {
@@ -132,15 +139,7 @@ public class LogLevel extends Level {
public static Level parse(String name) {
Level l = nameToLevel.get(name);
if (l == null) {
- // If name was not found, try changing the case of each character from (assumed) upper to lower:
- byte[] nameBytes = name.getBytes(StandardCharsets.UTF_8);
- for (int i = 0; i < nameBytes.length; i++)
- nameBytes[i] += 32;
- l = nameToLevel.get(new String(nameBytes));
-
- if (l == null) {
- return UNKNOWN;
- }
+ return UNKNOWN;
}
return l;
}
diff --git a/vespalog/src/test/java/com/yahoo/log/LogLevelTestCase.java b/vespalog/src/test/java/com/yahoo/log/LogLevelTestCase.java
index 8caa01f775b..aa9a2b36221 100644
--- a/vespalog/src/test/java/com/yahoo/log/LogLevelTestCase.java
+++ b/vespalog/src/test/java/com/yahoo/log/LogLevelTestCase.java
@@ -55,14 +55,23 @@ public class LogLevelTestCase {
@Test
public void testNameToLevelMapping () {
assertEquals(LogLevel.UNKNOWN, LogLevel.parse("unknown"));
+ assertEquals(LogLevel.UNKNOWN, LogLevel.parse("UNKNOWN"));
assertEquals(LogLevel.FATAL, LogLevel.parse("fatal"));
+ assertEquals(LogLevel.FATAL, LogLevel.parse("FATAL"));
assertEquals(LogLevel.ERROR, LogLevel.parse("error"));
+ assertEquals(LogLevel.ERROR, LogLevel.parse("ERROR"));
assertEquals(LogLevel.WARNING, LogLevel.parse("warning"));
+ assertEquals(LogLevel.WARNING, LogLevel.parse("WARNING"));
assertEquals(LogLevel.INFO, LogLevel.parse("info"));
+ assertEquals(LogLevel.INFO, LogLevel.parse("INFO"));
assertEquals(LogLevel.CONFIG, LogLevel.parse("config"));
+ assertEquals(LogLevel.CONFIG, LogLevel.parse("CONFIG"));
assertEquals(LogLevel.EVENT, LogLevel.parse("event"));
+ assertEquals(LogLevel.EVENT, LogLevel.parse("EVENT"));
assertEquals(LogLevel.DEBUG, LogLevel.parse("debug"));
+ assertEquals(LogLevel.DEBUG, LogLevel.parse("DEBUG"));
assertEquals(LogLevel.SPAM, LogLevel.parse("spam"));
+ assertEquals(LogLevel.SPAM, LogLevel.parse("SPAM"));
LogLevel.getLevels().values().forEach(level -> assertEquals(level, LogLevel.parse(level.getName())));
}