diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2022-10-12 00:36:32 +0200 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2022-10-12 00:36:32 +0200 |
commit | 4cf6952345ac2fdcb9b14f1dc875a17d4fa2796d (patch) | |
tree | 9815b061e39d7def7b56dc764dd2d400e1c46cef | |
parent | 4aa8894cd206e0e33847c90606c92c783b09fb2d (diff) |
Prefer ArrayList over LinkedList as it is normally faster.
-rw-r--r-- | container-search/src/main/java/com/yahoo/search/dispatch/rpc/MapConverter.java | 10 | ||||
-rw-r--r-- | vespajlib/src/main/java/com/yahoo/tensor/serialization/TypedBinaryFormat.java | 1 |
2 files changed, 5 insertions, 6 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/dispatch/rpc/MapConverter.java b/container-search/src/main/java/com/yahoo/search/dispatch/rpc/MapConverter.java index a71ec5d8345..5e423a51b7a 100644 --- a/container-search/src/main/java/com/yahoo/search/dispatch/rpc/MapConverter.java +++ b/container-search/src/main/java/com/yahoo/search/dispatch/rpc/MapConverter.java @@ -7,7 +7,7 @@ import com.google.protobuf.ByteString; import com.yahoo.tensor.Tensor; import com.yahoo.tensor.serialization.TypedBinaryFormat; -import java.util.LinkedList; +import java.util.ArrayList; import java.util.List; import java.util.Map; import java.util.function.Consumer; @@ -51,12 +51,12 @@ public class MapConverter { for (var entry : map.entrySet()) { if (entry.getValue() != null) { var key = entry.getKey(); - var stringValues = new LinkedList<String>(); + var stringValues = new ArrayList<String>(); for (var value : entry.getValue()) { if (value != null) { - if (value instanceof Tensor) { - byte[] tensor = TypedBinaryFormat.encode((Tensor) value); - tensorInserter.accept(TensorProperty.newBuilder().setName(key).setValue(ByteString.copyFrom(tensor))); + if (value instanceof Tensor tensor) { + byte[] encoded = TypedBinaryFormat.encode(tensor); + tensorInserter.accept(TensorProperty.newBuilder().setName(key).setValue(ByteString.copyFrom(encoded))); } else { stringValues.add(value.toString()); } diff --git a/vespajlib/src/main/java/com/yahoo/tensor/serialization/TypedBinaryFormat.java b/vespajlib/src/main/java/com/yahoo/tensor/serialization/TypedBinaryFormat.java index eddb90ea84c..a08e09765c8 100644 --- a/vespajlib/src/main/java/com/yahoo/tensor/serialization/TypedBinaryFormat.java +++ b/vespajlib/src/main/java/com/yahoo/tensor/serialization/TypedBinaryFormat.java @@ -2,7 +2,6 @@ package com.yahoo.tensor.serialization; import com.yahoo.io.GrowableByteBuffer; -import com.yahoo.tensor.IndexedTensor; import com.yahoo.tensor.MixedTensor; import com.yahoo.tensor.Tensor; import com.yahoo.tensor.TensorType; |