successFactorDeviation cannot be lower than -successFactorBaseline

1 files changed, 3 insertions, 1 deletions

diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/BcpGroupUpdater.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/BcpGroupUpdater.java
index b8c7b5aef9b..fe1930a19ea 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/BcpGroupUpdater.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/BcpGroupUpdater.java
@@ -42,11 +42,13 @@ public class BcpGroupUpdater extends ControllerMaintainer {
 
     private final ApplicationController applications;
     private final NodeRepository nodeRepository;
+    private final Double successFactorBaseline;
 
     public BcpGroupUpdater(Controller controller, Duration duration, Double successFactorBaseline) {
         super(controller, duration, successFactorBaseline);
         this.applications = controller.applications();
         this.nodeRepository = controller.serviceRegistry().configServer().nodeRepository();
+        this.successFactorBaseline = successFactorBaseline;
     }
 
     @Override
@@ -76,7 +78,7 @@ public class BcpGroupUpdater extends ControllerMaintainer {
             }
         }
         double successFactorDeviation = asSuccessFactorDeviation(attempts, failures);
-        if ( successFactorDeviation == -1.0 )
+        if ( successFactorDeviation == -successFactorBaseline )
             log.log(Level.WARNING, "Could not update traffic share on any applications", lastException);
         else if ( successFactorDeviation < -0.1 )
             log.log(Level.FINE, "Could not update traffic share on all applications", lastException);