aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJon Bratseth <bratseth@gmail.com>2022-07-22 10:21:51 +0200
committerGitHub <noreply@github.com>2022-07-22 10:21:51 +0200
commit58a7c193360e6aca3da295592f8b5ab5fcf6424e (patch)
tree3bb78fae23ec535f81243d3dd26f592d4e867ae6
parent4eeac7604517389a61311e9f45e587c75a5849e0 (diff)
parent58c74f0c310ca052330aa0510066383b238d1082 (diff)
Merge pull request #23529 from akolhun/fix-number-range-parsingv8.22.20
Skip number ranges with empty rangeStart and non-numeric rangeEnd
-rw-r--r--container-search/src/main/java/com/yahoo/prelude/query/parser/StructuredParser.java1
-rw-r--r--container-search/src/test/java/com/yahoo/search/yql/UserInputTestCase.java9
2 files changed, 10 insertions, 0 deletions
diff --git a/container-search/src/main/java/com/yahoo/prelude/query/parser/StructuredParser.java b/container-search/src/main/java/com/yahoo/prelude/query/parser/StructuredParser.java
index 54a6e5b6e90..f993c7a9e02 100644
--- a/container-search/src/main/java/com/yahoo/prelude/query/parser/StructuredParser.java
+++ b/container-search/src/main/java/com/yahoo/prelude/query/parser/StructuredParser.java
@@ -333,6 +333,7 @@ abstract class StructuredParser extends AbstractParser {
if (tokens.currentIs(NUMBER)) {
rangeEnd = (negative ? "-" : "") + tokens.next().toString() + decimalPart();
}
+ if (rangeStart.isBlank() && rangeEnd.isBlank()) return null;
String range = "[" + rangeStart + ";" + rangeEnd;
diff --git a/container-search/src/test/java/com/yahoo/search/yql/UserInputTestCase.java b/container-search/src/test/java/com/yahoo/search/yql/UserInputTestCase.java
index 5e97b59646f..4af29822a26 100644
--- a/container-search/src/test/java/com/yahoo/search/yql/UserInputTestCase.java
+++ b/container-search/src/test/java/com/yahoo/search/yql/UserInputTestCase.java
@@ -359,4 +359,13 @@ public class UserInputTestCase {
assertQueryFails(builder);
}
+ @Test
+ public void testUserInputWithEmptyRangeStart() {
+ URIBuilder builder = searchUri();
+ builder.setParameter("wql", "[;boom]");
+ builder.setParameter("yql", "select * from sources * where ([{\"defaultIndex\": \"text_field\",\"grammar\": \"any\"}]userInput(@wql))");
+ Query query = searchAndAssertNoErrors(builder);
+ assertEquals("select * from sources * where text_field contains \"boom\"", query.yqlRepresentation());
+ }
+
}