aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArne Juul <arnej@yahoo-inc.com>2018-11-20 14:38:58 +0000
committergjoranv <gv@oath.com>2019-01-21 15:09:28 +0100
commit791dd80ea050b3aa8edcf7e3ea38aba36b54f2d9 (patch)
tree3a9a5d69818aafad4f30ae3beebec667dc920016
parentda88cf82f4a5c51bf5dda9531c8655a6eb90a380 (diff)
remove split header/body methods
-rw-r--r--document/src/main/java/com/yahoo/document/Document.java32
-rw-r--r--document/src/main/java/com/yahoo/document/DocumentTypeManager.java6
-rw-r--r--document/src/main/java/com/yahoo/document/serialization/DocumentDeserializerFactory.java7
-rw-r--r--document/src/test/java/com/yahoo/document/DocumentTestCase.java129
4 files changed, 0 insertions, 174 deletions
diff --git a/document/src/main/java/com/yahoo/document/Document.java b/document/src/main/java/com/yahoo/document/Document.java
index ab602880453..cf0951fb035 100644
--- a/document/src/main/java/com/yahoo/document/Document.java
+++ b/document/src/main/java/com/yahoo/document/Document.java
@@ -345,38 +345,6 @@ public class Document extends StructuredFieldValue {
serialize((DocumentWriter)data);
}
- @SuppressWarnings("deprecation")
- @Deprecated // remove before Vespa 8
- public void serializeHeader(Serializer data) throws SerializationException {
- if (data instanceof DocumentWriter) {
- if (data instanceof com.yahoo.document.serialization.VespaDocumentSerializer42) {
- ((com.yahoo.document.serialization.VespaDocumentSerializer42)data).setHeaderOnly(true);
- }
- serialize((DocumentWriter)data);
- } else if (data instanceof BufferSerializer) {
- serialize(DocumentSerializerFactory.create42(((BufferSerializer) data).getBuf(), true));
- } else {
- DocumentSerializer fw = DocumentSerializerFactory.create42(new GrowableByteBuffer(), true);
- serialize(fw);
- data.put(null, fw.getBuf().getByteBuffer());
- }
- }
-
- @Deprecated // remove before Vespa 8
- public void serializeBody(Serializer data) throws SerializationException {
- if (getBody().getFieldCount() > 0) {
- if (data instanceof FieldWriter) {
- getBody().serialize(new Field("body", getBody().getDataType()), (FieldWriter) data);
- } else if (data instanceof BufferSerializer) {
- getBody().serialize(new Field("body", getBody().getDataType()), DocumentSerializerFactory.create42(((BufferSerializer) data).getBuf()));
- } else {
- DocumentSerializer fw = DocumentSerializerFactory.create42(new GrowableByteBuffer());
- getBody().serialize(new Field("body", getBody().getDataType()), fw);
- data.put(null, fw.getBuf().getByteBuffer());
- }
- }
- }
-
@Override
public DocumentType getDataType() {
return (DocumentType)super.getDataType();
diff --git a/document/src/main/java/com/yahoo/document/DocumentTypeManager.java b/document/src/main/java/com/yahoo/document/DocumentTypeManager.java
index 0bcc94ad86b..a3ba27b640f 100644
--- a/document/src/main/java/com/yahoo/document/DocumentTypeManager.java
+++ b/document/src/main/java/com/yahoo/document/DocumentTypeManager.java
@@ -273,12 +273,6 @@ public class DocumentTypeManager {
return new Document(data);
}
- @Deprecated // TODO remove before Vespa 8
- public Document createDocument(GrowableByteBuffer header, GrowableByteBuffer body) {
- DocumentDeserializer data = DocumentDeserializerFactory.create42(this, header, body);
- return new Document(data);
- }
-
/**
* Returns a read only view of the registered data types
*
diff --git a/document/src/main/java/com/yahoo/document/serialization/DocumentDeserializerFactory.java b/document/src/main/java/com/yahoo/document/serialization/DocumentDeserializerFactory.java
index 9cd11ad2499..03aa409ee8d 100644
--- a/document/src/main/java/com/yahoo/document/serialization/DocumentDeserializerFactory.java
+++ b/document/src/main/java/com/yahoo/document/serialization/DocumentDeserializerFactory.java
@@ -35,11 +35,4 @@ public class DocumentDeserializerFactory {
return new VespaDocumentDeserializer42(manager, buf);
}
- /**
- * Creates a de-serializer for the document format that was created on Vespa 4.2.
- */
- @SuppressWarnings("deprecation")
- public static DocumentDeserializer create42(DocumentTypeManager manager, GrowableByteBuffer buf, GrowableByteBuffer body) {
- return new VespaDocumentDeserializer42(manager, buf, body);
- }
}
diff --git a/document/src/test/java/com/yahoo/document/DocumentTestCase.java b/document/src/test/java/com/yahoo/document/DocumentTestCase.java
index 6cdd2a9f8fb..28267a22a56 100644
--- a/document/src/test/java/com/yahoo/document/DocumentTestCase.java
+++ b/document/src/test/java/com/yahoo/document/DocumentTestCase.java
@@ -708,54 +708,6 @@ public class DocumentTestCase extends DocumentTestCaseBase {
}
@Test
- public void testCppDocSplit() throws IOException {
- docMan = setUpCppDocType();
- byte[] headerData = readFile("src/test/document/serializecppsplit_header.dat");
- byte[] bodyData = readFile("src/test/document/serializecppsplit_body.dat");
-
- DocumentDeserializer header = DocumentDeserializerFactory.create42(docMan, GrowableByteBuffer.wrap(headerData),
- GrowableByteBuffer.wrap(bodyData));
-
- Document doc = new Document(header);
-
- assertEquals("doc:serializetest:http://test.doc.id/", doc.getId().toString());
- assertEquals(new IntegerFieldValue(5), doc.getFieldValue("intfield"));
- assertEquals(new FloatFieldValue((float)-9.23), doc.getFieldValue("floatfield"));
- assertEquals(new StringFieldValue("This is a string."), doc.getFieldValue("stringfield"));
- assertEquals(new LongFieldValue(398420092938472983L), doc.getFieldValue("longfield"));
- assertEquals(new DoubleFieldValue(98374532.398820d), doc.getFieldValue("doublefield"));
- assertEquals(new StringFieldValue("http://this.is.a.test/"), doc.getFieldValue("urifield"));
- //NOTE: The value really is unsigned 254, which becomes signed -2:
- assertEquals(new ByteFieldValue((byte)-2), doc.getFieldValue("bytefield"));
- ByteBuffer raw = ByteBuffer.wrap("RAW DATA".getBytes());
- assertEquals(new Raw(raw), doc.getFieldValue("rawfield"));
-
- Document docindoc = (Document)doc.getFieldValue("docfield");
- assertEquals(docMan.getDocumentType("docindoc"), docindoc.getDataType());
- assertEquals(new DocumentId("doc:docindoc:http://embedded"), docindoc.getId());
-
- WeightedSet wset = (WeightedSet)doc.getFieldValue("wsfield");
- assertEquals(Integer.valueOf(50), wset.get(new StringFieldValue("Weighted 0")));
- assertEquals(Integer.valueOf(199), wset.get(new StringFieldValue("Weighted 1")));
- }
-
- @Test
- public void testCppDocSplitNoBody() throws IOException {
- docMan = setUpCppDocType();
- byte[] headerData = readFile("src/test/document/serializecppsplit_header.dat");
-
- DocumentDeserializer header = DocumentDeserializerFactory.create42(docMan, GrowableByteBuffer.wrap(headerData));
-
- Document doc = new Document(header);
-
- assertEquals("doc:serializetest:http://test.doc.id/", doc.getId().toString());
- assertEquals(new FloatFieldValue((float)-9.23), doc.getFieldValue("floatfield"));
- assertEquals(new StringFieldValue("This is a string."), doc.getFieldValue("stringfield"));
- assertEquals(new LongFieldValue(398420092938472983L), doc.getFieldValue("longfield"));
- assertEquals(new StringFieldValue("http://this.is.a.test/"), doc.getFieldValue("urifield"));
- }
-
- @Test
@SuppressWarnings("deprecation")
public void testGenerateSerializedFile() throws IOException {
@@ -862,48 +814,6 @@ public class DocumentTestCase extends DocumentTestCaseBase {
}
assertEquals(doc.getFieldValue("weightedfield"), doc2.getFieldValue("weightedfield"));
assertEquals(doc.getFieldValue("mapfield"), doc2.getFieldValue("mapfield"));
- // Do the same thing, splitting document in two
- DocumentSerializer header = DocumentSerializerFactory.create42(new GrowableByteBuffer(), true);
- DocumentSerializer body = DocumentSerializerFactory.create42(new GrowableByteBuffer());
- doc.serializeHeader(header);
- doc.serializeBody(body);
- header.getBuf().flip();
- body.getBuf().flip();
-
- try {
- FileOutputStream fos = new FileOutputStream("src/test/files/testser-split.header.dat");
- fos.write(header.getBuf().array(), 0, header.getBuf().remaining());
- fos.close();
- fos = new FileOutputStream("src/test/files/testser-split.body.dat");
- fos.write(body.getBuf().array(), 0, body.getBuf().remaining());
- fos.close();
- } catch (Exception e) {
- }
-
- DocumentDeserializer deser = DocumentDeserializerFactory.create42(docMan, header.getBuf(), body.getBuf());
-
- doc2 = new Document(deser);
-
- assertEquals(doc.getFieldValue("mailid"), doc2.getFieldValue("mailid"));
- assertEquals(doc.getFieldValue("date"), doc2.getFieldValue("date"));
- assertEquals(doc.getFieldValue("from"), doc2.getFieldValue("from"));
- assertEquals(doc.getFieldValue("to"), doc2.getFieldValue("to"));
- assertEquals(doc.getFieldValue("subject"), doc2.getFieldValue("subject"));
- assertEquals(doc.getFieldValue("body"), doc2.getFieldValue("body"));
- assertEquals(doc.getFieldValue("attachmentcount"), doc2.getFieldValue("attachmentcount"));
- assertEquals(doc.getFieldValue("attachments"), doc2.getFieldValue("attachments"));
- docRawBytes = ((Raw)doc.getFieldValue("rawfield")).getByteBuffer().array();
- doc2RawBytes = ((Raw)doc2.getFieldValue("rawfield")).getByteBuffer().array();
- assertEquals(docRawBytes.length, doc2RawBytes.length);
- for (int i = 0; i < docRawBytes.length; i++) {
- assertEquals(docRawBytes[i], doc2RawBytes[i]);
- }
- assertEquals(doc.getFieldValue("weightedfield"), doc2.getFieldValue("weightedfield"));
- assertEquals(doc.getFieldValue("mapfield"), doc2.getFieldValue("mapfield"));
-
- Document docInDoc = (Document)doc.getFieldValue("docindoc");
- assert (docInDoc != null);
- assertEquals(new StringFieldValue("ball"), docInDoc.getFieldValue("tull"));
}
@Test
@@ -953,45 +863,6 @@ public class DocumentTestCase extends DocumentTestCaseBase {
}
assertEquals(doc.getFieldValue("weightedfield"), doc2.getFieldValue("weightedfield"));
assertEquals(doc.getFieldValue("mapfield"), doc2.getFieldValue("mapfield"));
-
- // Do the same thing, splitting document in two
- BufferSerializer header = new BufferSerializer(new GrowableByteBuffer());
- BufferSerializer body = new BufferSerializer(new GrowableByteBuffer());
- doc.serializeHeader(header);
- doc.serializeBody(body);
- header.getBuf().flip();
- body.getBuf().flip();
-
- try {
- FileOutputStream fos = new FileOutputStream("src/test/files/testser-split.header.dat");
- fos.write(header.getBuf().array(), 0, header.getBuf().remaining());
- fos.close();
- fos = new FileOutputStream("src/test/files/testser-split.body.dat");
- fos.write(body.getBuf().array(), 0, body.getBuf().remaining());
- fos.close();
- } catch (Exception e) {
- }
-
- DocumentDeserializer deser = DocumentDeserializerFactory.create42(docMan, header.getBuf(), body.getBuf());
-
- doc2 = new Document(deser);
-
- assertEquals(doc.getFieldValue("mailid"), doc2.getFieldValue("mailid"));
- assertEquals(doc.getFieldValue("date"), doc2.getFieldValue("date"));
- assertEquals(doc.getFieldValue("from"), doc2.getFieldValue("from"));
- assertEquals(doc.getFieldValue("to"), doc2.getFieldValue("to"));
- assertEquals(doc.getFieldValue("subject"), doc2.getFieldValue("subject"));
- assertEquals(doc.getFieldValue("body"), doc2.getFieldValue("body"));
- assertEquals(doc.getFieldValue("attachmentcount"), doc2.getFieldValue("attachmentcount"));
- assertEquals(doc.getFieldValue("attachments"), doc2.getFieldValue("attachments"));
- docRawBytes = ((Raw)doc.getFieldValue("rawfield")).getByteBuffer().array();
- doc2RawBytes = ((Raw)doc2.getFieldValue("rawfield")).getByteBuffer().array();
- assertEquals(docRawBytes.length, doc2RawBytes.length);
- for (int i = 0; i < docRawBytes.length; i++) {
- assertEquals(docRawBytes[i], doc2RawBytes[i]);
- }
- assertEquals(doc.getFieldValue("weightedfield"), doc2.getFieldValue("weightedfield"));
- assertEquals(doc.getFieldValue("mapfield"), doc2.getFieldValue("mapfield"));
}
@Test